From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58839: [Patch] Re: bug#58839: 29.0.50; project-kill-buffer fails when Eglot is running Date: Tue, 1 Nov 2022 13:39:05 +0000 Message-ID: References: <87sfj8umwb.fsf@posteo.net> <87edur3lil.fsf@posteo.net> <87a65f3j40.fsf@posteo.net> <213f3549-de4e-25a7-5e27-d13893e557bc@yandex.ru> <87zgdfwkle.fsf@gmail.com> <8e31a89d-e35e-6dd0-a8e3-f0b9684c8bfa@yandex.ru> <87v8o3wgq1.fsf@gmail.com> <87ilk2x1si.fsf@gmail.com> <871qqq7l9p.fsf@posteo.net> <87eduqwekz.fsf@gmail.com> <87wn8invbx.fsf@posteo.net> <877d0iw8iq.fsf@gmail.com> <837d0hhlke.fsf@gnu.org> <46ff0065-5645-ef1e-2621-242fb6a73f98@yandex.ru> <87v8o0uxn5.fsf@gmail.com> <87k04ggixk.fsf@posteo.net> <875yfzvawz.fsf@gmail.com> <351398ad-1292-f366-3adf-f86a129f9c90@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009f58a305ec68d565" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24682"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , 58839@debbugs.gnu.org, manuel.uberti@inventati.org, Eli Zaretskii To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 01 15:03:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oprrd-0006AX-82 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Nov 2022 15:03:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oprTr-0002gV-Es; Tue, 01 Nov 2022 09:39:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oprTq-0002gM-JW for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 09:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oprTq-0004N8-Br for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 09:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oprTq-0002Qe-6k for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 09:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2022 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58839 X-GNU-PR-Package: emacs Original-Received: via spool by 58839-submit@debbugs.gnu.org id=B58839.16673098959272 (code B ref 58839); Tue, 01 Nov 2022 13:39:02 +0000 Original-Received: (at 58839) by debbugs.gnu.org; 1 Nov 2022 13:38:15 +0000 Original-Received: from localhost ([127.0.0.1]:42956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oprT4-0002PU-VU for submit@debbugs.gnu.org; Tue, 01 Nov 2022 09:38:15 -0400 Original-Received: from mail-oa1-f46.google.com ([209.85.160.46]:33686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oprT3-0002PH-On for 58839@debbugs.gnu.org; Tue, 01 Nov 2022 09:38:14 -0400 Original-Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-13bd2aea61bso16868431fac.0 for <58839@debbugs.gnu.org>; Tue, 01 Nov 2022 06:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vHc9DcZ5LRcp6WiUPIRkf4ktgh7G+pHsBpMQX3uIVnI=; b=cp7QcXccTkaTbHdRpmFrC6sSu/UIHUOGbkI1atlEVf/vp3BSd1rc4+Hd3SgtjqLgb1 Z+23PkCXgfOloeN3UzmfyXOxnq2uAY4SBPtp00Z+vweE531kYSI/h4lot6DquN5bbl8d 3d+NJuP3QzT+yQK8eFRm42O/vo0GEUck4kDj7DOoQIgc/SGlLrZjHtcmGl8/+JjhB3Fu pUNHgwvyGNF9NTN2tU+xXDRt4haVBOxSt/VOgNumDu96lWHUd0aBbkaF1COV+7UX7FVf 4kSpXmxrzby3MfG0fLZSq6wao7MBjt9P+mWOBH0HyNRa+LcQx/8psG4/9r8j9cKLLT6W fv6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vHc9DcZ5LRcp6WiUPIRkf4ktgh7G+pHsBpMQX3uIVnI=; b=IQqyITBseQUIn9ajQsAMNV6XxP2PtKJ08x9Y92aCj8rwUsGL+VHAQ4yZMmRlWeNbCw Th7zyXg8AzB6ioLfxeXoevFNBoJ6lNSRcfuVtbV54YtxUboGBo3kS7YZrh9a+pBVVjXz 8N8kLGSu4pd5oyqjPR22+34PTfX+LhA8Mbmra4Nr4AbbVlf6mlbndiAA4L0g8oi5M93H PdFlOGqIjlkSfYzwlhc7z/lWsTw8OCHKwkY6BU9RSi7Rc41TcwxZjlexdP0djcxiwxqv iLqqRRgTDvpwBIoun8eXqqvPJtgTlc0vmEAPBITo6DWaclfpLKRhZw7dOi4XVvZFNheF r/CA== X-Gm-Message-State: ACrzQf1xMVeHK8WdFw8JLn/d/mm/2fiV8xaVH6LUXjFbePJJMa6034fO 7nzKROMHuqhY7OlGxx6ST+KnSyKuEIBmRW88rLQ= X-Google-Smtp-Source: AMsMyM5eGntpjLBp9j2IuK5wbR/ZJO9HnQMKa6xLWAh0RrxvUnir59AmpylqeNnSd7v2GBDpGxOf9+KfyGay6fasTlY= X-Received: by 2002:a05:6870:e242:b0:13b:d561:ad02 with SMTP id d2-20020a056870e24200b0013bd561ad02mr11297714oac.215.1667309888295; Tue, 01 Nov 2022 06:38:08 -0700 (PDT) In-Reply-To: <351398ad-1292-f366-3adf-f86a129f9c90@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246772 Archived-At: --0000000000009f58a305ec68d565 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 1, 2022 at 1:22 PM Dmitry Gutov wrote: > On 01.11.2022 01:19, Jo=C3=A3o T=C3=A1vora wrote: > > We can try to make some backward compatible way, but this seems like th= e > > perfect occasion to activate this most reasonable header in project.el: > > > > ;; NOTE: The project API is still experimental and can change in > major, > > ;; backward-incompatible ways. Everyone is encouraged to try it, > and > > ;; report to us any problems or use cases we hadn't anticipated, b= y > > ;; sending an email to emacs-devel, or `M-x report-emacs-bug'. > > This is about the API. > > project-kills-buffers is not part of it. It's just a regular user-level > command, to be evolved how we do with regular commands. project-kill-buffers is great: I don't mean to deprecate it change it, its protocol etc. If "evolution" means fixing what are demonstrably its very salient bugs, that's great. Philip's worry was about project-kill-buffer-conditions. That variable contains a programming language and could be deprecated (if we arrive at the conclusion that it is easily replaced by something else). We shouldn't be shy of doing so a backward-incompatible way, given that its usage is estimated to be minimal (and this estimation is backed up by real data, not just a guess). --0000000000009f58a305ec68d565 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Nov 1, 2022 at 1:22 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
On 01.11.2022 01:19, Jo=C3=A3o T=C3=A1vora= wrote:
> We can try to make some backward compatible way, but this seems like t= he
> perfect occasion to activate this most reasonable header in project.el= :
>
>=C2=A0 =C2=A0 =C2=A0 ;; NOTE: The project API is still experimental and= can change in major,
>=C2=A0 =C2=A0 =C2=A0 ;; backward-incompatible ways.=C2=A0 Everyone is e= ncouraged to try it, and
>=C2=A0 =C2=A0 =C2=A0 ;; report to us any problems or use cases we hadn&= #39;t anticipated, by
>=C2=A0 =C2=A0 =C2=A0 ;; sending an email to emacs-devel, or `M-x report= -emacs-bug'.

This is about the API.

project-kills-buffers is not part of it. It's just a regular user-level=
command, to be evolved how we do with regular commands.
<= div>
project-kill-buffers is great: I don't me= an to deprecate it change it,
its protocol etc.=C2=A0 If &qu= ot;evolution" means fixing what are demonstrably
its ve= ry salient bugs, that's great.

Philip'= s worry was about project-kill-buffer-conditions.=C2=A0 That variable
<= /div>
contains a programming language and could be deprecated (if we
arrive at the conclusion that it is easily replaced by somethi= ng else).
We shouldn't be shy of doing so a backward-incompat= ible way, given that
its usage is estimated to be minimal (and th= is estimation is backed up
by real data, not just a guess).
--0000000000009f58a305ec68d565--