From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master e4896fc 1/2: Add a new 'flex' completion style Date: Thu, 14 Feb 2019 14:50:45 +0000 Message-ID: References: <20190213212413.868.40960@vcs0.savannah.gnu.org> <20190213212414.D6F4C209C6@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207438"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 14 15:52:06 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1guIMu-000rif-GX for ged-emacs-devel@m.gmane.org; Thu, 14 Feb 2019 15:52:04 +0100 Original-Received: from localhost ([127.0.0.1]:49685 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guIMt-0002du-BK for ged-emacs-devel@m.gmane.org; Thu, 14 Feb 2019 09:52:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guIMn-0002bU-Jb for emacs-devel@gnu.org; Thu, 14 Feb 2019 09:51:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1guILs-0001Kd-BU for emacs-devel@gnu.org; Thu, 14 Feb 2019 09:51:02 -0500 Original-Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:33054) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1guILq-0001GN-Ek for emacs-devel@gnu.org; Thu, 14 Feb 2019 09:50:59 -0500 Original-Received: by mail-qk1-x72a.google.com with SMTP id x9so3735413qkf.0 for ; Thu, 14 Feb 2019 06:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Z1YJNgcsdqTik2xxRi9BrgcxpgcKVUnuwKjJsZCetf4=; b=IS1bpC7INrKZwUnmmVSYh9xEfthTitJqFvdwqRG8nSHI3VbQG66Bk3UXGWt2QAsNYu BAq2o2abmUfwtex5DpERXsfWUwVUkz7XTtB9gl4Wto0PbONCZE8moAPrcVbRjLn2PeqW vN4622QDjo8ZHb75jeleHgUEMa3kUK8NlqXNVNU5Y+72oineE5EtPCkM9ir0qeJX0EGB wotDS8MCU7VsmXBEeEPqqu0D7fVxRfe1dbEhG2fnCMk7gitLq1T4PRMO7hlQbKRcw6Kg ALnBLH9HOBrXyWL9U3LmnYIS7uc1J4HMDMsxSibl+HP7UVSGaJ5WVK938M9aPg9/CPNb tkTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Z1YJNgcsdqTik2xxRi9BrgcxpgcKVUnuwKjJsZCetf4=; b=KEWrk3NCziOPta9CPF8niiEPZ/x+Jq7PIpnNMgBa5hHw3FgoA18wXiumK4D4QS63r0 ziWQnR5abjpIpq8tKAa3ky1SNYrzeh7RFH8I6Xd9Rptd0U+jwsV/MbJQvZJwzF1w5ALK dMJncK/Ef0+/Si6uKA5g40eXOBAkJg67g1sHL/Mgt0ErKmThQ4IFShY2Sgiwe6ZxoTrC 8oq3Q48dfVT3O1YZZcu3jm0YSMqXNgyk6UaaO2DsEQA9q0pvt6geJvGtRRZ55IF8v1Bb /kXQaZP+DE2nIb6Ydkisi3roU/FxHybjgpVvStlg+nT51oYDMgnRNveT+AnpTpDvDSq8 4ucQ== X-Gm-Message-State: AHQUAuaWW2MCTIZjjCwCquMrE/vMaksTeGQo3yxkM0bBNIqeHtLvjlIS sL3b5e8oW3XIi5TpyReasNkyelCB8VBcQKHVbzc= X-Google-Smtp-Source: AHgI3IbDxyVHRw9C5GRWeuanUMI8f5BtK+Km9xk+OLvcrX603Gs/xxuqhIKdVzeNaEpWt0GI8JP1SkuOEUhErusb0FU= X-Received: by 2002:a37:a247:: with SMTP id l68mr3018099qke.96.1550155856497; Thu, 14 Feb 2019 06:50:56 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::72a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233318 Archived-At: On Thu, Feb 14, 2019 at 2:47 PM Robert Pluim wrote: > > To be clear, I agree this isn't the best docstring in the world. Is it > > better than what was before, which was nothing? Perhaps that's > > arguable and I shouldn't have added it in the first place, forcing > > err inviting people like me to go read the source code. Doing > > a good docstring is hard and I usually reserve those efforts for > > user-visible functions. You could have very well asked me > > what exactly a "PCM-style substring pattern" is, since that's > > just as loosely defined as everything else around those > > parts. > > Doing good docstrings is hard, which is why there will always be > comments on them. Such comments are exactly that: comments, not > criticism. I apologize for that paragraph which reads harsher than it means. I was also trying to get your opinion on what is better: writing a subpar docstring for an internal function, or keeping it undocumented. Jo=C3=A3o