From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries Date: Wed, 31 Jan 2024 10:28:31 +0000 Message-ID: References: <170643232559.30479.16631610453249222615@vcs2.savannah.gnu.org> <20240128085846.187A2C1DAE4@vcs2.savannah.gnu.org> <540cc339-b7d4-4c1a-b084-c7f739ad4947@gutov.dev> <8734ue327d.fsf@gmail.com> <87a5omf1e8.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10979"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 31 11:30:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rV7rD-0002jd-PO for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Jan 2024 11:30:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rV7pt-00037W-6P; Wed, 31 Jan 2024 05:28:53 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rV7pr-00037M-1O for emacs-devel@gnu.org; Wed, 31 Jan 2024 05:28:51 -0500 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rV7pm-00058B-0d for emacs-devel@gnu.org; Wed, 31 Jan 2024 05:28:50 -0500 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-51025cafb51so7287182e87.2 for ; Wed, 31 Jan 2024 02:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706696924; x=1707301724; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WNjfvKNY8xcclcjwVBoygXifnshsNC4gJsnZBGfRutk=; b=Dq9bIS1mUb+fDL4qLnTgvhJkvSOHH6Luci3A6TzQAybSU89hZHrC9BhbTXo76RSDDm FHd4w0mojNZDyDjenF8iyosGfu58l4zxjt3RF+ALjGedCccTzuTtZb3gCSM09MTo8IDp CMosSDUXwrsYhg8FLP+bGH6K07sKBse0JxmP/CjKpy6yKmhMQHNAQeBqkXTtLAXtzi69 vzhPRO0PjUCbh3mSntOI/wNuGIon2nNQeKr9ISpjk3XT7bFM3Y/MJttfm6rxyZDxpDP1 rJXKYywZiSy3C0QjrYikB0FlKxpEGmvDOwlJH7RT2nlJGSu3bjg7I14RL0WSpzpRBS30 OY9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706696924; x=1707301724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WNjfvKNY8xcclcjwVBoygXifnshsNC4gJsnZBGfRutk=; b=nXL8IL/pRh6ZobdFmHC5HCuudl0daWbPdzX8TazzF+sW3lhgf5xoeSGYvTRXfqk+p/ x5qtwX+yo/KlXYAoOVdU2zjEYKHc458XkS9C0agmGLNxeJwLyP73ehxC9Ey/1tgbffSO Ydy/ZkUI2PqeF4iQ1O4nvdjYi5kcmvxGLZtYJ5QMzbrfhgsbAsdysQgwTiopuRYOrc+h rs7sZ0+N345Z4uF2loDdoa4TpJxkGPmOwUi8lT5Jkki7IatT7ccGZATBUZXV6shisEvJ nz9Mdlbx0u9CgD4RNzHq7Om05njNbsxF+hut9KRdOnJUJbpgP6zKiT2UE+ZmkHHKaBrY EgtQ== X-Gm-Message-State: AOJu0YwYlYNAMQ9K0iMWUCujSYZnjsbSuGPnz3LyMpoWWkDlWY5RugUE ok0N7PbYS4FM/cBCjrEPEt2CEhZ4AGvexOzEYVJvCbzwgj9zg9q3+6I8gMsVC1W1W26MPe/CvoJ 2Tj43D69vxkeLb3Y8UfCmjdi0e6E= X-Google-Smtp-Source: AGHT+IGn3ra1NgqH8lWQxzgG5UWOYrIDMqrg/uSI0/Yq17lqUp7l3JJJuoURqOiMB61FSPgu5zn2z01c5RUgax5LoQo= X-Received: by 2002:ac2:5969:0:b0:511:15ff:5628 with SMTP id h9-20020ac25969000000b0051115ff5628mr841349lfp.22.1706696923767; Wed, 31 Jan 2024 02:28:43 -0800 (PST) In-Reply-To: <87a5omf1e8.fsf@yahoo.com> Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=joaotavora@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315660 Archived-At: On Wed, Jan 31, 2024 at 6:44=E2=80=AFAM Po Lu wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > Seems like this much simpler patch would have done the job. If cl-loop > > is so toxic, even macroexpanding these trivial ones away yields much > > less code and much simpler code. Tests are a welcome addition though. > > I did not understand the code using cl-loop, Neither did I. Not because of cl-loop, of course, but because of the new problem domain. But a few runs of edebug quickly clarified, even before finding all those nice tests. I think you're too obsessed with cl-loop. pp-macroexpand-last-sexp would have also have told you how trivial the loops were. You could still have rewritten things with plain 'while' and still have it be significantly shorter. > and there are no comments in this version of the change. Concise code not spanning multiple screenfuls doesn't need all those profuse comments either. A little commenting is fine (maybe a comment explaining the sum of lengths) but the multiple screenfuls and the level of verbosity you picked here makes a relatively easy problem domain seem esoteric and super-complex, when in reality it isn't. In my experience, once a function reaches this hairiness, it rarely contracts. All you'll see if more if-branches appear at the leaves. > For that matter, if there _were_ > comments in the original version, I could have understood its intent, > but cryptic cl-lib and pcase labyrinths are all the rage these days. loop isn't fashion, it's probably older than you are, and not the beast you make of it, especially these trivial cases. I'm pretty sure you'd be able to grok it in less than 5 minutes. The pcase you substituted was even more trivial (really, "labyrith"?? how extreme can you get?) Personally I wouldn't have added it, but of course I wouldn't have removed it for no reason. It's a hard sell that so much of this doesn't spring from the ridiculous polarized trenches people have been digging themselves into in this list. This seems to me the saddest part. Honestly, Po, at the end of the day, we should all be happy you're fixing bugs and adding unit tests. You've got exceptional energy or exceptional free time, or both. I think freedoms should be given liberally to people doing this work, including of course "rewriting the whole damn thing" (tm). And of course you should have your own pick of the programming style. Personally, I just wish you'd appreciate that high-level languages aren't the bogey man. That others might be put off by long listings (maybe even future you, who knows?). That rewrites spawn bugs, too (as your multiple subsequent commits show). That sometimes this: - (beg (progn (goto-char beg) (line-beginning-position)))) + (beg (progn (goto-char beg) (skip-chars-backward "^ \n") (point)))) could be preferable to going medieval on a function's ass > Anyway, please don't modify log-edit just yet--I plan to modify it to > handle conditional changes and part indicators. I won't, of course. I'll leave it to you. Also I'll be leaving emacs development soon, so you'll be able to butcher Eglot's cl-loops and pcases and macros into whatever you see fit, just try not to go too medieval on its ass. Jo=C3=A3o