From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 54488@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#54488: 29.0.50; move-to-column/overlay-related regression in latest master, perhaps 28?
Date: Tue, 22 Mar 2022 16:06:48 +0000 [thread overview]
Message-ID: <CALDnm51k6zCprAvVDdF49Jmp7X7sSuNaD_Qiv9_Yc=+Sb_nKwg@mail.gmail.com> (raw)
In-Reply-To: <83zglidnbs.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1883 bytes --]
On Tue, Mar 22, 2022 at 3:22 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: João Távora <joaotavora@gmail.com>
> > Cc: dgutov@yandex.ru, 54488@debbugs.gnu.org
> > Date: Tue, 22 Mar 2022 14:54:13 +0000
> >
> > In Emacs 29, before the fix, that (point) seems to -- very surprisingly
> > -- return something beyond the narrowed region and so
> > encode-coding-string will complain with args out of range.
>
> I don't understand how (point) can return a value outside of the
> narrowed region, unless it runs with the narrowing temporarily
> disabled. Can you show me the code with that call to 'point' again?
> I don't think I see it in your OP.
>
It's the snippet below. but the indentation probably botched it.
I inlined a function in that snippet so you can see the move-to-column
and the (point) in the same function (normally they live in different
functions).
> (defun eglot-move-to-lsp-abiding-column (column)
> > "Move to COLUMN abiding by the LSP spec."
> > (save-restriction
> > (cl-loop
> > with lbp = (line-beginning-position)
> > initially
> > (narrow-to-region lbp (line-end-position))
> > (move-to-column column)
> > for diff = (- column
> > (/ (- (length (encode-coding-region (or lbp
> (line-beginning-position))
> > (point) 'utf-16 t)) ;; <=====
> THAT (point)
> > 2)
> > 2))
> > until (zerop diff)
> > do (condition-case eob-err
> > (forward-char (/ (if (> diff 0) (1+ diff) (1- diff)) 2))
> > (end-of-buffer (cl-return eob-err))))))
>
> Why do you have to use move-to-column instead of forward-char?
>
I don't remember! Is it exactly equivalent if you're standing in the
beginning of the line?
João
--
João Távora
[-- Attachment #2: Type: text/html, Size: 2907 bytes --]
next prev parent reply other threads:[~2022-03-22 16:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 6:54 bug#54488: 29.0.50; move-to-column/overlay-related regression in latest master, perhaps 28? João Távora
2022-03-21 12:32 ` Eli Zaretskii
2022-03-21 16:37 ` João Távora
2022-03-21 17:05 ` Eli Zaretskii
2022-03-21 21:59 ` João Távora
2022-03-21 23:14 ` Dmitry Gutov
2022-03-22 9:48 ` João Távora
2022-03-22 12:16 ` Eli Zaretskii
2022-03-22 13:57 ` Eli Zaretskii
2022-03-22 14:31 ` Eli Zaretskii
2022-03-22 14:54 ` João Távora
2022-03-22 15:22 ` Eli Zaretskii
2022-03-22 16:06 ` João Távora [this message]
2022-03-22 16:53 ` Eli Zaretskii
2022-03-22 21:05 ` João Távora
2022-03-22 23:55 ` Dmitry Gutov
2022-03-23 1:11 ` João Távora
2022-03-23 3:39 ` Eli Zaretskii
2022-03-23 10:10 ` João Távora
2022-03-23 11:08 ` João Távora
2022-03-23 14:21 ` Eli Zaretskii
2022-03-24 15:01 ` João Távora
2022-03-24 15:29 ` Eli Zaretskii
2022-03-24 16:03 ` João Távora
2022-03-24 16:59 ` Eli Zaretskii
2022-03-23 3:34 ` Eli Zaretskii
2022-03-23 3:29 ` Eli Zaretskii
2022-03-23 10:04 ` João Távora
2022-03-23 13:23 ` Eli Zaretskii
2022-03-24 14:54 ` João Távora
2022-03-22 12:33 ` Dmitry Gutov
2022-03-22 13:50 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm51k6zCprAvVDdF49Jmp7X7sSuNaD_Qiv9_Yc=+Sb_nKwg@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=54488@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.