From: "João Távora" <joaotavora@gmail.com>
To: 24901@debbugs.gnu.org
Subject: bug#24901: Fwd: Caught mistake in elec-pair.el patch
Date: Sun, 13 Aug 2017 12:03:01 +0100 [thread overview]
Message-ID: <CALDnm51jqGhjeAsYZOuFaw65BuJqfTSx-nuoKsQ7cpOS_aX=XQ@mail.gmail.com> (raw)
In-Reply-To: <CALDnm513tFORnxwH7a_hn7Birk-s7z44ftxO2uitMM7Rb2dQKA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]
After unarchiving this bug just to add this commnet.
---------- Forwarded message ----------
From: João Távora <joaotavora@gmail.com>
Date: Sun, Aug 13, 2017 at 11:57 AM
Subject: Caught mistake in elec-pair.el patch
To: 24901@debbugs.gnu.org, rrt@sc3d.org, Eli Zaretskii <eliz@gnu.org>
Hi Reuben,
Casually glancing at the source for lisp/elec-pair.el I have found an
error.
You cannot use lists like (nth 0 electric-quote-chars) inside a quoted list
as
you did in your patch of Nov. 8 2016. The list will not be evaluated.
Perhaps
you were distracted by the grim events taking place that day :-)
Anyway, I think you meant backquote-and-comma so I'll install this fix soon,
unless anyone objects.
João
diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el
index 87e82e2..4ede4f1 100644
--- a/lisp/elec-pair.el
+++ b/lisp/elec-pair.el
@@ -28,9 +28,9 @@
;;; Electric pairing.
(defcustom electric-pair-pairs
- '((?\" . ?\")
- ((nth 0 electric-quote-chars) . (nth 1 electric-quote-chars))
- ((nth 2 electric-quote-chars) . (nth 3 electric-quote-chars)))
+ `((?\" . ?\")
+ (,(nth 0 electric-quote-chars) . ,(nth 1 electric-quote-chars))
+ (,(nth 2 electric-quote-chars) . ,(nth 3 electric-quote-chars)))
"Alist of pairs that should be used regardless of major mode.
Pairs of delimiters in this list are a fallback in case they have
@@ -44,9 +44,9 @@ electric-pair-pairs
;;;###autoload
(defcustom electric-pair-text-pairs
- '((?\" . ?\" )
- ((nth 0 electric-quote-chars) . (nth 1 electric-quote-chars))
- ((nth 2 electric-quote-chars) . (nth 3 electric-quote-chars)))
+ `((?\" . ?\" )
+ (,(nth 0 electric-quote-chars) . ,(nth 1 electric-quote-chars))
+ (,(nth 2 electric-quote-chars) . ,(nth 3 electric-quote-chars)))
"Alist of pairs that should always be used in comments and strings.
Pairs of delimiters in this list are a fallback in case they have
--
João Távora
[-- Attachment #2: Type: text/html, Size: 3038 bytes --]
next parent reply other threads:[~2017-08-13 11:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALDnm513tFORnxwH7a_hn7Birk-s7z44ftxO2uitMM7Rb2dQKA@mail.gmail.com>
2017-08-13 11:03 ` João Távora [this message]
[not found] ` <CAOnWdojZmNrAN1ioAPk_YTik0LU-qz26SrA3pmocJznuB-Bd4A@mail.gmail.com>
2017-08-17 10:32 ` bug#24901: Caught mistake in elec-pair.el patch João Távora
2017-08-17 12:35 ` npostavs
2017-08-17 13:32 ` João Távora
2017-08-17 14:05 ` Noam Postavsky
2017-08-17 14:23 ` Eli Zaretskii
2017-08-17 15:36 ` João Távora
2017-08-17 15:49 ` Noam Postavsky
2017-08-17 16:57 ` João Távora
2017-08-18 1:51 ` npostavs
2017-08-18 19:21 ` Reuben Thomas
2017-08-18 22:46 ` João Távora
2017-08-19 0:41 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm51jqGhjeAsYZOuFaw65BuJqfTSx-nuoKsQ7cpOS_aX=XQ@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=24901@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.