From: "João Távora" <joaotavora@gmail.com>
To: Simon Pugnet <simon@polaris64.net>
Cc: 67150@debbugs.gnu.org, contact@sivalik.com
Subject: bug#67150: eglot with typescript language server >= 4.1.0
Date: Wed, 15 Nov 2023 10:18:56 +0000 [thread overview]
Message-ID: <CALDnm51jhk9FrNu70ADwhRBwdO9cR7a=Bh22AJd5JW9Vfz1XoQ@mail.gmail.com> (raw)
In-Reply-To: <87o7fvfip4.fsf@polaris64.net>
On Wed, Nov 15, 2023 at 9:51 AM Simon Pugnet <simon@polaris64.net> wrote:
>
> > Thanks. In the meantime I asked the server author some questions and
> > it seems the change has been rolled back, with the server accepting
> > the old language-ids again. But I've pushed the change to eglot.el
> > anyway. I think this bug can be closed, but let me know if you
> > disagree.
>
> I'm not sure if this fix is correct. In the documentation for
> `eglot-server-programs' it says: -
>
> * A list (MAJOR-MODE-SYMBOL :LANGUAGE-ID ID) where
> MAJOR-MODE-SYMBOL is the aforementioned symbol and ID is a
> string identifying the language to the server;
>
> However the commit 260ba357bbe3e6faaadb20d998107c11fab40aa5 sets the
> `:language-id' to symbols. So I think these should be strings instead,
> e.g. "javascript".
Yup, that was a mistake, guess I should have tested, but I don't
have this language server. Keywords would probably work too,
but I fixed them to strings as you suggest. Pushed to master
and cherry-picked to emacs-29.
João
next prev parent reply other threads:[~2023-11-15 10:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 11:29 bug#67150: eglot with typescript language server >= 4.1.0 Rajeev N via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-13 16:37 ` João Távora
2023-11-13 16:42 ` Rajeev N via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-13 16:49 ` João Távora
2023-11-13 16:57 ` Rajeev N via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-14 0:12 ` João Távora
2023-11-14 12:07 ` Eli Zaretskii
2023-11-14 12:19 ` João Távora
2023-11-14 14:28 ` Eli Zaretskii
2023-11-15 9:51 ` Simon Pugnet
2023-11-15 10:18 ` João Távora [this message]
2023-11-15 10:27 ` Simon Pugnet
2023-11-15 10:29 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm51jhk9FrNu70ADwhRBwdO9cR7a=Bh22AJd5JW9Vfz1XoQ@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=67150@debbugs.gnu.org \
--cc=contact@sivalik.com \
--cc=simon@polaris64.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.