From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#69647: [PATCH 1/2] Delete trailing whitespace when formatting LSP documentation Date: Fri, 8 Mar 2024 20:41:48 +0000 Message-ID: References: <87cys4enc4.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3135"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69647@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 08 21:43:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rih4N-0000hc-BE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Mar 2024 21:43:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rih3y-000115-UC; Fri, 08 Mar 2024 15:43:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rih3y-00010x-2p for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2024 15:43:30 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rih3x-0006ii-R8 for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2024 15:43:29 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rih4T-0003ey-Qf for bug-gnu-emacs@gnu.org; Fri, 08 Mar 2024 15:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Mar 2024 20:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69647-submit@debbugs.gnu.org id=B69647.170993062113990 (code B ref 69647); Fri, 08 Mar 2024 20:44:01 +0000 Original-Received: (at 69647) by debbugs.gnu.org; 8 Mar 2024 20:43:41 +0000 Original-Received: from localhost ([127.0.0.1]:59728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rih49-0003da-Fe for submit@debbugs.gnu.org; Fri, 08 Mar 2024 15:43:41 -0500 Original-Received: from mail-lf1-f54.google.com ([209.85.167.54]:58516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rih46-0003d3-Ox for 69647@debbugs.gnu.org; Fri, 08 Mar 2024 15:43:39 -0500 Original-Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-512bde3d197so2416518e87.0 for <69647@debbugs.gnu.org>; Fri, 08 Mar 2024 12:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709930520; x=1710535320; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GUCxPE8aEp/ZwniyATDHfL0FutBeMBuvCGRySUwsgGk=; b=ZRiIIuTK7biIMfRA829sGPjzp07wwYJvlkrzc7vjLZ1vwn07WnFIBUcl8ZegdIrM3f 39N2pkcBU6ehcZqL2eKXcMlQRKUf8PD89lqgYm5Op/uWpo1q06AgBU0JTTa3xD4SwRlZ b1WIxMCKVryPN7sB8kTHSFE901KRrdtF1r8cDY9FkMtx/cBVIXerKDq5YDfGZ0s0eadu tM1P39t40jEr78UW5wTq+xs6OiTSKsQ7fZSHTEcegmEMbmwjIzVvcA52dsF5P8H86AHf KbhCl3CsxHkXQDYdexfZ5sMQGPiZuD6TWHRiDkj/hFooMkgu1L3zUDL4vwC0w+oEDEJV SItQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709930520; x=1710535320; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GUCxPE8aEp/ZwniyATDHfL0FutBeMBuvCGRySUwsgGk=; b=hQTjAvkqaZLZyUek/RcRYX+foJ1Yo7uDGat3aMiwCaBUIlQmVTS2v6RjiAcphGKhjz 2gPMFMwWbrKQQvQbcw39tcD/ii4CnIPSnZRMfV/HyDHP9EUAfVWFEC84wqgEW1j2oo2X W06jaUIMjfQnLsMG0eNRU43y535U7KPtyyfpjVAs1mW6VeYZQgH4RyBA6Ft8h6usAoXw eM7DqwZJU+mNYQ5AuxgbacQShXfustcIDc+5FEctW+9hGvd8sZ9B/LCIF2laV7v/fO5y DU07nW4j/i+OvKPvTe8riASaCOi86t0M2YLMUrj+N+S8wyoPzEPtiBb+Hsr/kG5jqcAL j/dA== X-Gm-Message-State: AOJu0YxXcTJ+YrWiY2+BO3hg6lz32IzUHFYVLhbuQ+HqZ6vnswibwy2g 7om4gPM/yV6m6UaaQVxyaKXLLjryyb56VQVmrlL8RBdI1/LvquCupw2SMfI3/qWGK2OTMItmk2A /EASbIj2ehwQI6/ED59xInIVO7CE= X-Google-Smtp-Source: AGHT+IEgIML0LRiXfI0BholHHrvVADOxykd9YVg28tQ91y6HPMTezycZg7BY4+cnpuwOYivtsh0RkTra+Y+t3ktS1wM= X-Received: by 2002:a19:f50f:0:b0:513:ef4:295d with SMTP id j15-20020a19f50f000000b005130ef4295dmr104575lfb.22.1709930520081; Fri, 08 Mar 2024 12:42:00 -0800 (PST) In-Reply-To: <87cys4enc4.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281270 Archived-At: On Fri, Mar 8, 2024 at 3:49=E2=80=AFPM Philip Kaludercic wrote: > > Tags: patch > > LSP servers like clangd generate trailing whitespace, that when rendered > as markdown causes parts of the buffer to be underlined. Unless there > is a reason for this, I'd suggest helping out by deleting trailing > whitespace before continuing to process the documentation. Go ahead and push. But be warned I've been bitten by bugs when doing what I thought were innocent changes to this function, so keep an eye out. Ideally though the formatting (including these fixups) should be done entirely by entities other than Eglot. I think markdown.el has something for that trai= ling whitespace. Anyway I don't have time for that, so go ahead and push. Jo=C3=A3o