From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Date: Sun, 11 Sep 2022 17:38:09 +0100 Message-ID: References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> <87bkrlq3ar.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000044534605e8696837" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12560"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Basil L. Contovounesios" , 57725@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 11 18:39:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oXPzC-00034i-SD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Sep 2022 18:39:10 +0200 Original-Received: from localhost ([::1]:55506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXPzB-0000ZF-Pb for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Sep 2022 12:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXPz3-0000Yp-Vz for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 12:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXPz3-0005lH-No for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 12:39:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXPz3-00058R-Im for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 12:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 16:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs Original-Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166291430919701 (code B ref 57725); Sun, 11 Sep 2022 16:39:01 +0000 Original-Received: (at 57725) by debbugs.gnu.org; 11 Sep 2022 16:38:29 +0000 Original-Received: from localhost ([127.0.0.1]:43288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPyX-00057h-0W for submit@debbugs.gnu.org; Sun, 11 Sep 2022 12:38:29 -0400 Original-Received: from mail-io1-f50.google.com ([209.85.166.50]:46077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPyV-00057U-L9 for 57725@debbugs.gnu.org; Sun, 11 Sep 2022 12:38:28 -0400 Original-Received: by mail-io1-f50.google.com with SMTP id v128so5229240ioe.12 for <57725@debbugs.gnu.org>; Sun, 11 Sep 2022 09:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=XwgCKZelKZblzlPYiEl7SjJd7ryme+yN+BFID8sVgVE=; b=O6Sht9qjlZzfqQBBTcdSRR/W8GM/o7faNn8hpGyCa6uyOMGfBM3Z3ciUhTffyC+b79 FBNjarMWwMZukaqPWT8Q7w0K6KCl4jWIlzAeaHaARxFya+WefxiowegU3OoCOnCA+NX2 P4dGk34J8sqTnWNoROH7u+RjR40L0Q7A/vYEnImkbZilKGgaTApjqqFZ51++ExXh9PFu kl9r1IoizKSJPpVaPB+Xy05f5GTnmp0q5WrG7XRkQ0jAzdDOfelpQvAKQj7ifuJvcMX9 2gacuM5X8vA11l2bwBxpy2WN61DfjNCeSqKQbzC5rmIBAa5JylX9orPWJC7Dkc/CASvL WrDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=XwgCKZelKZblzlPYiEl7SjJd7ryme+yN+BFID8sVgVE=; b=RWOfTx/X9WRywZKxPDW0Ey2qAho6IGaQgXBlXKEx5WihUoTn8dS/OWWV4203Wd+L3d qa1EkyfAP+g/eWq1FV2NfdJtT/2fo0xbANnzBECVimcbQ8WJgnKsHWaZkRIFdio9xxwK mrlD2qLdsyU3uZj2jijSWZdO8GWDHcWOfhGmCrqPQoaSmmlij3jJVQu/le50HC8GBsR0 RaCGfFL8xM0faENDeSPjmYeposWt0yXKXpoAhIEVsZyrm08FfR0fhcdgC+uUne316eqT IluUIAImkLmaz/MGIbyMeaf4eV3UwT4pQUvUpsQbZ6qF+iasq8I5GFMjk/EChE/ix5WV 2y6w== X-Gm-Message-State: ACgBeo3/JDdjaCKNV9/wAf800OyY42yHPlDFETssYIvsexKz1BOvzHXj dOe70I4WZXlYbxdMRIA9VFMXZrJX7tsg0ez2xTA= X-Google-Smtp-Source: AA6agR7UPqJTtXjzvrq6hqI1rNSC98vD6SknYR6hxHtzMNskrIz4rbd07t2JwaeplEl61me9Tre2kHq40YcatailXsc= X-Received: by 2002:a05:6638:3f1a:b0:35a:3ae2:5906 with SMTP id ck26-20020a0566383f1a00b0035a3ae25906mr608959jab.181.1662914302069; Sun, 11 Sep 2022 09:38:22 -0700 (PDT) In-Reply-To: <87bkrlq3ar.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242188 Archived-At: --00000000000044534605e8696837 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, makes sense, but there is another piece of initialization -- good ol command line params -- that are also treated the way i described (i'm almost sure, but better confirm). So it's good to be consistent. If this kind of refreshing from user options is needed for debug purposes, the user can simply shutdown and restart instead of eglot-reconnect. At least this is what I figured at the time. On Sun, Sep 11, 2022, 17:33 Augusto Stoffel wrote: > On Sun, 11 Sep 2022 at 17:27, Jo=C3=A3o T=C3=A1vora wrote: > > > Can you suggest an alternative patch so that that second effect also > happens? > > > > Jo=C3=A3o > > > > On Sun, Sep 11, 2022, 17:26 Augusto Stoffel wrote= : > > > > On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora wrote: > > > > I almost agree with this fix as is, but maybe we should name the slot. > What > > happens if my the connection is restarted, shouldn't the previous > > initializationOptions be reused? > > > > Most certainly. > > Actually, I'm not so sure what the best behavior is. I think reusing > the original :initializationOptions is consistent with other behavior in > Eglot (is it?), but there's also merit in recomputing/using the current > user settings =E2=80=94 for instance, if you need to debug the > :initializationOptions. > --00000000000044534605e8696837 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, makes sense, but there is another = piece of initialization -- good ol command line params -- that are also tre= ated the way i described (i'm almost sure, but better confirm).

So it's good to be consistent. If= this kind of refreshing from user options is needed for debug purposes, th= e user can simply shutdown and restart instead of eglot-reconnect. At least= this is what I figured at the time.

On Sun, Sep 11, 2022, 17:33 Augus= to Stoffel <arst= offel@gmail.com> wrote:
On S= un, 11 Sep 2022 at 17:27, Jo=C3=A3o T=C3=A1vora wrote:

> Can you suggest an alternative patch so that that second effect also h= appens?
>
> Jo=C3=A3o
>
> On Sun, Sep 11, 2022, 17:26 Augusto Stoffel <arstoffel@gmail.com> wr= ote:
>
>=C2=A0 On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.= com> wrote:
>
>=C2=A0 I almost agree with this fix as is, but maybe we should name the= slot. What
>=C2=A0 happens if my the connection is restarted, shouldn't the pre= vious
>=C2=A0 initializationOptions be reused?
>
>=C2=A0 Most certainly.

Actually, I'm not so sure what the best behavior is.=C2=A0 I think reus= ing
the original :initializationOptions is consistent with other behavior in Eglot (is it?), but there's also merit in recomputing/using the current=
user settings =E2=80=94 for instance, if you need to debug the
:initializationOptions.
--00000000000044534605e8696837--