From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name Date: Thu, 24 Nov 2022 14:43:57 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000fd372605ee386f44" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38045"; mail-complaints-to="usenet@ciao.gmane.io" To: Stephen Leake , emacs-devel , Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 24 15:44:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyDTD-0009bj-HP for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Nov 2022 15:44:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyDSh-0004hd-D0; Thu, 24 Nov 2022 09:44:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyDSU-0004fg-Ut for emacs-devel@gnu.org; Thu, 24 Nov 2022 09:44:12 -0500 Original-Received: from mail-oa1-x33.google.com ([2001:4860:4864:20::33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyDST-0003th-CZ for emacs-devel@gnu.org; Thu, 24 Nov 2022 09:44:10 -0500 Original-Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-141ca09c2fbso2175865fac.6 for ; Thu, 24 Nov 2022 06:44:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=FL09neNck+nPhQWmCFhAbFATmcO8rFj6DWycF08lz80=; b=ogg62kt7LxqRPxprGAL4CmLpjlsHxVc3zrLxkd0VV0oyJh3bKJfl8T5xCS4IeZkLOY toQqqNJtvhaErdyw1LWVEtwMPjaFqDDcgdgY3Vhmes1TSp3bua07rrH/TpF9f1jgMvUA QPZb8tUAqPd1c31NixYAoDoKcobLbU0OMdAlFHWWmnGhYprn5rvwGcU9/BToeNz3kl+H aisqtzouKTR391+brq/pLfAD/ZCfrrkzHSm6g2fFhLlc1oTIqhCFbfACoDVLNDQcaKfe eOQTb9YQOh6lTLR+Lkx2hTeI8D+iEjiX/A0kWs59MD1Zq6laI6LfL56oSb2XTep7byHm 9cRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FL09neNck+nPhQWmCFhAbFATmcO8rFj6DWycF08lz80=; b=WtH4TN+96VbwMYQj4qWo4M6+RIwXXl3mdSDSafhT87/PtusJJZViN5USIx+xVDr64i GhELw7CcNKM5Yfai9g8iFLj8sECcsspTixg3oxuDy30kc6ZsIjiJ7nUHKeagX/uJ//SO tqMAnDx2+yCaa9PTUGrf7SGa9CDWVRv70UzsewZc/97/0jelHg9bVGOyoZzzY0ktHHwm pfOerAh+4DyGXboSwgYx/eam0W8u0BdOq1LGOlFrkb3oAaiRbIPmTvdL+CpQCxsosMRa +UJ3TLJGAVG6NOTOziDtT6bfGGWRPHCM9ta4ACT7sLaI23qCaQAY3XQUsULFXCce8LFy gdfQ== X-Gm-Message-State: ANoB5pkvX77Jm0VQRIMj8zAO2TgeJzmhcZsD9FO8iB/YDFUrN7FvQJWE +ClnPVseVj4Q5gjafZ6qvggcCnmadA5WXKqASxM= X-Google-Smtp-Source: AA0mqf6KKvGEu/YaQa2tLApLxTg96z/pioiaXiMeXJ2yFb0M7zDse0e7iukkJ6Kg3fVyJwwCEdXUn7z2ApekEYbyFFU= X-Received: by 2002:a05:6871:4590:b0:132:a103:ae22 with SMTP id nl16-20020a056871459000b00132a103ae22mr18895129oab.215.1669301047996; Thu, 24 Nov 2022 06:44:07 -0800 (PST) Received-SPF: pass client-ip=2001:4860:4864:20::33; envelope-from=joaotavora@gmail.com; helo=mail-oa1-x33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300438 Archived-At: --000000000000fd372605ee386f44 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Stephen, In this commit: commit 1f39da3098a2a4cec9985e6db934ed14b7b522b7 Author: Stephen Leake Date: Tue Nov 22 11:43:22 2022 -0800 * lisp/progmodes/eglot.el (eglot--connect): Use project-name As discussed in bug#48747. You use an fboundp check for the project-name function recently added to project.el. This is not necessary in eglot.el, since it already depends on the project.el :core ELPA package. eglot.el is itself such a package. So you must merely bump the "Version:" of the project.el package in that file and then make eglot.el reference the new version in its "Package-Requires:". Of course you should/could ask permission before bumping project.el's version (or not, depends on Dmitry's policy) This way we can avoid those pesky checks. I'll change the commit to use package-name directly now. Jo=C3=A3o PS: When about to apply a patch to eglot.el, even one where I have already approved the underlying idea, I would appreciate it if you could just shoot me a personal mail showing the full contents of the patch. --000000000000fd372605ee386f44 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Stephen,

In this commit:

commit 1f39da3098a2a4cec9985e6db934ed14b7b522b7
Au= thor: Stephen Leake <s= tephen_leake@stephe-leake.org>
Date: =C2=A0 Tue Nov 22 11:43:22 2= 022 -0800

=C2=A0 =C2=A0 * lisp/progmodes/eglot.el (eglot--connect): = Use project-name
=C2=A0 =C2=A0
=C2=A0 =C2=A0 As discussed in bug#487= 47.

You use an fboundp check for the project-n= ame function recently
added to project.el.

This is not necessary in eglot.el, since it already depends on the
=
project.el :core ELPA package.=C2=A0 eglot.el is itself such a package= .
So you must merely bump the "Version:" of the project= .el package in=C2=A0
that file and then make eglot.el reference t= he new version in its
"Package-Requires:".=C2=A0=C2=A0<= /div>

Of course you should/could ask permission before b= umping=C2=A0
project.el's version (or not, depends on Dmitry&= #39;s policy)=C2=A0

This way we can avoid those pe= sky checks. I'll change the commit
to use package-name direct= ly now.

Jo=C3=A3o

PS:= When about to apply a patch to eglot.el, even one where I
have a= lready approved the underlying idea, I would appreciate
it if you= could just shoot me a personal mail showing the full=C2=A0
conte= nts of the patch.
--000000000000fd372605ee386f44--