From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#73472: [PATCH] Substitute quotation marks in Eglot messages Date: Sat, 28 Dec 2024 15:52:04 +0000 Message-ID: References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> <861pxsul6k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003d1d8c062a56909c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11095"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thomas Voss , 73472@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 28 16:54:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRZ8u-0002k1-MQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Dec 2024 16:54:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRZ8e-0006jk-Km; Sat, 28 Dec 2024 10:54:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRZ8d-0006jY-3f for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 10:54:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRZ8c-0006Nw-RW for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 10:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=HiJWVOy+VbC0Eh2EeBmMwfvKNuuGmbdT5Tno0dfKdfc=; b=I72N0qS8GSuKP0FVL5o+wY+FPeA57yBSCA3++gcTkeM9I2sbnjyr2VpgzzvrF9COG5o1g2CamnjkT7isR+cLKPYLrSTT4AJaSt9ICxGrJ1nrg0t4I4JHoOpsbFxOWTcnMnhuE+s0tl7NxeDEqTdkgZFzidh/CEJFiQtv4cLC9ufml3Uu/JY/aJwq1IcJNn1s0dfgErK9Te098n7qSHbhJdGfPTmMVuaNQkt+ZXubdnL4XiOvYDbjbThQHpxTF9jB2D84ek317Z6gEqn8lBbEnEfS5fuefee3/yixd1Jy+4tUyLmsJcGCzCFO5foeH98gN9N4MI/WS8yBRAJZEsTHdQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRZ8c-0003rb-DG for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 10:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Dec 2024 15:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73472-submit@debbugs.gnu.org id=B73472.173540120414807 (code B ref 73472); Sat, 28 Dec 2024 15:54:02 +0000 Original-Received: (at 73472) by debbugs.gnu.org; 28 Dec 2024 15:53:24 +0000 Original-Received: from localhost ([127.0.0.1]:52364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRZ7z-0003ql-J8 for submit@debbugs.gnu.org; Sat, 28 Dec 2024 10:53:24 -0500 Original-Received: from mail-oa1-f53.google.com ([209.85.160.53]:60919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRZ7x-0003qX-GC for 73472@debbugs.gnu.org; Sat, 28 Dec 2024 10:53:22 -0500 Original-Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-2a3d8857a2bso3856331fac.1 for <73472@debbugs.gnu.org>; Sat, 28 Dec 2024 07:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735401136; x=1736005936; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HiJWVOy+VbC0Eh2EeBmMwfvKNuuGmbdT5Tno0dfKdfc=; b=W07cHj6lZ8+uazhH5QMH61vPXA+cUBUxrP4QShbhvuPrbiLsW3pY/sbzRhufiploM3 A5rTyqAjVilK8tlKmqUgVKLKaGdeLv/0O4vIg0rECg7Qjqdiurt2Ajv1K6jNS7bd4ZaP K3iiQ8kfFDcnjdn8Hg8vMYdsjX5m2qDt9OMy6dVRdsXIWG2lXxI7/XHLTjcnXsioHA8m j67M3480MODMqm0FxELMHG/8U428r+FUB80KH8KjPO3uLTcB+sJkA3LvV4H0Jh1PBYMI nLBYtiCgaQ04UrY0iCnHKSQoXP/ciYvHAPGHm8tZhoDCfhvfS4sseJ1Uzyrp+nxO5eGC 0fwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735401136; x=1736005936; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HiJWVOy+VbC0Eh2EeBmMwfvKNuuGmbdT5Tno0dfKdfc=; b=o8RQcLPxTXjxmqJk30dDbgXtYiBf89Yk36uX88mHRFo3KQaF6yGeYuXa2DKWTsTjZj +gCSLFAW0H6a7moShIhYBuurlgN/s8D2rKVewY+NnKDZ7L4UFcQrgRQ5hBRB+E2+0Wj8 mjpZb+cvKhqwYiD7bjt7+KunAABiLqKw21maP8XnxQBPXxxG4l/AnJbPEBd8Va8cRJJK zBe3yjqCE0UTNwsEiHVLRtiwlJVAUM/BywRwr6u3Q/TXyGI3ECox/0AfkSBu+hr2Ujwq OfyXp0jLLeLK7tDpxKpeMd/rZ7sEH48lZvYePbj+uBD1rw+RGDqlaUcLON81B7CEadGf md7w== X-Forwarded-Encrypted: i=1; AJvYcCVOXLlPk/jFKlwEJMcPSc0XYtxnpNcM5k3ietyNEIFonG+Y+3ed7NZU0sJWnx8E+NVHC7gEtQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy7a/FAqCXiSUh0liSh4a1c1oGi1qfhWmvWlh/3d6i7bHBXNRnK ANZTbxRx92RPmcN1LEQJhTIPgaPK7e5yYlO8sQOXoO07oJ35se/CsbX1tizJXidmY+fbsv67o+J tiDDX60l+EKgv4Jq3pBNz8fK5Z4c= X-Gm-Gg: ASbGnctSKd4nowCRC346jgiJNlLFiaqA4hefFGtJ2KS4L6UI7D+wBNUcyyzz3HVhRdh ZoYYRD3sAhQvCEUeKsK3OyyNqYKRjD95mSJXr X-Google-Smtp-Source: AGHT+IF9hfh4Whg3LEJCFSJVrl5f77o+QeIpGtrpLPodI1OnwgCzT8ADb4bKaeiD3ElTwCQV1Z/7B51xr9Zy45vzEKY= X-Received: by 2002:a05:6870:3c10:b0:295:ed0a:8061 with SMTP id 586e51a60fabf-2a7fb553bf8mr16223222fac.39.1735401135739; Sat, 28 Dec 2024 07:52:15 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297912 Archived-At: --0000000000003d1d8c062a56909c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, I meant to write "fixed a much more serious one". Jo=C3=A3o On Sat, Dec 28, 2024, 13:29 Jo=C3=A3o T=C3=A1vora wr= ote: > > > On Sat, Dec 28, 2024, 11:00 Eli Zaretskii wrote: > >> > From: Jo=C3=A3o T=C3=A1vora >> > Date: Thu, 12 Dec 2024 10:57:48 +0000 >> > Cc: Thomas Voss , 73472@debbugs.gnu.org >> > >> > On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii = wrote: >> > > >> > > > Date: Mon, 09 Dec 2024 19:01:28 +0100 >> > > > From: "Thomas Voss" >> > > > >> > > > Apologies for the long delay; I have been super busy recently. >> > > > >> > > > > Ping! >> > > > > >> > > > > > Thanks. Jo=C3=A3o, any comments? >> > > > > > >> > > > > > My only comment is that the log message says "format-prompt", >> but the >> > > > > > code actually uses substitute-quotes. >> > > > >> > > > Uh=E2=80=A6 are we looking at the same patch? The log message in = the patch >> I >> > > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for all the= places where I >> used >> > > > that function, and only says =E2=80=98format-prompt=E2=80=99 for t= he place where I >> used >> > > > that function (=E2=80=98eglot-rename=E2=80=99). >> > > > >> > > > Just in case, I attached the patch again to this email. >> > > >> > > Thanks. >> > > >> > > Jo=C3=A3o, are you okay with me installing this? >> > >> > Just had a look. The patch won't break anything, but it has some >> problems >> > around the part where substitute quotes isn't around a literal, but >> wraps >> > a bigger block. I'll try to fix it. It would also be great to have >> some file >> > local symbol-shortening mechanism to avoid that long name, but I'm >> > not going to worry about that. >> >> Ping! Did you have time to look into this? >> > > No sorry. Fixed a much more serious but though. Early 2025 I will fix thi= s > patch, it's easy. > > Jo=C3=A3o > --0000000000003d1d8c062a56909c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Sorry, I meant to write "fixed a much more seri= ous one". Jo=C3=A3o=C2=A0


On Sat, Dec 28, 2024,= 13:29 Jo=C3=A3o T=C3=A1vora <jo= aotavora@gmail.com> wrote:


On Sat, Dec 28, 2024, 11:00 Eli Zare= tskii <eliz@gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>
> Date: Thu, 12 Dec 2024 10:57:48 +0000
> Cc: Thomas Voss <mail@thomasvoss.com>= , 73472@debbugs.gnu.org
>
> On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > > Date: Mon, 09 Dec 2024 19:01:28 +0100
> > > From: "Thomas Voss" <mai= l@thomasvoss.com>
> > >
> > > Apologies for the long delay; I have been super busy recentl= y.
> > >
> > > > Ping!
> > > >
> > > > > Thanks.=C2=A0 Jo=C3=A3o, any comments?
> > > > >
> > > > > My only comment is that the log message says "= ;format-prompt", but the
> > > > > code actually uses substitute-quotes.
> > >
> > > Uh=E2=80=A6 are we looking at the same patch?=C2=A0 The log = message in the patch I
> > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for a= ll the places where I used
> > > that function, and only says =E2=80=98format-prompt=E2=80=99= for the place where I used
> > > that function (=E2=80=98eglot-rename=E2=80=99).
> > >
> > > Just in case, I attached the patch again to this email.
> >
> > Thanks.
> >
> > Jo=C3=A3o, are you okay with me installing this?
>
> Just had a look. The patch won't break anything, but it has some p= roblems
> around the part where substitute quotes isn't around a literal, bu= t wraps
> a bigger block.=C2=A0 I'll try to fix it.=C2=A0 It would also be g= reat to have some file
> local symbol-shortening mechanism to avoid that long name, but I'm=
> not going to worry about that.

Ping!=C2=A0 Did you have time to look into this?

No sorry. Fixed a much more= serious but though. Early 2025 I will fix this patch, it's easy.=C2=A0=

Jo=C3=A3o
--0000000000003d1d8c062a56909c--