From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#35663: 27.0.50; Eldoc support for apply Date: Wed, 26 Aug 2020 12:11:52 +0100 Message-ID: References: <871s17uq15.fsf@web.de> <87y2m11yuz.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000b8611a05adc5e396" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17003"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen , 35663@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 26 13:13:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kAtMm-0004JP-O1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 13:13:20 +0200 Original-Received: from localhost ([::1]:58690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kAtMl-0008Md-Hd for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Aug 2020 07:13:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kAtMU-0008LI-AG for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 07:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54217) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kAtMU-0004F5-1E for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 07:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kAtMT-00061p-P7 for bug-gnu-emacs@gnu.org; Wed, 26 Aug 2020 07:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Aug 2020 11:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35663 X-GNU-PR-Package: emacs Original-Received: via spool by 35663-submit@debbugs.gnu.org id=B35663.159844033523083 (code B ref 35663); Wed, 26 Aug 2020 11:13:01 +0000 Original-Received: (at 35663) by debbugs.gnu.org; 26 Aug 2020 11:12:15 +0000 Original-Received: from localhost ([127.0.0.1]:37530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAtLi-00060F-IT for submit@debbugs.gnu.org; Wed, 26 Aug 2020 07:12:15 -0400 Original-Received: from mail-io1-f42.google.com ([209.85.166.42]:43745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kAtLe-0005zx-3a for 35663@debbugs.gnu.org; Wed, 26 Aug 2020 07:12:13 -0400 Original-Received: by mail-io1-f42.google.com with SMTP id s1so1645581iot.10 for <35663@debbugs.gnu.org>; Wed, 26 Aug 2020 04:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=johINJPubHjNdbdMWSoU4DbtzXtCqdMj63jVFOtyMew=; b=hDkVIi28aaE+8x34rJwEyJoal/dOF5Diyl8XTIk0ce0c05p5CYJicIIWFtWcmzC2lg vd93LT0+VMpoE/8B5WRA7e3JLOd+FJAyV05SZCCYDsydDcZQFV7tCo+AmK7La0+kP87u 9UBhsAK8BbouXLs/iaUey+xX2PXjpsdWlVkLDlZnvgNy8A5AWFo9hnVrPPbk9NuhexWI RwZ+igWpa0umBMXygXajPn18NNo/RwHbJ87h/PXpwXaCT/HRVwEspN4m23qcI2Z9TJXQ 4aEHtOJ7get2zzfxbHz0ehcFBk3rQRcDJrdA471yd3j87DsvhteOFHKz/wcQyd22qWoB DrzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=johINJPubHjNdbdMWSoU4DbtzXtCqdMj63jVFOtyMew=; b=Jva7uEuG9i+4GwdjH/ZZSLcnelaJbHXOh0ixfazZ5lNw+6lUO3QuJ7zm2XeBKm20It MoWy+vDpQyI1n+m7fxzjtp0rtIZh3CsDyiIp2JDid8ULABp2F6dp1MT7g+yvPxzafn4Z YXzH7GdGI4HdLZqvYH9sqzAdcbPnE1wLyNmNk11ClgJ5Hq5bgig70LoLYkEnI/rODLSj 09gnVkayKo4RL2CZ5yg2t7JGeFoQNghwZMGOWP01yuAKldGXPBTxnfIroWV4QwQhNL+x 8fUgguDX2VZOxwAxZChsORUbPp8w+htXoSESDrD8AFkmqyMNYE9cAtu/0cYcu5hu2t6/ pGng== X-Gm-Message-State: AOAM531+GPmLnY5E+kIW+yhL4/H8BfHWNsj1OY+khwdSALNW/t/ZMfY5 TUf2kdQw9I/MxBDK9lXM1/utU36Tzv1rVtdsTiw= X-Google-Smtp-Source: ABdhPJxlllLr68uNAHlbbgnxnokaPkp/asrvkwlBG/BnO4b5lsAnDstLgJ9NrPJnvEzv+wXp0ZLBF/0YzTDQSz4cOk4= X-Received: by 2002:a6b:8f10:: with SMTP id r16mr3988641iod.165.1598440324225; Wed, 26 Aug 2020 04:12:04 -0700 (PDT) In-Reply-To: <87y2m11yuz.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186420 Archived-At: --000000000000b8611a05adc5e396 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, I think this makes sense. SLY/SLIME for CL do something similar with #'make-instance, for instance. As soon as you type the function name or class name and the autodoc system recognizes it, it switches to the showing you the args for that function instead. The patch shouldn't be terribly difficult to adapt, since I've not significantly touched the client-side logic (as in clients of eldoc). I think you can try doing so. I'll keep this on my radar, Jo=C3=A3o On Wed, Aug 26, 2020 at 11:32 AM Lars Ingebrigtsen wrote: > Michael Heerdegen writes: > > > when editing something like > > > > (apply #'call-process > > (car command) > > nil > > (if stderr-file (list t stderr-file) t) > > nil > > (append (cdr command) (list archive name))) > > > > eldoc support would be useful to see the argument names of > > 'call-process' instead of the signature of 'apply'. > > Yeah, that would be really nice... Some people might want to know what > the signature to apply is, though, but probably a lot fewer. > > > @@ -1356,6 +1356,16 @@ elisp-eldoc-documentation-function > > ((eq current-symbol (car current-fnsym)) > > (or (apply #'elisp-get-fnsym-args-string current-fnsym) > > (elisp-get-var-docstring current-symbol))) > > + ((and (memq (car current-fnsym) '(apply apply-partially)) > > + (< 1 (cadr current-fnsym)) > > + (let ((args (save-excursion > > [...] > > The patch no longer applies, because eldoc has been rewritten > substantially over the last year. Is there any interest in resurrecting > this patch and getting it applied? I've added Jo=C3=A3o to the Cc. > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > --=20 Jo=C3=A3o T=C3=A1vora --000000000000b8611a05adc5e396 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

I think= this makes sense. SLY/SLIME for CL do something similar
with #&#= 39;make-instance, for instance.=C2=A0 As soon as you type the function name=
or class name and the autodoc system recognizes it, it switches = to the
showing you the args for that function instead.
=

The patch shouldn't be terribly difficult to adapt,= since I've not significantly
touched the client-side logic (= as in clients of eldoc).

I think you can try doing= so. I'll keep this on my radar,
Jo=C3=A3o
On Wed, A= ug 26, 2020 at 11:32 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Michael Heerdegen <michael_heerdegen@web.de> writes:

> when editing something like
>
> (apply #'call-process
>=C2=A0 =C2=A0(car command)
>=C2=A0 =C2=A0nil
>=C2=A0 =C2=A0(if stderr-file (list t stderr-file) t)
>=C2=A0 =C2=A0nil
>=C2=A0 =C2=A0(append (cdr command) (list archive name)))
>
> eldoc support would be useful to see the argument names of
> 'call-process' instead of the signature of 'apply'.
Yeah, that would be really nice...=C2=A0 Some people might want to know wha= t
the signature to apply is, though, but probably a lot fewer.

> @@ -1356,6 +1356,16 @@ elisp-eldoc-documentation-function
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0((eq current-symbol (car current-fnsy= m))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (or (apply #'elisp-get-fnsym-arg= s-string current-fnsym)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (elisp-get-var-docstri= ng current-symbol)))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((and (memq (car current-fnsym) &#= 39;(apply apply-partially))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (< 1 (cadr= current-fnsym))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((args (= save-excursion

[...]

The patch no longer applies, because eldoc has been rewritten
substantially over the last year.=C2=A0 Is there any interest in resurrecti= ng
this patch and getting it applied?=C2=A0 I've added Jo=C3=A3o to the Cc= .

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no


--
Jo=C3=A3o T=C3=A1vora
--000000000000b8611a05adc5e396--