From: "João Távora" <joaotavora@gmail.com>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: 70958@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>,
Troy Brown <brownts@troybrown.dev>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown
Date: Mon, 27 May 2024 22:05:28 +0100 [thread overview]
Message-ID: <CALDnm51crPeFeFqZ_dEB_uqe3NVncQAvkPMvYMnbW-VTqvw0ZA@mail.gmail.com> (raw)
In-Reply-To: <877cffp38y.fsf@betli.tmit.bme.hu>
On Mon, May 27, 2024 at 6:35 PM Felician Nemeth
<felician.nemeth@gmail.com> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
> >> > So when e-m-m-hook was added it was made to run only on "turn on"
> >>
> > IOW, I don't think there was ever a time when it was ever run at "off"
> > time.
>
> I don't think it matters much, but originally it did run in both cases:
> https://github.com/joaotavora/eglot/commit/8d8c90d0d654d262e0ff43f45444ec6a512b8185
>
> So the current situation can be regarded as a regression.
I think it does matter, it's one less thing to worry about if we
push that one-liner patch. Can you comment on it, is it doing
more or less the same in your opinion? I opted to put it before
before the server is shutdown, so that, like the on case, it has
access to a presumably fully setup server.
João
next prev parent reply other threads:[~2024-05-27 21:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 12:38 bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown Troy Brown
2024-05-25 7:53 ` Eli Zaretskii
2024-05-26 22:46 ` João Távora
2024-05-27 12:29 ` Troy Brown
2024-05-27 12:35 ` João Távora
2024-05-27 12:45 ` Troy Brown
2024-05-27 14:09 ` João Távora
2024-05-27 14:32 ` Troy Brown
2024-05-27 15:45 ` João Távora
2024-05-27 15:51 ` João Távora
2024-05-27 16:21 ` Felician Nemeth
2024-05-27 17:22 ` João Távora
2024-05-27 17:35 ` Felician Nemeth
2024-05-27 21:05 ` João Távora [this message]
2024-05-27 22:21 ` João Távora
2024-05-28 13:00 ` Troy Brown
2024-06-01 14:18 ` Eli Zaretskii
[not found] ` <CALDnm507yRL6y6VcM-OwHUhSmFbpcFhsUb00wabirPkfq7ZAow@mail.gmail.com>
2024-06-01 16:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm51crPeFeFqZ_dEB_uqe3NVncQAvkPMvYMnbW-VTqvw0ZA@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=70958@debbugs.gnu.org \
--cc=brownts@troybrown.dev \
--cc=eliz@gnu.org \
--cc=felician.nemeth@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.