From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#66144: 29.1; eglot-shutdown request params violate JSONRPC Date: Sat, 14 Oct 2023 09:59:46 +0100 Message-ID: References: <83bkd1sjr1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c6033d0607a96556" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16514"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Javier Olaechea , 66144@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 14 11:00:52 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qraVw-000465-89 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Oct 2023 11:00:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qraVp-0004Ju-KF; Sat, 14 Oct 2023 05:00:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qraVl-0004J8-5F for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 05:00:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qraVi-0001Yv-Vj for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 05:00:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qraW6-0008JE-Dw for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2023 05:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2023 09:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66144 X-GNU-PR-Package: emacs Original-Received: via spool by 66144-submit@debbugs.gnu.org id=B66144.169727403131860 (code B ref 66144); Sat, 14 Oct 2023 09:01:02 +0000 Original-Received: (at 66144) by debbugs.gnu.org; 14 Oct 2023 09:00:31 +0000 Original-Received: from localhost ([127.0.0.1]:47864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qraVb-0008Ho-0j for submit@debbugs.gnu.org; Sat, 14 Oct 2023 05:00:31 -0400 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:56811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qraVY-0008HS-FZ for 66144@debbugs.gnu.org; Sat, 14 Oct 2023 05:00:29 -0400 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5041bb9ce51so3552255e87.1 for <66144@debbugs.gnu.org>; Sat, 14 Oct 2023 02:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697273999; x=1697878799; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=H0zb1419Hwkt+UEXkpEIPTZFVVqV570d3Cg3F8CtJCw=; b=c5BO7Qv7WcETS9xaoiBCszF3pZTIbXor19XgAhxCZGCcxDC0tWt8x+fx2J5+wcLeQ/ E8ujnpx8AZDWGaCprYSmeU1kQZbMSN5K6fECsPhon0HP3jAtzGoKWn7OMqtSYqN+nr6N 5HeTLiEFAfZJt2ayqNr4JQDi1IQFIS5H6ZxbCPVl9X49R4fr38fJXCDv2UFTvGeu9sPL n1rc8LmnkBa+OQSuAXLvTJGtcw+G7GDj8Xst9/fL++VZsq0dnIaxsqg8B3oYgBLqO94M /RJuXPCuneahSzME2VwHC035oi9kIePm5Vwtt3hvNByFJYCTWy5BMQLxOUrBH1JHkcLO l+iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697273999; x=1697878799; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H0zb1419Hwkt+UEXkpEIPTZFVVqV570d3Cg3F8CtJCw=; b=etqar+yQDvaTtvTtlSB5t7IT0mOOLpiNrsZgKsR3V/oN/AIYgsGDXabpis8zYMU5fg 9EQcrz2EBF/SNc3pRq6DfkNlOZ/KfWI812rlrLdCi5W/XRgZ4dErSc539QedYgezirak 7EZ9+38yuYOdeBGigV782qdAOKMp3+wiBipX0J1JLrZd97WcShN/UxnfUnDsIb56QWBZ 4/O0j5O91M8uRW3glzH9Q185rSj+wz4+zVBfclx1Il2CA3Rt0LC52Gk3sEkux87JEOh4 Va9+pOvMgPG/lIIZ8g8SIxcPvncIcYeKjCtOvEje1fPYfY+KEw1vusJY3gwwRaqVQLcl lpQg== X-Gm-Message-State: AOJu0Yw8K6IIFga9mBjI+8CXVsvnLbl3YqeNjbzU6zBajmnlPKRxwgF5 DLQDTLemWlrwYCQ9nYt4Wwisu5eLiRC05vlDpdU= X-Google-Smtp-Source: AGHT+IF/7rls7/C4P/b0JrZg0yRb4WoXNVN593p8bgkDHWNUpTmiUmM+8E2S+/rxny55fOx9wgs99c8nBNrCpq727VQ= X-Received: by 2002:ac2:522f:0:b0:500:b7dc:6c90 with SMTP id i15-20020ac2522f000000b00500b7dc6c90mr22661254lfl.36.1697273998605; Sat, 14 Oct 2023 01:59:58 -0700 (PDT) In-Reply-To: <83bkd1sjr1.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272395 Archived-At: --000000000000c6033d0607a96556 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Oct 14, 2023, 09:14 Eli Zaretskii wrote: > > From: Javier Olaechea > > Date: Sat, 7 Oct 2023 22:42:47 -0500 > > > > It seems that eglot used to send an empty object as the params but it > got replaced by null to appease > > gopls. > > > > > https://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca31= 3a58f4375e > > > > The fix would be replacing the call > > (jsonrpc-request server :shutdown nil :timeout (or timeout 1.5)) > > with > > (jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5)) > > Jo=C3=A3o, any comments? > Yes. What's the matter? What would the "fix" fix? > --000000000000c6033d0607a96556 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Oct 14, 2023, 09:14 Eli Zaretskii <eliz@gnu.org> wrote:
> From: Javier Olaechea <pirata@gmail.com>
> Date: Sat, 7 Oct 2023 22:42:47 -0500
>
> It seems that eglot used to send an empty object as the params but it = got replaced by null to appease
> gopls.
>
> h= ttps://github.com/joaotavora/eglot/commit/4f6e152e1c5efc39a888f747ecca313a5= 8f4375e
>
> The fix would be replacing the call
> (jsonrpc-request server :shutdown nil :timeout (or timeout 1.5))
> with
> (jsonrpc-request server :shutdown eglot--{} :timeout (or timeout 1.5))=

Jo=C3=A3o, any comments?

=
Yes. What's the matter? What would the "fi= x" fix?
--000000000000c6033d0607a96556--