From: "João Távora" <joaotavora@gmail.com>
To: Ship Mints <shipmints@gmail.com>
Cc: dmitry@gutov.dev, Eli Zaretskii <eliz@gnu.org>, 72701@debbugs.gnu.org
Subject: bug#72701: eglot crash when project-files-relative-names t
Date: Fri, 23 Aug 2024 23:49:07 +0100 [thread overview]
Message-ID: <CALDnm51b9UNZbUpukenFtvJs=Eex+_evLSCf+m+-TaW92-q1GQ@mail.gmail.com> (raw)
In-Reply-To: <CAN+1Hbp9pNQSM9qtviHZPO38z7UD7eaGRYPfBSWrErjRKERghQ@mail.gmail.com>
Even without git access you can still submit a full patch prepared
with something like 'git format-patch'.
But this is enough, I think. Thanks. I think I'll leave it to Dmitry
to decide what to do here.
João
On Fri, Aug 23, 2024 at 4:08 PM Ship Mints <shipmints@gmail.com> wrote:
>
> João, I don't have Emacs git access so I'll write the equivalent comment and commit message here.
>
> -----
> (project-files-relative-names nil) ; override global to ensure directory components are retained
> (dirs-to-watch
> (delete-dups (mapcar #'file-name-directory
> (project-files
> (eglot--project server))))))
> -----
>
> "project.el has a global, project-files-relative-names, which influences project-files to return results without parent directory prefixes and this causes file-name-directory to fail to detect directories at the root of the parent. We disable project-files-relative-names to ensure complete results."
>
> On Thu, Aug 22, 2024 at 4:37 PM João Távora <joaotavora@gmail.com> wrote:
>>
>> If I understand the problem and the fix it's that `project-files` has
>> its return value controlled by a global.
>>
>> Not sure that's a great API design (maybe it should change the end
>> result some interactive commands instead).
>> But adding the dynamic binding sounds fine, feel free to push, just
>> add a good explanation in the commit message.
>>
>> João
>>
>> On Thu, Aug 22, 2024 at 6:52 PM Eli Zaretskii <eliz@gnu.org> wrote:
>> >
>> > > Cc: Dmitry Gutov <dmitry@gutov.dev>,
>> > > João Távora <joaotavora@gmail.com>
>> > > From: Ship Mints <shipmints@gmail.com>
>> > > Date: Thu, 22 Aug 2024 13:04:23 -0400
>> > >
>> > > Greetings, just want to make sure this fix doesn't get lost...
>> >
>> > Fear not, patches don't get lost here.
>>
>>
>>
>> --
>> João Távora
--
João Távora
next prev parent reply other threads:[~2024-08-23 22:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-18 15:43 bug#72701: eglot crash when project-files-relative-names t Ship Mints
2024-08-22 17:04 ` Ship Mints
2024-08-22 17:52 ` Eli Zaretskii
2024-08-22 17:53 ` Ship Mints
2024-08-22 20:38 ` João Távora
2024-08-23 15:07 ` Ship Mints
2024-08-23 22:49 ` João Távora [this message]
2024-08-22 23:22 ` Dmitry Gutov
2024-08-23 14:56 ` Ship Mints
2024-08-23 15:08 ` João Távora
2024-08-23 15:10 ` Ship Mints
2024-08-23 23:51 ` Dmitry Gutov
2024-09-07 7:20 ` Eli Zaretskii
2024-09-08 2:24 ` Dmitry Gutov
2024-09-08 10:56 ` João Távora
2024-09-08 20:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm51b9UNZbUpukenFtvJs=Eex+_evLSCf+m+-TaW92-q1GQ@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=72701@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=shipmints@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.