From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#71823: 31.0.50; project-mode-line and eglot duplicate project-name in mode-line Date: Wed, 3 Jul 2024 17:03:09 +0100 Message-ID: References: <86wmm9jfk7.fsf@gnu.org> <86o77kjk87.fsf@gnu.org> <17183c60-1733-4938-9a85-f3351c87bcb9@gutov.dev> <87jzi6fvar.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15303"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Eli Zaretskii , Spencer Baugh , 71823@debbugs.gnu.org, Juri Linkov To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 03 18:05:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sP2U5-0003i5-0W for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Jul 2024 18:05:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sP2Tg-0002aw-Fp; Wed, 03 Jul 2024 12:05:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sP2Td-0002Yg-9e for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2024 12:05:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sP2Tc-00071M-LQ for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2024 12:05:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sP2Te-0005eb-9t for bug-gnu-emacs@gnu.org; Wed, 03 Jul 2024 12:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jul 2024 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71823 X-GNU-PR-Package: emacs Original-Received: via spool by 71823-submit@debbugs.gnu.org id=B71823.172002267221677 (code B ref 71823); Wed, 03 Jul 2024 16:05:02 +0000 Original-Received: (at 71823) by debbugs.gnu.org; 3 Jul 2024 16:04:32 +0000 Original-Received: from localhost ([127.0.0.1]:40200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sP2T9-0005dX-Ru for submit@debbugs.gnu.org; Wed, 03 Jul 2024 12:04:32 -0400 Original-Received: from mail-oa1-f44.google.com ([209.85.160.44]:44297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sP2T8-0005dH-BA for 71823@debbugs.gnu.org; Wed, 03 Jul 2024 12:04:31 -0400 Original-Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-24c9f6338a4so2921426fac.1 for <71823@debbugs.gnu.org>; Wed, 03 Jul 2024 09:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720022603; x=1720627403; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Gtlg6bfHOddh4FkeX/Djv4YNH90+BnE0pCbBKnnbSAc=; b=OFSFc3q3haSKYEud55tb869t8SzjR8Z/Zt7ofP9hy6qZVBA5sS3GuDM4mkDTkMEzFe kLgevr/W/XDyf5zLq9GSMGaH9pdVanZWbeq6xNf99K/vcucxA0V3O4zIDY7ffBkavumA R+JnaXsHRvF6lNyUBFu/kSu2laGTwfs0dP85MLjwElGuhbhqiHBn6frIqjDKEB0Gdu/7 rAf5YnXkusY1c66tmShCGEeeyi584OcXZ+DAz2s6eLghWCbnyY6Gzm5gt51xGBf5OemD 2qXEVE44ak7Poy76qCcOW6BdKGmUrBCTcdtukv7G37ZNJ5VQIoKRjquScHsCTKNRN0Or FBIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720022603; x=1720627403; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gtlg6bfHOddh4FkeX/Djv4YNH90+BnE0pCbBKnnbSAc=; b=wbBh956krl2sDiNlutr8+5T3DzgLQOepQpRrlnKKFCnxZv2sQjCJWtyjGoq1k8wiH9 1T8eCo5Ifffngmy/Wm+vz5YlOAlII57XyY8Mqn0GPf8cxT5Spe8NbrnRrb9ePXo4brFT P2uPsU1ybjRzNvD4FerFeb33We3pm7HywNSjxh/eVdCCQZnF/jp+7BDkqcRsAqOH33nx 0n96MnBWkOo55irFpsOjzkoNKxFDaL0YtR9PtkvyQwtu+m23rSJhtUEcrj3kZ+tfMigl VbV6pu0ArVleTkG8LEioN0IP59W8dwPRMjRzI8S0TpuyyxIMY9l3xV7uUjgGPm0ylA05 I6MQ== X-Forwarded-Encrypted: i=1; AJvYcCVklApUkQFjguLeE0Nu1i62EO/0jkS82y7WIGDID/mU/eCXObzl/DACrXwk+C8NltVUDNvponlOXZ3zgMdaS6PFO0+5N/k= X-Gm-Message-State: AOJu0Yzy8uUmhFEnenenfnDC5vYYTKXlkG9O7p/xUC6z8sT8pNo+LQtV tDJU4S4L+MUHW6lOZuwvnFpsIDdoKQxYReF5wOPwhdpmKYdYCG0zMtzc5YHGjyNtTzz3gFi5vrY 8BemNR3keTvxP+5aBUZ0nGMYdpjM= X-Google-Smtp-Source: AGHT+IEW+VOSjuwmm24DeyNWRiui93g6BVJKxiAeSz7d7YuuLr6DpSHQgPf4SUjX5nZzxaf+P/2xEudR+g9RTApmnVo= X-Received: by 2002:a05:6870:d24e:b0:25e:129c:2223 with SMTP id 586e51a60fabf-25e129c8c5dmr1478368fac.19.1720022602549; Wed, 03 Jul 2024 09:03:22 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288326 Archived-At: On Wed, Jul 3, 2024 at 4:12=E2=80=AFPM Spencer Baugh wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > On Wed, Jul 3, 2024 at 3:47=E2=80=AFPM Spencer Baugh wrote: > > > >> Do any of these seem acceptable? > > > > No, sorry. > > When you originally said the patch was OK, how did you think the > project-mode-line worked? I said the idea was OK :-) I forgot that Eglot's own display of the project name is not only that. It has more functionality: the project name is only a label. So what I thought would be a mere replacement and is actually not. > >> > I also don't understand the other changes (i.e. to the menu) but > >> > that's OK. > >> > >> The project-name in the eglot mode line entry had the server menu > >> attached to it. Since the project-name is no longer present, the serv= er > >> menu isn't accessible. To make the server menu accessible again, it's > >> added to the main eglot menu. > > > > Ah right. Well that unexpected side effect alone makes this > > approach unacceptable. > > Why is that? What's the problem with moving the server menu to the main > menu? Nothing in particular, but if we're going to do that, we might as well do the other thing, which I still think is cleaner. > >> But I don't want to delegate the responsibility of solving this proble= m > >> to the user, I want the problem to just be gone: the entries should ju= st > >> not duplicate project-name. > > > > This problem wasn't introduced by Eglot. > > Definitely, but it seems like it is best to fix it in Eglot. It's best to allow the user to choose, and Eglot doesn't have a way to let the user choose (while project has). So let's give them one in Eglot. Jo=C3=A3o