From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 44ebd9cbd56 2/2: Eglot: explain how to update Eglot in manual (bug#62720) Date: Thu, 4 May 2023 00:31:23 +0100 Message-ID: References: <168263878553.23108.4718240877999827191@vcs2.savannah.gnu.org> <20230427233949.44D31C22A13@vcs2.savannah.gnu.org> <20f53b0a-d6ff-8ec0-2f8c-e0e22b2d49dc@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13491"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 04 01:32:29 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puLxV-0003JI-4k for ged-emacs-devel@m.gmane-mx.org; Thu, 04 May 2023 01:32:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puLwi-0005T6-0s; Wed, 03 May 2023 19:31:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puLwg-0005Sj-Cq for emacs-devel@gnu.org; Wed, 03 May 2023 19:31:38 -0400 Original-Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puLwe-0005h0-KR for emacs-devel@gnu.org; Wed, 03 May 2023 19:31:38 -0400 Original-Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-38dfbbfe474so1554384b6e.0 for ; Wed, 03 May 2023 16:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683156694; x=1685748694; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rW4tPxkEkecw5O3qev6gKUkX+qvfj8FNxseay+A3WME=; b=Zepeqa0Ak+mHFpLyRm5W7AC+T1UE2bp8hPm+qOrxpZ1HySkby+KiTgPO9VOb3oRUFh JYrqtrV0hVWw2rkTsiKsNzLmt9iEIyq6Z8W6YJFScxl8wW3AFqqnUEl1wm+VYjKqlcO/ Fift5upmNYpAsR7xgscj+Z2944QpsQcD1ytAbGowVjYQUsTkTu/y0e4SoKmJ8gt4dOPB mB3FYhysrQKms8YDT8piW5PnwtXUyMcx0M70a4Z7GHuv9EZdVLf7HLOxFb9gtsGA4I8l GtIfGXcsfUdcox6anXGcBmoUZgO4tPaOXmA5P8rIQx+2neAL0Ech88u25NSrj6Y/6UIG GrrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683156694; x=1685748694; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rW4tPxkEkecw5O3qev6gKUkX+qvfj8FNxseay+A3WME=; b=fUFiJjeu5Bk9XmE1aDV59lNqAy71hPkQSX+wp64bsE09fIXqKfVvf8YDhP7xbNaUv+ oozUXSOSh+HNvejrffjPARyt0KNtofQAXJ82m+rmtI5UlKM/fy80905j6tI5mRVb0sTA b2kTvVd2sGxuygllmF2mxeWhjrtus+i7fcubaH7o3yKkPsJzeiwXzgo/AWDWI6ClwHA4 AydypayMyRkbDEXeRGOeTOdLhzU1ioHTBze4Eq3NTJ8Za7k2RrO3rBurScbu8RAjIJef 5gGGQQpf4EMc3HM0rZvx+sdyEk2zWjNHgfXOq6tYSteLuMqtt5bCnzGftVoH9oCpA63f b3zA== X-Gm-Message-State: AC+VfDwqTJEMfH8lN0uo1GZUuhx0P8oRkXLupo1TCNbhl9tLtHoTlW4W Re17IXGEdXoln/uxHbKNzu1dJcC5CGWWZoxkbvSZ3HrFmI0= X-Google-Smtp-Source: ACHHUZ61an7IlvWj3g3AKZDGJzdYH5xbCeWPOzQY2G3RPGhJ5TOrk9XaQoobL/omyV/bkmXDPPOn5bfHxomhfUzP88I= X-Received: by 2002:a05:6808:140b:b0:392:55ec:80f2 with SMTP id w11-20020a056808140b00b0039255ec80f2mr1007742oiv.46.1683156694355; Wed, 03 May 2023 16:31:34 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::22d; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x22d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305804 Archived-At: On Wed, May 3, 2023 at 11:48=E2=80=AFPM Dmitry Gutov wro= te: > > On 28/04/2023 03:35, Jo=C3=A3o T=C3=A1vora wrote: > > On Fri, Apr 28, 2023 at 12:53=E2=80=AFAM Dmitry Gutov= wrote: > >> Hi! > >> > >> On 28/04/2023 02:39, Jo=C3=A3o T=C3=A1vora wrote: > >>> * lisp/progmodes/eglot.el (eglot-update): New command. > >> Should it be called eglot-upgrade now as well? > > No objection, don't feel strongly about it. If you want to > > change it, go ahead, but remember to change the manual as > > well. > > Ok, I did the rename. Hmmm, unfortunate. I thought you had abandoned the idea, as you didn't reply to that part specifically. The problem is that Eglot 1.15, released in the meantime, now has eglot-update. So I think we should rename it back in Emacs 29, sorry. Either that or release Eglot 1.16 asap. > Two more things: > > - Commit 44ebd9cbd56 also removed the call to (eldoc) from the end of > eglot-completion-at-point which has been there for a few years. Was that > intentional? Didn't look like it. Not intentional no. Well, at least not for that commit. Not pretty, but I wouldn't worry about it. > - Consider the issue that I brought up in > https://debbugs.gnu.org/62720#715 regarding (cadr (assoc 'eglot > package-archive-contents)). I'm not sure there's even a guarantee that > the available versions are sorted, but even if they are obeying > package-archive-priorities seems like a good idea. Though I can > understand if it's not your first priority in this command. Is this a problem that can affect the Eglot package specifically? In which conditions? Jo=C3=A3o