From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62417: ; Regression: 59ecf25fc860 is the first bad commit Date: Sat, 25 Mar 2023 13:04:24 +0000 Message-ID: References: <87sfducmrc.fsf@gmail.com> <87o7oicgy4.fsf@gmail.com> <87wn365e3t.fsf@posteo.net> <87pm8yaq24.fsf_-_@gmail.com> <83fs9tc7o9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d52ed005f7b9268e" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19093"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Philip K." , 62417@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 25 14:13:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pg3i2-0004h8-6u for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Mar 2023 14:13:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg3hj-0008Fw-Nx; Sat, 25 Mar 2023 09:13:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg3hf-0008FQ-3l for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 09:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg3he-0000jx-R3 for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 09:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg3he-0006Ki-HR for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2023 09:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62417 X-GNU-PR-Package: emacs Original-Received: via spool by 62417-submit@debbugs.gnu.org id=B62417.167974995424308 (code B ref 62417); Sat, 25 Mar 2023 13:13:02 +0000 Original-Received: (at 62417) by debbugs.gnu.org; 25 Mar 2023 13:12:34 +0000 Original-Received: from localhost ([127.0.0.1]:42133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg3hB-0006Jz-Rd for submit@debbugs.gnu.org; Sat, 25 Mar 2023 09:12:34 -0400 Original-Received: from mail-il1-f182.google.com ([209.85.166.182]:43730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg3hA-0006Jj-G6 for 62417@debbugs.gnu.org; Sat, 25 Mar 2023 09:12:32 -0400 Original-Received: by mail-il1-f182.google.com with SMTP id n1so1569762ili.10 for <62417@debbugs.gnu.org>; Sat, 25 Mar 2023 06:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679749937; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MCWCP9zlV5uL6nlJczPnQf8tvKW+S8O8I0dKzI50FHQ=; b=Uba+br5fBsy2IFgsUWTbmcexpr03glAcW9AjCgqxamapP39b26+s0AFZAIxdlq1j51 T/Uj7nRLg1o7wZFAoSIA2WlbTk503AxLiYg8+43+XFRhOqD/VmJEYXNcfgdH1ZxJZdOd H0Qz5hsklDhBWFMxF9LmjYzXGZMWPWQ+iEr4VjG6+OsYOPPd0Z+lmnr5EIep9Kgw/BJy +bsy5eZT06/OKZWMzVab29G2MycVPQgBoDBrvrTWYcOn2owaEnZbGr42yUZobDyKzoqH f57WP5uV71mFvFg0eZSl+xKV8SDZQ86Z9MPYMxgNvwR3jff8vdsevrWdj7xIQVeAZHdW WzCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679749937; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MCWCP9zlV5uL6nlJczPnQf8tvKW+S8O8I0dKzI50FHQ=; b=7jiMI0dRm7mm6hUdAuhTwTo/GZDCqtTauiF6PKyZlI/amJ0y67CKrIDVFS5KD113nu eU3YDtCeIjqb7PcV1cU1tr3rx7f5Wc1i7uKJg1WJJ+9I8am2rWx90J3RLhZgNb6KEMZD RgBAFuQ4+F2bA6jaZnNwiUvSCaNrtrOByDQmYVl4xCauDYreXXjGGGL7c4NyjWB7S5uN sGGejYTC8XrljDfaIjVSHqZl3RRSLwnTRgXS3c4iq8KOh/s46+jVVHsKuLEMemAXjFq3 TGhQRFjzNBcZrYQJH2zBEexjN7Dm361OKsivYuJ3yIjeKs5uC7/zwn4TahWW06bXayUT aovQ== X-Gm-Message-State: AAQBX9c8fkT/lwCpnIYBqcp6nVoZnomoJ+OGZ+hbTeWiycyUPJtMzRtT LSwBevjep5C1aYW6K+iKdiAfUUaSXgZ1ce893vHQK7J0 X-Google-Smtp-Source: AKy350bEzrrLVeZf9Cvho5GFZ3ga534tiM0VLUHuacw3Jw0yA3dJ5auVvIuXD9TfvhE4s1yTRYSwINHvhyBCmGDpGFo= X-Received: by 2002:a05:6870:1256:b0:17a:d52e:77de with SMTP id 22-20020a056870125600b0017ad52e77demr2133776oao.5.1679749476067; Sat, 25 Mar 2023 06:04:36 -0700 (PDT) In-Reply-To: <83fs9tc7o9.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258562 Archived-At: --000000000000d52ed005f7b9268e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 25, 2023, 12:55 Eli Zaretskii wrote:. > > > > So it is most clearly a regression. > > There's something missing in the above description, since > buffer-match-p accepts a function as its CONDITION argument, and calls > that function with the buffer and ACTION. So it sounds like code > written for Emacs 28 should still work. What is missing here that > explains the breakage? > As I highlighted, Emacs used to call such functions with a buffer _name_ and an action. Now it calls them with a buffer _object_ and an action. This is a backward-incompatible change. Jo=C3=A3o --000000000000d52ed005f7b9268e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Mar 25, 2023, 12:55 Eli Zaretskii <eliz@gnu.or= g> wrote:.
>
> So it is most clearly a regression.

There's something missing in the above description, since
buffer-match-p accepts a function as its CONDITION argument, and calls
that function with the buffer and ACTION.=C2=A0 So it sounds like code
written for Emacs 28 should still work.=C2=A0 What is missing here that
explains the breakage?

As I highlighted, Emacs used to call such functions w= ith a buffer _name_ and an action. Now it calls them with a buffer _object_= and an action. This is a backward-incompatible change.

Jo=C3=A3o
--000000000000d52ed005f7b9268e--