From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#16981: 24.3.50; electric-pair-delete-adjacent-pairs broken in c-mode, python-mode, maybe-others Date: Sun, 6 Apr 2014 16:08:39 +0100 Message-ID: References: <87fvlsq977.fsf@kitaj.lan> <877g738buc.fsf@kitaj.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1396797030 19522 80.91.229.3 (6 Apr 2014 15:10:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Apr 2014 15:10:30 +0000 (UTC) Cc: 16981@debbugs.gnu.org, Alan Mackenzie To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 06 17:10:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WWoiD-0004A3-EV for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Apr 2014 17:10:21 +0200 Original-Received: from localhost ([::1]:58347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWoiC-0008R1-PA for geb-bug-gnu-emacs@m.gmane.org; Sun, 06 Apr 2014 11:10:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWoi5-0008Dk-BH for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 11:10:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WWoi0-00065G-H4 for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 11:10:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WWoi0-000659-Dd for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 11:10:08 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WWohu-0000JJ-1E for bug-gnu-emacs@gnu.org; Sun, 06 Apr 2014 11:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Apr 2014 15:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16981 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16981-submit@debbugs.gnu.org id=B16981.13967969481115 (code B ref 16981); Sun, 06 Apr 2014 15:10:01 +0000 Original-Received: (at 16981) by debbugs.gnu.org; 6 Apr 2014 15:09:08 +0000 Original-Received: from localhost ([127.0.0.1]:38200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWoh1-0000Hu-IT for submit@debbugs.gnu.org; Sun, 06 Apr 2014 11:09:07 -0400 Original-Received: from mail-qc0-f169.google.com ([209.85.216.169]:42151) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWogy-0000HN-Pw for 16981@debbugs.gnu.org; Sun, 06 Apr 2014 11:09:05 -0400 Original-Received: by mail-qc0-f169.google.com with SMTP id i17so5479413qcy.28 for <16981@debbugs.gnu.org>; Sun, 06 Apr 2014 08:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=7kyRWz+Bddv3T1XhdEZX1oPdHIULCA9JDKshJkRiOCg=; b=Vl6eIURG+BwDrv0X60wqT7awXYY69NPs0QQZXUvDiWjlSai68ied8njYVtJ4leyPtb dgG2JQfxZkVLo+D/dycv9QLnMkuATQhEoCZz23ihWjENqQqrJcS1NX2q2mNFpH3sdvNb PsY3vYYZ9iv1wUItEgqTOLQCkdCciGN8Ildfw1P9vIVIz+BU0lXoPtYgHhBruUveQ7YL E+IAmHGipwrM9NxSz4Xijf+vk/zNwCXDZNlzoKTPMUY2eR8bxbMHUHvl6cyorZvmQsGQ 9OB1xzAaIz0wZgW0vGunN18wy732YVEOh9J06reU5gohjJpU1YGVatUDLhGMaOR0ME/f J1/w== X-Received: by 10.224.63.138 with SMTP id b10mr2970646qai.79.1396796939413; Sun, 06 Apr 2014 08:08:59 -0700 (PDT) Original-Received: by 10.229.46.199 with HTTP; Sun, 6 Apr 2014 08:08:39 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:87802 Archived-At: On Sun, Apr 6, 2014 at 1:48 PM, Stefan Monnier wrote: >> Hmmm now I remember that's it's even harder than defadvice to find the >> extra code, docstring-wise I mean. How would a hacker discover we're >> using the filter trick. describe-key doesn't help. . > > Right. C-h k will give you the binding, but only when > electric-pair-delete-pair would be run. To make this trick more widely > usable, we'd need to change C-h k so that it shows all "possible bindings". Yes, I realized that later on. In the meantime, we can use the trick that yasnippet uses (documentation-function if I'm not mistaken) to show what other command electric-pair-delete-pair is shadowing in that situation. >> Anyway should I install it? > If that's OK with you, yes. Yes, I think it's cleaner than all alternatives, unless add-function is the way to go for these situations. > Bzr doesn't really know about cherry picking, but if you put > "backported" into your commit message, our bzrmerge.el script > will know that this commit is already in the trunk and will know how to > avoid the corresponding conflicts when merging emacs-24 back into trunk. Alright, I'll include "backported from trunk, revs x and y".