From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use Date: Wed, 6 Jul 2022 13:59:51 +0100 Message-ID: References: <87y1x7pd53.fsf@gmail.com> <83v8sb73ga.fsf@gnu.org> <87tu7vpc8y.fsf@gmail.com> <83tu7v6kjv.fsf@gnu.org> <83r12y7b0y.fsf@gnu.org> <83let676fe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000059aabe05e3228762" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25674"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56407@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 14:59:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o94ca-0006Vw-9S for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 14:59:12 +0200 Original-Received: from localhost ([::1]:57154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o94cY-00050c-OJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 08:59:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o94cQ-00050D-GX for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 08:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o94cQ-0003T0-7V for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 08:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o94cQ-0003L4-4K for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 08:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56407 X-GNU-PR-Package: emacs Original-Received: via spool by 56407-submit@debbugs.gnu.org id=B56407.165711233012815 (code B ref 56407); Wed, 06 Jul 2022 12:59:02 +0000 Original-Received: (at 56407) by debbugs.gnu.org; 6 Jul 2022 12:58:50 +0000 Original-Received: from localhost ([127.0.0.1]:52820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o94cE-0003Kc-H6 for submit@debbugs.gnu.org; Wed, 06 Jul 2022 08:58:50 -0400 Original-Received: from mail-oa1-f53.google.com ([209.85.160.53]:35806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o94cC-0003KL-Ge for 56407@debbugs.gnu.org; Wed, 06 Jul 2022 08:58:48 -0400 Original-Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-10be0d7476aso14403588fac.2 for <56407@debbugs.gnu.org>; Wed, 06 Jul 2022 05:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wB0FqptYAX6+dL7kio9+VsT+HXJk1ohNVH1c8yFc6Uc=; b=dgOjhojUA0EuDeq9x5s4mlf9zb1u27iBjElfD2ginLjHz9LRE7IeHu+8x76S7fTUDV JCjWv+oVCRhWzy2oiQ3CYqm6M/EBFKNbQvE/bxFTi2+vIc2KdAERIdwgfBwvojPLJElN GBvO1DeRLznOeUDaaPv8L+4hHZdJyhZV+d+/UXFSfvCxdYXWgQMsjLhG2iK4gyIgBJNV 8ZMERDwlP/WwLen2faiEGIfZLP9/A5HdN5N7QRmLJEBdLkqK9DTqy5Ls0I/koKEpToR1 8L03xEZcPBP7NikAjMSE1213aF5mn7SVGU+yhUCa0+qUlaRYo0tAz36hBQf/Ve7/jUVk ZAoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wB0FqptYAX6+dL7kio9+VsT+HXJk1ohNVH1c8yFc6Uc=; b=StzFy6F6l4zZNHZ9q7FCDzWQmvf3IekirsYNTAsLIMtsqCLmEQQ5HSO+VpmTo0S76Q 0Ngp/21VCMPgoXX2c4Wjup1Z337V7x+CZpxTrCf1rj+PrBNZswoLkMJRJUkXQJa55REp CHBPW/AcFI7CBk+jxAsxxRzYTfCO/5Bnx5rI/88G23GkRTEX6YkJyheo0jmYtafxg9rf ILoFqQhN5cByu3iXr59CB6nKERTPFbiKhXH797y8tZOlvguUghLhZeN919dZDg1qOg9K iLMXaaSVG2JUICBcTjE0QDj7t4VfCRKJI/2ACSnaWxAW1cCpRnNAzcI37RXjG9T+/omz l7zg== X-Gm-Message-State: AJIora9dl40lLgHWpVK/IvnK4l1OMdVCoQxgoagrfkdfGc8qr/J5pq4W l7WjhuGX0jheMvfZKgx1E5icILQOpInee433i0oTlvDI X-Google-Smtp-Source: AGRyM1ulmC7b/lrOY4sn7VYrhtfRfL6kvWiHfEXzrFAECEvKlpOAUzvJVmR8JJtlydvmItFpn2pBl5dyJSuXzKBXh60= X-Received: by 2002:a05:6870:8925:b0:fe:4638:dc01 with SMTP id i37-20020a056870892500b000fe4638dc01mr25702814oao.209.1657112322745; Wed, 06 Jul 2022 05:58:42 -0700 (PDT) In-Reply-To: <83let676fe.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236233 Archived-At: --00000000000059aabe05e3228762 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > > > But then I'd say it is even worse, as you're informing desktop.el > > about an implementation detail of eglot.el. If I change that minor > > mode's name, then I have to change desktop.el as well. > > That's okay: it's desktop.el's job to know about some implementation > details. Just look at how much it knows about what the various modes > and variables do in Emacs. Wait, you're saying it's "okay" to have to do a commit to Emacs's repo everytime someone makes a third-party package that has a minor mode that needs special handling? Or everytime someone changes the name or shape of a minor mode? I can't possibly see how this is okay. There should simply be a generic mechanism for minor-modes to tell desktop.el and other intrusive packages to "stay out of my minor mode". But we do have that mechanism. It's called symbol properties and it's a nic= e feature of lisp. So let's use it, please. All the other solutions are demonstrably worse. I'm not even saying to get rid of d-m-m-table, as Lars is. I'm just saying: let's not type "name-of-eglot-symbol-that-joao-may-want-to-change" into desktop.el. It's really a hazard. Jo=C3=A3o --00000000000059aabe05e3228762 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> But then I'd say it is even worse, as you're informing desktop= .el
> about an implementation detail of eglot.el.=C2=A0 If I change that min= or
> mode's name, then I have to change desktop.el as well.=C2=A0

That's okay: it's desktop.el's job to know about some implement= ation
details.=C2=A0 Just look at how much it knows about what the various modes<= br> and variables do in Emacs.

Wait, you&= #39;re saying it's "okay" to have to do a commit to Emacs'= ;s repo
everytime someone makes a third-party package that h= as a minor mode
that needs special handling?=C2=A0 Or everyt= ime someone changes the name
or shape of a minor mode?
=
I can't possibly see how this is okay. There should simp= ly be a generic
mechanism for minor-modes to tell desktop.el and = other intrusive
packages to "stay out of my minor mode&= quot;.=C2=A0

But we do have that mechanism. I= t's called symbol properties and it's a nice
feature of l= isp. So let's use it, please. All the other solutions are demonstrably<= /div>
worse.=C2=A0 I'm not even saying to get rid of d-m-m-table, a= s Lars is.=C2=A0 I'm just
saying: let's not type &qu= ot;name-of-eglot-symbol-that-joao-may-want-to-change"=C2=A0
=
into desktop.el.=C2=A0 It's really a hazard.

Jo=C3=A3o
--00000000000059aabe05e3228762--