From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#66041: 30.0.50; Should 'flymake-note-echo' inherit from 'compilation-info'? Date: Sun, 17 Sep 2023 23:15:31 +0100 Message-ID: References: <1f9e98be-3248-56cf-b7fd-8301666675c6@gmail.com> <1e19cc18-9942-aa51-c49e-9441e873f037@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38129"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66041@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 00:16:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qi03m-0009l4-3p for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 00:16:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qi03Y-0005PI-4R; Sun, 17 Sep 2023 18:15:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qi03X-0005Ot-3B for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 18:15:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qi03V-0001kJ-Sz for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 18:15:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qi03d-0006Ln-NZ for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2023 18:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Sep 2023 22:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66041 X-GNU-PR-Package: emacs Original-Received: via spool by 66041-submit@debbugs.gnu.org id=B66041.169498896024404 (code B ref 66041); Sun, 17 Sep 2023 22:16:01 +0000 Original-Received: (at 66041) by debbugs.gnu.org; 17 Sep 2023 22:16:00 +0000 Original-Received: from localhost ([127.0.0.1]:51606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qi03c-0006LY-5h for submit@debbugs.gnu.org; Sun, 17 Sep 2023 18:16:00 -0400 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:61602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qi03Z-0006LK-D1 for 66041@debbugs.gnu.org; Sun, 17 Sep 2023 18:15:58 -0400 Original-Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50305abe5f0so1810659e87.2 for <66041@debbugs.gnu.org>; Sun, 17 Sep 2023 15:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694988943; x=1695593743; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=40+2YWotPw/OCR4Kql33uFpApMGAU5y3+2Fv+br8+G4=; b=jV2wWdtzgWQeFgYswpAJEDR9Fe/+JDgC1n+i3qMuaOkVnHr1iKq7baYZ2BlAz5bJbn iqp4NE18ekbfoXVTKoCIpnoR06TixNqGbDq5hMRJEuoIFq4/IXMnQul2z2hLYcxFGEv0 43ru5rpZi0sYNBOMARuRLBn+CyXtza52cJaiuCwMDYbDf5qRYnl5fqE513ngrDDyRk4L tw15VxB58GEkh00AyBxiQkOak7ezWVtphGnLUQfveqy8UiPFm7H/TZ+ILj7KO1vRvZyK 1lIFvJfcEeWkEuL26J90KK0s5deGNIyRABb3dSUaIAu8LW8u7Jc93RjbTWlDAbOIjU9k GPrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694988943; x=1695593743; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=40+2YWotPw/OCR4Kql33uFpApMGAU5y3+2Fv+br8+G4=; b=I6qDPLk639fxCaiVPFtE3M06VPsGPtz0OmAMjIIcwSLipVRYW+l96nfUoum0fmQcEA KmuCSLZAbLcMnDrLzQl9xbJqyAjmyyZCodX0rHGwDD6Rv5Xr1hBAvzcZ2ZKIhb0ixLeV pe+uA0Gu6PsYjAVE08DW3Ra9p6YJci1JvdmhNhPC3ys5ap5EqFkE1elFv5V/9aakE7Bn SFhqADbuNtXWqdwqqu3lOdcUQlzqeYSKGOrFEMD4/tPnvRzhEjZN9bBzQ4lCfWhVHP5r 9fh3rLNd8Omxeotad+kDzVEvpN4H8spVfMitSQ22lHKE6Y3uY5sak/GO/QD+Nz4OcZmP WOYw== X-Gm-Message-State: AOJu0YwM+GGIjPt9JjwDwT7hMpt8qQ0QRcIxoaODtiTmoexoImB6WURY r2vekupAxTCJUhtTK/xx9pbcgIwkkcg4psS1rO0= X-Google-Smtp-Source: AGHT+IFQj8YHsvCMARHR/Plac16iYRV4Z92x16n/RELr34G5FgefqI4+O76CBRyf2VTJmjivJ5nbMmWRkpRuOp1o6+s= X-Received: by 2002:a05:6512:3ca1:b0:503:778:9ad2 with SMTP id h33-20020a0565123ca100b0050307789ad2mr3697625lfv.19.1694988943071; Sun, 17 Sep 2023 15:15:43 -0700 (PDT) In-Reply-To: <1e19cc18-9942-aa51-c49e-9441e873f037@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270726 Archived-At: On Sun, Sep 17, 2023 at 10:54=E2=80=AFPM Jim Porter = wrote: > > On 9/17/2023 2:22 PM, Jo=C3=A3o T=C3=A1vora wrote: > > On Sun, Sep 17, 2023 at 5:42=E2=80=AFAM Jim Porter wrote: > > > >> Personally, I think it'd be better for the "echo" faces for Flymake > >> notes to just inherit from 'compilation-info'. They have almost > >> identical uses as far as I can tell, and then things would look more > > > > To better understand what you mean, can you post two screenshots -- wit= h > > and without your proposed change -- of what the default theme would loo= k > > like in a simple file with some Flymake overlays? > > Sure, here are screenshots of Flymake under 29, 30, and 30 plus my > patch. In particular, pay close attention to the mode-line colors. It > took me a few seconds of close inspection to see the green underline for > the note counter in the mode-line. OK thanks for showing this. I'll think about this better tomorrow. In the meantime, I found two other bugs trying this recipe. First let's write down the recipe: emacs -Q M-x flymake-mode RET M-: (setq flymake-show-diagnostics-at-end-of-line t) RET M-x erase-buffer RET h e l l o The first bug I find is that the exclamation mark on the fringe is green, but it should be yellow, since, presumably a warning is more important than a note. The second bug has to do with the placement of the cursor when two "eol overlays" are present. The cursor shouldn't be placed in the middle of them, since they represent unreachable areas of the buffer. These two bugs are IMO a bit more serious, but I also see your point about the faces. Jo=C3=A3o