From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Brian Leung <leungbk@posteo.net>, Robert Pluim <rpluim@gmail.com>,
Lars Ingebrigtsen <larsi@gnus.org>,
53853@debbugs.gnu.org
Subject: bug#53853: [PATCH] Don't use string-replace in flymake
Date: Tue, 8 Feb 2022 14:09:34 +0000 [thread overview]
Message-ID: <CALDnm51NKYpzCp6aWcWKcOm59SZ48GZpp3aOpj4uPdQ55ejPvw@mail.gmail.com> (raw)
In-Reply-To: <83fsotwjiw.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]
Well, technically, I did "show the patch" even though I didn't author said
patch myself. I answered:
> It would seem that the right thing to do is to keep 26.1 dep and do what
Guillaume Pasquet suggests:
> "or substitute the `string-replace` call with `replace-regexp-in-string`
to maintain compatibility as I have done here:
>
https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacffe6d22
Anyway, all good now, just bring the Emacs dep down to 26.1. Thanks.
João
On Tue, Feb 8, 2022 at 1:55 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: João Távora <joaotavora@gmail.com>
> > Date: Tue, 8 Feb 2022 13:18:44 +0000
> > Cc: Robert Pluim <rpluim@gmail.com>, Brian Leung <leungbk@posteo.net>,
> > Lars Ingebrigtsen <larsi@gnus.org>, 53853@debbugs.gnu.org
> >
> > Alright. Seems that the discussion died down and there was never the
> fix and
> > reversion we (presumably?) agreed on. So I think if the incompatible
> string-something has
> > been now replaced by the replace-regexp-something that is compatible, we
> should now
> > put the 26.1 in the header again. If everyone agrees, I ask someone
> with a Emacs
> > master/emacs-28 checkout nearby to do that change and also bump
> flymake.el's version.
>
> We didn't really agree on the revert: I asked to see the change as a
> prerequisite for my agreement, and never saw any response.
>
> I see that Lars already installed such a change on emacs-28, and it is
> indeed quite simple. So I'm okay with going with that.
>
--
João Távora
[-- Attachment #2: Type: text/html, Size: 2521 bytes --]
next prev parent reply other threads:[~2022-02-08 14:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 16:11 bug#53853: [PATCH] Don't use string-replace in flymake Brian Leung
2022-02-07 17:32 ` Robert Pluim
2022-02-08 2:17 ` Brian Leung
2022-02-08 6:16 ` Lars Ingebrigtsen
2022-02-08 8:21 ` Robert Pluim
2022-02-08 8:28 ` Brian Leung
2022-02-08 8:35 ` Robert Pluim
2022-02-08 9:20 ` João Távora
2022-02-08 9:50 ` Robert Pluim
2022-02-08 9:54 ` João Távora
2022-02-08 9:58 ` João Távora
2022-02-08 13:03 ` Eli Zaretskii
2022-02-08 13:18 ` João Távora
2022-02-08 13:54 ` Eli Zaretskii
2022-02-08 14:09 ` João Távora [this message]
2022-02-08 15:07 ` Robert Pluim
2022-02-08 15:30 ` João Távora
2022-02-08 15:47 ` Robert Pluim
2022-02-08 15:51 ` João Távora
2022-02-08 16:02 ` Robert Pluim
2022-02-08 16:43 ` João Távora
2022-02-08 17:02 ` Robert Pluim
2022-02-08 17:55 ` Dmitry Gutov
2022-02-08 17:08 ` Dmitry Gutov
2022-02-09 8:55 ` Robert Pluim
2022-02-08 9:52 ` João Távora
2022-02-08 10:19 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm51NKYpzCp6aWcWKcOm59SZ48GZpp3aOpj4uPdQ55ejPvw@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=53853@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=leungbk@posteo.net \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.