From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Thu, 5 Mar 2020 11:51:35 +0000 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005ba85905a01a29d3" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="92989"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 12:52:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9p33-000O4A-HY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 12:52:17 +0100 Original-Received: from localhost ([::1]:47586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9p32-0006kQ-JN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 06:52:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59748) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9p2r-0006iW-0U for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 06:52:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9p2p-0001hO-QA for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 06:52:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36305) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9p2o-0001ff-Dp for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 06:52:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9p2o-00078p-CM for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 06:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 11:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158340911527437 (code B ref 38992); Thu, 05 Mar 2020 11:52:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 11:51:55 +0000 Original-Received: from localhost ([127.0.0.1]:42278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9p2h-00078T-4D for submit@debbugs.gnu.org; Thu, 05 Mar 2020 06:51:55 -0500 Original-Received: from mail-il1-f171.google.com ([209.85.166.171]:34845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9p2f-00078G-Lu for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 06:51:54 -0500 Original-Received: by mail-il1-f171.google.com with SMTP id g126so4771171ilh.2 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 03:51:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WM2wu4RsvPWBVaP9ToGBA/tvcqVFu9iTGXxP2W5wiJE=; b=CR1IDlhWwSi7OmcU3Bfl1E2COd71QRzggkSu/I2vk3VaHESiDCAODNGjNiU0CAnvS5 QIHChRjcS7+uHAIfu+IsaiURnfMhyClw7ZH1olqJucNbb1RzG2wjx5GbjicR0idtUGrO 6vQWlh+MbmCIoiSVFuoFdNHEGMJB7jsY9TvBw492c92ObZBRhFS5OgfLDCqJssB8OkFe lgTgQlnL8zAx1BvwJlkro2pxOCv/xAxbMEbfIEl1eooyKHRZ6Jv4RhjT/jr6YjdXve41 Vkp7Wqm8Xd5DzHhL+e5o+DyaYaArHMOYpEAOXhxc64N2kjuTP6gDYOdI6RFqkOZ93F0g 4LJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WM2wu4RsvPWBVaP9ToGBA/tvcqVFu9iTGXxP2W5wiJE=; b=MzF3qkL2b8Q08tmRsyBdcFA0RkaFS3oM0IMhBtFTMwm7UaHI9pwJXen3vLrqzFrzqj 9QGv4TT+88pngJeakHplbwDLSQXCZIT75gEWvmDRxfHTlJkwAr9O+SB0j+7tpHkoKuvL Gx05x4jcq7SBUFvu0yLHFy1Nz9ZlDoxdH6rKEpNZyCBRbJ64nhYA7LZhB2BzsR0YIoio z8rR96n2bATaRDdsxSygc17n8Gtl3aYtxvCvHUS7fvyde78pUTQZpg0LZ/femAN9G2zE +jt36OJhDr7pxFeHrKpAJyRSTApMJVpcGP8FSdILsM2/JdesrSIhgA34jY7eNJjhCmnZ YvcA== X-Gm-Message-State: ANhLgQ3xZ/K0vGVgjv1MUo8BkMhmj2ELnVBGKQc54s82bXPXBO3/qtTV HrB21P3wJh9MOjTMMMmVifvCo+zVVyms5HbbIuQ= X-Google-Smtp-Source: ADFU+vuUJGQq6uaiRcTg0yl+xzPI3kp0bsmjiVD5B0QiYa61JQZOH/LvkFYIPmHE9FLqhKsNunJDtPkIFjK3prTuJz0= X-Received: by 2002:a92:8f91:: with SMTP id r17mr7111649ilk.97.1583409107018; Thu, 05 Mar 2020 03:51:47 -0800 (PST) In-Reply-To: <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176897 Archived-At: --0000000000005ba85905a01a29d3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 5, 2020 at 9:59 AM Dmitry Gutov wrote: > But why? REQUIRE-MATCH is there for a reason. The caller does not expect > non-matching inputs, and is unlikely to handle them well. > > If non-matching input can make sense, then the caller needs to be changed= . > Sure, but before that happens, users get annoyed :-) so let's provide an "out" for them. No, I meant a problem in overall behavior. But it seems fine to me as well. > OK, at this point I think you should push this to Emacs 27, and I'll work with it for a while and flag if I see some bad stuff. We mostly need testing for this new mode (I wonder how many people are testing it, besides the original poster). --=20 Jo=C3=A3o T=C3=A1vora --0000000000005ba85905a01a29d3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 5, 2020 at 9:59 AM Dmitry Gutov <dgutov@yandex.ru> wrote:
But why? REQUIRE-MATCH is there for a reason. The caller does not expect non-matching inputs, and is unlikely to handle them well.

If non-matching input can make sense, then the caller needs to be changed.<= br>

Sure, but before that happens, users ge= t annoyed :-) so let's provide
an "out" for them.

No, I meant a problem in overall behavior. But it seems fine to me as well.=

OK, at this point I think you should= push this to Emacs 27, and I'll work with
it for a while and= flag if I see some bad stuff.=C2=A0 We mostly need testing for this
new mode (I wonder how many people are testing it, besides the ori= ginal
poster).

--
Jo=C3=A3o T=C3=A1vora
--0000000000005ba85905a01a29d3--