From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Date: Fri, 18 Dec 2020 11:42:02 +0000 Message-ID: References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26058"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Glenn Morris , 29193@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 18 12:43:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqEAL-0006hG-UT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 12:43:21 +0100 Original-Received: from localhost ([::1]:43282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqEAK-0005gK-VJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 06:43:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqEA2-0005ff-Mh for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 06:43:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqEA2-0008NL-Fs for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 06:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqEA2-0000az-Du for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 06:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Dec 2020 11:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29193 X-GNU-PR-Package: emacs Original-Received: via spool by 29193-submit@debbugs.gnu.org id=B29193.16082917422241 (code B ref 29193); Fri, 18 Dec 2020 11:43:02 +0000 Original-Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 11:42:22 +0000 Original-Received: from localhost ([127.0.0.1]:37867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqE9O-0000a5-Af for submit@debbugs.gnu.org; Fri, 18 Dec 2020 06:42:22 -0500 Original-Received: from mail-il1-f176.google.com ([209.85.166.176]:37285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqE9L-0000Zq-Ey for 29193@debbugs.gnu.org; Fri, 18 Dec 2020 06:42:21 -0500 Original-Received: by mail-il1-f176.google.com with SMTP id k8so1877614ilr.4 for <29193@debbugs.gnu.org>; Fri, 18 Dec 2020 03:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=YMKe4U3DY3VedbySMCCsimJ6QvPB7cRNJ7hTfPeZeAE=; b=vGiAIs279XmrKFnLrKJAKaNNvMkpQHrAI3OqlwQ4zh10lCawo70acf5xiSiAF2etbd MjH6Bn553lEawPywBZHjkpxCUp3bVmlHxP0hUbLhJ/UrjjWgFOdqCDLdkqtXm5+N10UQ SmzD/RV1vVj+a5U2GayefmGh9scIO3haUHMt90xSQZfeFxBJH+dRYKeHStH9E7nL6T+O aL506rirG2J3MC84zjT2Sl+QzFDd0OgzhplsBR+DzEfD6VCCu1px2hw3mB1Tlo3+gf8Q 1vvTOt/GWQ1IzQrnGVy5h5pbrH5SZx7emG1zC437edmMvN9pch6rwzv3vZG5GedEExCj +UkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=YMKe4U3DY3VedbySMCCsimJ6QvPB7cRNJ7hTfPeZeAE=; b=L9HxYNT7wft9R/k/4NtgwHKqM055Q1xyeW07MWYxNdiw6qu4BTna/7TGdrMuVy7EJ6 wz2snyq5b/CUzYXp/zEn8C9M3kcjScLlbE26jH+UGhcUckUvgCYlpAJCQGI3pTgJnWtj OIvwFrzsAyADeQuIh5437Cuwmes3knOmOMS4dawBkZWoZxx8Mat46QafiButOU7BOigq to2wrAgHcwhn5u6qOgrQ6GXwXeGOQU+6u24PlTY2ZOKHKJcDj1u0b92rIXuj84YjwWM0 VQMCQhVQ9nZ4roY70gvpzSLCWwjxXiw0q2BNP9hcSm5AwdUlcLyLaonr0VTTo5I76WlL mi9w== X-Gm-Message-State: AOAM531fajX+313x1N23djqmmjh3sAll8npDWcPyb8iy+gXH9hltQmi+ t47bx4jj74zXy76hQIGFMcd7nuf9gMYtp/RPkcc= X-Google-Smtp-Source: ABdhPJwKzSqcUi5wRnE5qSA7GnMjeGfgkkJL6yMz5dqAutFOMyKvfElJAmNtsTPEQlzySvywEjvrvCYzM+OBmJ5A9XU= X-Received: by 2002:a92:da82:: with SMTP id u2mr3428201iln.137.1608291733746; Fri, 18 Dec 2020 03:42:13 -0800 (PST) In-Reply-To: <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196318 Archived-At: On Fri, Dec 18, 2020 at 2:07 AM Dmitry Gutov wrote: > > On 18.12.2020 01:25, Glenn Morris wrote: > > fda9a2 causes a test failure. > > > > Ref eg:https://hydra.nixos.org/build/132986117 > > Thanks! It was a curious bug: one would expect that some highlighting's > boundaries might change. What changed, however, is one's _type_. > > I've pushed a fix, and I'll let the Flymake's maintainer sort out at his > leisure whether flymake-diag-region can be relied on not to change match > data, as several of its clients seem to assume. I think this is rather a thingatpt.el issue, which makes no mention of match-data destruction. Regardless, it's decent enough to do that in flymake-diag-region so I pushed save-match-data a bit higher. Thanks, Jo=C3=A3o