From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62417: 30.0.50; Regression: 59ecf25fc860 is the first bad commit Date: Fri, 24 Mar 2023 16:07:52 +0000 Message-ID: References: <87sfducmrc.fsf@gmail.com> <87o7oicgy4.fsf@gmail.com> <87wn365e3t.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39270"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62417@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 24 23:05:54 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfpXm-0009p8-6w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Mar 2023 23:05:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfpTh-0004Tl-6W; Fri, 24 Mar 2023 18:01:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfpTJ-00049P-6M for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 18:01:17 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfpTI-0000eY-UO for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 18:01:16 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfjyQ-00060V-TO for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 12:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Mar 2023 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62417 X-GNU-PR-Package: emacs Original-Received: via spool by 62417-submit@debbugs.gnu.org id=B62417.167967409123001 (code B ref 62417); Fri, 24 Mar 2023 16:09:02 +0000 Original-Received: (at 62417) by debbugs.gnu.org; 24 Mar 2023 16:08:11 +0000 Original-Received: from localhost ([127.0.0.1]:41220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfjxb-0005yv-Ba for submit@debbugs.gnu.org; Fri, 24 Mar 2023 12:08:11 -0400 Original-Received: from mail-oa1-f50.google.com ([209.85.160.50]:34722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfjxZ-0005yh-KY for 62417@debbugs.gnu.org; Fri, 24 Mar 2023 12:08:10 -0400 Original-Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-17ab3a48158so2221718fac.1 for <62417@debbugs.gnu.org>; Fri, 24 Mar 2023 09:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679674084; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9NiQKCPT/uQYu+iSpNTr/pQiHzpAnaPqq6sW4CTLAfo=; b=mPGBZQ8Od4R2obGfLggvszlKmEWdTdt632s8Op4AeLrFZWezcFFuMQOrYuOx7UboI7 9VGxrxlZpfa3VHJ6puSPnUKiKc1srNkTv1VvDt1qdtQgdzgdkuft2gi0erW6+AfgTPJF FBplhKHBFKVgBk7TydUxgi1NHc/AlHputaN/nD0qGRQP8ANCMpaEEVnXS96fVTdvRml5 9LpDhjIEIJMaqiDSsQWdz6mopxaR2mh2YLjK428Wxg15/qHpbV2WLvQcomvEaDkgLTfl jYBRKf78KcM6W7y/LNd7I07xT4z3K1VUKeO0uZqPQWw/TRJT61UIjn9DlmS9IlXFGqas l+nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679674084; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9NiQKCPT/uQYu+iSpNTr/pQiHzpAnaPqq6sW4CTLAfo=; b=t69WuO5WzSZvB7nuZLqVPYE8Vohn+5iB42jJgC4X0L54mXh8IxBd7W12x44wl6/qvg LvBbhvfAsJRqtm/T3UC9SRUNUh+cxGW31XEodzoOPgeQ65+nRAaY6AAsuogTZlEZQYxS f5Cv0vIR/TVZNpw3jO6hopzCk/4yHZf/RhMCudwKVh34M/H5RRqzl1IW+IPjRcbIUPg/ /Lqa8GyzO6bdBNeELnr+ANZ3nWQ9oFHFO0MBGcRj5puDHSEaOW9Sm2xPa3naXoto8Xu8 BTj0KLrGeRsCjA3BwKubJWGSB1eiUPAW3O4zOSi/89wMHZC603zJtq8UG6nFqxGj2niU dWMg== X-Gm-Message-State: AO0yUKUHpFUyDOGTXGm2w0LNRah/+/5m4+YLUSH+tPtvUiHSexnYGmZf 1Ubn7OsKXObQ5g3i7nJeGQcrwX7qmHx9+GErjAbnGFZ3 X-Google-Smtp-Source: AK7set8X/QDAb5FUJlb8sNkB+n6kUAbOLIqlLBAQZJSef12FlfmqHrO6UP3Cc7k4rqSIiLvoKT3Nogg4Bgzus3M8WAg= X-Received: by 2002:a05:6871:4796:b0:17a:df9b:6b1b with SMTP id qa22-20020a056871479600b0017adf9b6b1bmr1333985oab.5.1679674083874; Fri, 24 Mar 2023 09:08:03 -0700 (PDT) In-Reply-To: <87wn365e3t.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258530 Archived-At: On Fri, Mar 24, 2023 at 4:05=E2=80=AFPM Philip Kaludercic wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > tag 62417 patch > > > > Jo=C3=A3o T=C3=A1vora writes: > > > >> I haven't yet investigated the reason. There are other use cases insi= de > >> SLY that are also failing with similar errors, but they are not as eas= y > >> to trigger. > > > > The simples way to fix this is to make display-buffer-assq-regexp keep > > the old protocol before trying `buffer-match-p'. > > > > diff --git a/lisp/window.el b/lisp/window.el > > index 2da2f8bb2c8..0932a05aabf 100644 > > --- a/lisp/window.el > > +++ b/lisp/window.el > > @@ -7502,8 +7502,13 @@ display-buffer-assq-regexp > > the form of the action argument passed to `display-buffer'." > > (catch 'match > > (dolist (entry alist) > > - (when (buffer-match-p (car entry) buffer-name action) > > - (throw 'match (cdr entry)))))) > > + (let ((key (car entry))) > > + (when (or (and (stringp key) > > + (string-match-p key buffer-name)) > > + (and (functionp key) > > + (funcall key buffer-name action)) > > + (buffer-match-p (car entry) buffer-name action)) > > + (throw 'match (cdr entry))))))) > > > > (defvar display-buffer--same-window-action > > '(display-buffer-same-window > > > > Another way would be to fix this in buffer-match-p. > > I cannot make out what is broken in `buffer-match-p'? The patch would > appear to me to be redundant, because both strings and functions are > handled the same way in that function. If you could explain the > background, I think it would be better to fix `buffer-match-p', > considering that this should be how it behaves. If you pass a string to buffer-match-p, it will become a buffer by the time it is passed to the function. So functions that expect strings cannot be in buffer-display-alist after your change, whereas before they could. Jo=C3=A3o