From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot Date: Tue, 13 Dec 2022 20:18:56 +0000 Message-ID: References: <167080394233.4339.5863353994038854528@vcs2.savannah.gnu.org> <20221212001223.E9A9DC004BE@vcs2.savannah.gnu.org> <874ju07vzl.fsf@gmx.de> <87lenbrufm.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000009a3e505efbb55e5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16799"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 13 21:19:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5Bkr-0004Bl-78 for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Dec 2022 21:19:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5BkA-0001nS-Uc; Tue, 13 Dec 2022 15:19:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Bk7-0001nA-Eg for emacs-devel@gnu.org; Tue, 13 Dec 2022 15:19:11 -0500 Original-Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5Bk5-0001Qe-PO for emacs-devel@gnu.org; Tue, 13 Dec 2022 15:19:11 -0500 Original-Received: by mail-ot1-x336.google.com with SMTP id q18-20020a056830441200b006704633f258so593126otv.0 for ; Tue, 13 Dec 2022 12:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rmq0/OHZMwhSrDpP173rcgIWZfTdkAsAIa5HHrPESKM=; b=I1hXtPABi3Tz2Da7ogkdjF36Y9YKJuQLmDl2IAKD5D1olwWLaCiPM0cpaoGTbAGcRB gcDEyvAdnvlFADwGZlkf7ry7ZdbBn+gSid9h5oukTy8vA7Dq6chcWekCKa1v5PQSUe3U q+ko+9bH4djOa9Zz4e2R9rJVM55Om0k0uxUoDvv9slq1hy5oauGI0/TuwJoBLnSClKHi Swp4IM6zb86UlNxS6IclEQh+4Qul0mVHlgzRRSCjZcmsjk95HtJUDcFlkNA+vSU7sC3Z a+qMtCa4e20OuFda62yVuiI0GlSYqLrQLAPgPsTfA+FAFMC8qND1qJkTC+bbDIMTWAqu p1gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rmq0/OHZMwhSrDpP173rcgIWZfTdkAsAIa5HHrPESKM=; b=0L/KyuZWM6PnBklYaNkHIodZxHvOJ2VBLj101O2gPAvh8MaV+vBMlmH8mrRDbFY87f 4j/njBJ+62Mkmdf52fUgw38KXcfZIahtuEhOnGpWnSXzkur24D3/IbQZKwCpy02TBvyM SMZAgPXLvDhhoSp97QUrlyOuGdHv2r2rSU47oEPJ5zXZuVGQus9fcHHjGTYxibANF2L4 yUI/pEwO/zpqAg83XhS2rKwuYsW5f8xnZTBH0PznoSM243xNQ9HqfboN02QbbJ8b7/3T L2/LoczxBu/VIgj1gblkfyi+bpTsZU8v0QJJsCtM7n4+UKlztYKTz5rke7ACUj4sngKV r/aw== X-Gm-Message-State: ANoB5pnsI91kNtTS7GbYxx12ALhQ4QZsmmevitBbS0SmY/7rxiDIph0q WyAT4WWi4JdJSgNPV83RYK/fZRyMqSUwv4eVIZk= X-Google-Smtp-Source: AA0mqf7azhtrzncBGO6yjVuDc48VbHGk2N4vUPChBnOuMp51tMRrz07NoyMTxdseeVrUXIJ7jCCJ0dBZXlWeWNDmN34= X-Received: by 2002:a9d:80a:0:b0:670:8334:ccf2 with SMTP id 10-20020a9d080a000000b006708334ccf2mr875750oty.201.1670962748169; Tue, 13 Dec 2022 12:19:08 -0800 (PST) In-Reply-To: <87lenbrufm.fsf@gmx.de> Received-SPF: pass client-ip=2607:f8b0:4864:20::336; envelope-from=joaotavora@gmail.com; helo=mail-ot1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301360 Archived-At: --00000000000009a3e505efbb55e5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 13, 2022, 19:10 Michael Albinus wrote: > Jo=C3=A3o T=C3=A1vora writes: > > Hi Jo=C3=A3o, > > >> Do you really need this? > > > > Flymake tells me there are 4 compilation warnings if I don't: > > > > 1243 9 warning e-f-b-c Unused lexical variable > > `tramp-remote-path' > > 1243 56 warning e-f-b-c reference to free variable > > =E2=80=98tramp-remote-path=E2=80=99 > > 1244 9 warning e-f-b-c Unused lexical variable > > `tramp-histfile-override' > > 1245 9 warning e-f-b-c Unused lexical variable `tramp-methods' > > > > Here, the flymake backend 'e-f-b-c' (elisp-flymake-byte-compile) > > compiles with Emacs -Q > > and no specially relevant load path in these cases. > > I've fixed this in eglot-tests.el. I've also adapted the two tests wrt > Tramp. Pushed to the emacs-29 branch. > Thanks. I'll have a look later. > FTR, I'm suprised about the names of the test cases. Would it be > possible to give them a unique prefix, like `eglot-test-'? > Yes, do that please. I think this makes sense, although the test symbols aren't exactly bound to functions and it is a nuisance to always type this long boring prefix. If only there was some namespacing mechanism in Emacs that could alleviate that.. oh wait ;-) Jo=C3=A3o > --00000000000009a3e505efbb55e5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Dec 13, 2022, 19:10 Michael Albinus <michael.albinus@gmx.de> wrote:
=
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail= .com> writes:

Hi Jo=C3=A3o,

>> Do you really need this?
>
> Flymake tells me there are 4 compilation warnings if I don't:
>
>=C2=A0 1243=C2=A0 =C2=A09 warning=C2=A0 e-f-b-c=C2=A0 Unused lexical va= riable
> `tramp-remote-path'
>=C2=A0 1243=C2=A0 56 warning=C2=A0 e-f-b-c=C2=A0 reference to free vari= able
> =E2=80=98tramp-remote-path=E2=80=99
>=C2=A0 1244=C2=A0 =C2=A09 warning=C2=A0 e-f-b-c=C2=A0 Unused lexical va= riable
> `tramp-histfile-override'
>=C2=A0 1245=C2=A0 =C2=A09 warning=C2=A0 e-f-b-c=C2=A0 Unused lexical va= riable `tramp-methods'
>
> Here, the flymake backend 'e-f-b-c' (elisp-flymake-byte-compil= e)
> compiles with Emacs -Q
> and no specially relevant load path in these cases.

I've fixed this in eglot-tests.el. I've also adapted the two tests = wrt
Tramp. Pushed to the emacs-29 branch.

Thanks. I'll have a look later.


FTR, I'm suprised about the names of the test cases. Would it be
possible to give them a unique prefix, like `eglot-test-'?

Yes, do that = please. I think this makes sense, although the test symbols aren't exac= tly bound to functions and it is a nuisance to always type this long boring= prefix. If only there was some namespacing mechanism in Emacs that could a= lleviate that.. oh wait ;-)

Jo=C3=A3o
--00000000000009a3e505efbb55e5--