bug#73667: 31.0.50; fido-vertical-mode and yank-pop do not work well together

bug#73667: 31.0.50; fido-vertical-mode and yank-pop do not work well together

[parlando--- via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Hi,

With fido-vertical-mode and if the kill-ring holds some larger text 
blocks, then yank-pop (M-y) shows several blank lines between the 
candidates in the minibuffer.

The selection of a candidate becomes cumbersome too, which unfortunately 
makes M-y quite unusable. This may generally apply to cases with long 
completion entries.

To reproduce:
emacs -Q; then eval:

(fido-vertical-mode 1)
(kill-ring-save 1 1) ; somehow, this leaves the system clipboard out

;; set kill-ring to some short and one long entries
(setq kill-ring
       '(#("Short line 1")
	#("Short line 2")
	#("Short line 3")
	#("Short line 4")
	#("Large block
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod 
tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim 
veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea 
commodo consequat. Duis aute irure dolor in reprehenderit in voluptate 
velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint 
occaecat cupidatat non proident, sunt in culpa qui officia deserunt 
mollit anim id est laborum.

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod 
tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim 
veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea 
commodo consequat. Duis aute irure dolor in reprehenderit in voluptate 
velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint 
occaecat cupidatat non proident, sunt in culpa qui officia deserunt 
mollit anim id est laborum.

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod 
tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim 
veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea 
commodo consequat. Duis aute irure dolor in reprehenderit in voluptate 
velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint 
occaecat cupidatat non proident, sunt in culpa qui officia deserunt 
mollit anim id est laborum.")
	#("Short line 5")
        ))

(yank-pop)

Many thanks!

--

In GNU Emacs 31.0.50 (build 1, x86_64-w64-mingw32) of 2024-10-06 built
  on <...>
Repository revision: 500f5da5fb62cd0bbded8df754d93e3147d1d847
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 10.0.22631
System Description: Microsoft Windows 10 Pro (v10.0.2009.22631.4169)

Configured using:
  'configure --with-tree-sitter --without-sound --with-small-ja-dic
  --with-native-compilation=aot'

Configured features:
ACL DBUS GIF GMP GNUTLS HARFBUZZ JPEG LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

Important settings:
   value of $LC_CTYPE: en_US.UTF-8
   value of $LANG: ENU
   locale-coding-system: cp65001

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   show-paren-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   minibuffer-regexp-mode: t
   line-number-mode: t
   indent-tabs-mode: t
   transient-mark-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
touch-screen dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads w32notify dbusbind w32 lcms2 multi-tty move-toolbar
make-network-process native-compile emacs)

Memory information:
((conses 16 50621 8322) (symbols 48 5448 0) (strings 32 15373 1739)
  (string-bytes 1 481639) (vectors 16 9037)
  (vector-slots 8 129482 12770) (floats 8 24 18) (intervals 56 255 0)
  (buffers 992 10))

bug#73667: 31.0.50; fido-vertical-mode and yank-pop do not work well together

[Eli Zaretskii]

> Date: Sun, 6 Oct 2024 20:33:38 +0200
> From: parlando--- via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Hi,
> 
> With fido-vertical-mode and if the kill-ring holds some larger text 
> blocks, then yank-pop (M-y) shows several blank lines between the 
> candidates in the minibuffer.
> 
> The selection of a candidate becomes cumbersome too, which unfortunately 
> makes M-y quite unusable. This may generally apply to cases with long 
> completion entries.
> 
> To reproduce:
> emacs -Q; then eval:
> 
> (fido-vertical-mode 1)
> (kill-ring-save 1 1) ; somehow, this leaves the system clipboard out
> 
> ;; set kill-ring to some short and one long entries
> (setq kill-ring
>        '(#("Short line 1")
> 	#("Short line 2")
> 	#("Short line 3")
> 	#("Short line 4")
> 	#("Large block
> Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod 
> tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim 
> veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea 
> commodo consequat. Duis aute irure dolor in reprehenderit in voluptate 
> velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint 
> occaecat cupidatat non proident, sunt in culpa qui officia deserunt 
> mollit anim id est laborum.
> 
> Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod 
> tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim 
> veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea 
> commodo consequat. Duis aute irure dolor in reprehenderit in voluptate 
> velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint 
> occaecat cupidatat non proident, sunt in culpa qui officia deserunt 
> mollit anim id est laborum.
> 
> Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod 
> tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim 
> veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea 
> commodo consequat. Duis aute irure dolor in reprehenderit in voluptate 
> velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint 
> occaecat cupidatat non proident, sunt in culpa qui officia deserunt 
> mollit anim id est laborum.")
> 	#("Short line 5")
>         ))
> 
> (yank-pop)

João, any comments?

bug#73667: 31.0.50; fido-vertical-mode and yank-pop do not work well together

[João Távora]

On Sat, Oct 12, 2024 at 1:09 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > Date: Sun, 6 Oct 2024 20:33:38 +0200
> > From: parlando--- via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >
> > Hi,
> >
> > With fido-vertical-mode and if the kill-ring holds some larger text
> > blocks, then yank-pop (M-y) shows several blank lines between the
> > candidates in the minibuffer.
> >
> > The selection of a candidate becomes cumbersome too, which unfortunately
> > makes M-y quite unusable. This may generally apply to cases with long
> > completion entries.
> >
> > To reproduce:
> > emacs -Q; then eval:
> >
> > (fido-vertical-mode 1)
> > (kill-ring-save 1 1) ; somehow, this leaves the system clipboard out
> >
> > ;; set kill-ring to some short and one long entries
> > (setq kill-ring
> >        '(#("Short line 1")
> >       #("Short line 2")
> >       #("Short line 3")
> >       #("Short line 4")
> >       #("Large block
> > Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod
> > tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
> > veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
> > commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
> > velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint
> > occaecat cupidatat non proident, sunt in culpa qui officia deserunt
> > mollit anim id est laborum.
> >
> > Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod
> > tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
> > veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
> > commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
> > velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint
> > occaecat cupidatat non proident, sunt in culpa qui officia deserunt
> > mollit anim id est laborum.
> >
> > Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod
> > tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
> > veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
> > commodo consequat. Duis aute irure dolor in reprehenderit in voluptate
> > velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint
> > occaecat cupidatat non proident, sunt in culpa qui officia deserunt
> > mollit anim id est laborum.")
> >       #("Short line 5")
> >         ))
> >
> > (yank-pop)
>
> João, any comments?

fido-vertical-mode, by its nature, is for selecting single line strings.  As are
most other selection methods I think.  Maybe some display-time string
truncation could be done,  or maybe newlines could be represented
differently.

I don't maintain fido-vertical-mode anymore.

João