From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#65760: 29.1; eglot performance issue Date: Tue, 5 Sep 2023 17:45:32 +0100 Message-ID: References: <87il8o62dw.fsf@ya.ru> <837cp44mko.fsf@gnu.org> <835y4o4mfb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12150"; mail-complaints-to="usenet@ciao.gmane.io" Cc: glebsmirnov0708@gmail.com, ivan-p-sokolov@ya.ru, 65760@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 05 18:46:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdZC5-0002v2-9B for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Sep 2023 18:46:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdZBk-0006C0-0s; Tue, 05 Sep 2023 12:46:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdZBi-00068l-6h for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 12:46:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdZBh-0002y0-Uq for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 12:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdZBi-00038d-7g for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 12:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65760 X-GNU-PR-Package: emacs Original-Received: via spool by 65760-submit@debbugs.gnu.org id=B65760.169393235311036 (code B ref 65760); Tue, 05 Sep 2023 16:46:02 +0000 Original-Received: (at 65760) by debbugs.gnu.org; 5 Sep 2023 16:45:53 +0000 Original-Received: from localhost ([127.0.0.1]:58651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdZBZ-0002r7-9n for submit@debbugs.gnu.org; Tue, 05 Sep 2023 12:45:53 -0400 Original-Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]:55479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdZBW-0002Z2-SU for 65760@debbugs.gnu.org; Tue, 05 Sep 2023 12:45:51 -0400 Original-Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b9338e4695so41960551fa.2 for <65760@debbugs.gnu.org>; Tue, 05 Sep 2023 09:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693932344; x=1694537144; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wwfvoeRmdeg1thNt/uZMKUzwD1W/3VAsO0gDaz0r5Ew=; b=c3kZtAyE3yLUxR5dvpedaQLS8VuVF7FrFUIbyRiPiLQIVt6xRZbCQVbPCq70hzOeBZ G8YsET/OMLx87cgohvmpG9ZHNNpVHsC0VSnzc0laIydNsOEPayWyveGcdKbhZeMTZCFA R9huD+0qL8gZ+yKYbOjFNhGXPToJM5aCpYXBX5QV7ZxlMMFxUglGmTwogGKRswsLzy9c 1qjVTwCvukMnD0KHSUdbFadN4ZMMpiPAzzpTIcMbAlol0s44bOAc2rphUsTiyAboAlK8 +Xky0prkWXbGRIXPko5W9ieO0dnMhh/umtxgV228nRPRTXg0DbCz1erDxK58uqnQN7PM mruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693932344; x=1694537144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wwfvoeRmdeg1thNt/uZMKUzwD1W/3VAsO0gDaz0r5Ew=; b=jvLtkXp8ILoWmrRVAPmvhiSKpVXy3JtOhPPWS95TwgA/TjA5IkMiRMbqzd+VIVeL4h yvrjc13UT29Eja9R5jxF/e0W87S5WCr+VZyc3yIR9ywvbZvFsuvSbpuszw/Xk8Aydimg stRF5XKJBtXf933M+4Dfnr9cRt52lzZ48Cg8m4z+VGARlVzksp5nL+N5y88OjLHmpK7U 6DrB1rmPBdGswNOLEe2sXiiGN/fBY4S0IWRuPlETZL+5hX3BBbt5r0kaVxCGDiRVErZK k9mASqNBZkaISbpXm2+iQpXwAZUvDDM0iUEF9CRf4yr9Bs9m3Wqlk33enBb3ZmNRuxUo qAKQ== X-Gm-Message-State: AOJu0YydPVnsPtbGoTHX7uU00sOx8RPTZ/vE0d1FrRqp0juCiGRqKQA+ OhzUjVjl67Wv1P17ZAKQNdtKIiTXJnSKlwf0fqg= X-Google-Smtp-Source: AGHT+IFi6CTsU99B86clZJCPoDiAyuB3Qt6FSnWPBif9L/gXst0kX20ggz8yalk+u/rwOzbw/ealVsBEzmn54nT1ky4= X-Received: by 2002:a2e:900e:0:b0:2bc:d5ad:2758 with SMTP id h14-20020a2e900e000000b002bcd5ad2758mr245251ljg.5.1693932344178; Tue, 05 Sep 2023 09:45:44 -0700 (PDT) In-Reply-To: <835y4o4mfb.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269381 Archived-At: On Tue, Sep 5, 2023 at 5:25=E2=80=AFPM Eli Zaretskii wrote: > > Adding Jo=C3=A3o. The troubleshooting section in the manual https://joaotavora.github.io/eglot/#Troubleshooting-Eglot has a heading specifically dedicated to these types of performance problems: "A common and easy-to-fix cause of performance problems is the length of the Eglot events buffer because it represent additional work that Eglot must do. After verifying Eglot is operating correctly but slowly, try to customize the variable eglot-events-buffer-size (see Eglot Variables) to 0. This will disable any debug logging and may speed things up." So, keeping a rich log and human-readable log is very useful for debugging but can kill performance if servers send tons of JSON. Maybe I could review the default value of eglot-events-buffer-size or find a more fine-grained solution like some new foo-print-level or foo-print-length variables, likely for jsonrpc.el. Suggestions welcome. Patches doing this are even more welcome. Jo=C3=A3o