From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Thu, 6 Apr 2023 17:59:21 +0100 Message-ID: References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> <87ile9t5uj.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4846"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62694@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 06 19:00:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkSyO-0001A2-Iy for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Apr 2023 19:00:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkSy1-0006cZ-Ql; Thu, 06 Apr 2023 13:00:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkSxz-0006bq-4j for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 13:00:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkSxu-00021k-Mw for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 13:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkSxu-0002ug-HW for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 13:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Apr 2023 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.168080038111142 (code B ref 62694); Thu, 06 Apr 2023 17:00:02 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 6 Apr 2023 16:59:41 +0000 Original-Received: from localhost ([127.0.0.1]:54988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkSxZ-0002te-Cr for submit@debbugs.gnu.org; Thu, 06 Apr 2023 12:59:41 -0400 Original-Received: from mail-oi1-f173.google.com ([209.85.167.173]:46619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkSxX-0002tP-Mg for 62694@debbugs.gnu.org; Thu, 06 Apr 2023 12:59:40 -0400 Original-Received: by mail-oi1-f173.google.com with SMTP id l18so29504190oic.13 for <62694@debbugs.gnu.org>; Thu, 06 Apr 2023 09:59:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680800374; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GEcuU3+YNDYDtIu6tBpksYz1vnLWQWuS68ei5dPNkis=; b=NX2HIWpWIghIp383Qh9W9wJIB1rYzcyGjQAAFOhZ8C55Xwkt8IAZgXPc7mhFddS7aN S49F8UiUARYCPKg+7+Tq0FnCDRgvbthoj2j5ZAAZySS1u6+nAf+wXTzTCPA8ewYBLPUk 0zdMwCuMEMylmVqyDYe56uhmXD3lxoh1BTTpXGgemPgsDDg4T5RW3eFRP6zT8+EW7qGK IX1GhIKrcDgJ6a1LmiWBgJ53BUc/1uVjCLo0cHyO9s+Pc7FaPjPOABLmji8eqW9LZg+0 ehVpAxYzPKMHpumYkXy9ZwVRKML7StzOuAt0Offgg6PqatqdhOHzuIaByvx/0LEeQoxY x5Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680800374; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GEcuU3+YNDYDtIu6tBpksYz1vnLWQWuS68ei5dPNkis=; b=cgTgTUK2/nCbfk47/PLAOkFqf7CV3mlMJ9ezg5yOCRlJ5Ta4uTmE7q6bN01hZuirdL nmdjUSRDVo12ev0rfLv8njeilgx0s7MjHnJgzUDryGl24sH0ekzqAukGoYVMekq/1n8I uweNVpimXcW5gOzRb85AHSA8ANusFPbvlaLUbGfdh8iV17Tezkvy6ib/ab5O0RSdMZXT 7C/gEUbOeTcTJ2advn2LSWI/C05B4xETvjqgTnD1SsG+OHtNHC+uq42gSkc0FS2Z5PJc LuuZ7Ni6iIGq0ywqQf1rzzrycdtwmEx5sDXAVVef5o8M2nmRnxMSRD/urlYJLWDvpx/I TlsA== X-Gm-Message-State: AAQBX9epetIrfGM18N1EqbTjVCtfm52gvvJYLYHOeffgX90VMve0E0kH 1ihbTJ4zNvDegigOzsp1pKLWz2h+MduRoDWHPX0= X-Google-Smtp-Source: AKy350YuuqIJmS5uN8WNN8biQhIuEbxVQRh123SIkqrC8CU/XDRAyjOB1hMZG8XGO2Ug7kS92//MM1f6dAmRoe1j4mg= X-Received: by 2002:aca:2411:0:b0:378:30dc:ae5b with SMTP id n17-20020aca2411000000b0037830dcae5bmr3182777oic.5.1680800372408; Thu, 06 Apr 2023 09:59:32 -0700 (PDT) In-Reply-To: <87ile9t5uj.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259335 Archived-At: On Thu, Apr 6, 2023 at 3:58=E2=80=AFPM Michael Albinus wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > Hi Jo=C3=A3o, > > >> I disagree. Running regression tests towards bleeding edge development > >> version of pylsp is not the intention. You cannot expect, that everybo= dy > >> running Emacs tests has installed pylsp like this. But she could have > >> installed the Debian pylsp package. > > > > Sure, or she has a 'pylsp' that prints the complete works of > > Shakespeare. But these tests are designed for the number one > > recommended pylsp installation method. It's AFAIK not the > > "bleeding edge" (which would be a Git installation). And tests > > have been running fine with that installation method for a > > number of months now, maybe even years. > > I don't doubt. But you cannot expect that everybody uses "the number one > recommended pylsp installation method". I expect that. The same way I expect people to install Eglot from ELPA, and use a normal installation of Emacs, not some "Doom" or "Spacemacs". Or the same way I expect people not to have advice in their configurations. Many times my expectation fails, and yet I expect these things, because that's what I programmed against. So if they don't use that method, then maybe they should. More importantly, here we're talking about the much smaller universe of Emacs developers, not regular users. > Again, I'm not speaking about eglot users. They shall know what to > do. But eglot-tests could fail for everybody who has installed a pylsp > package, for example from Debian, w/o even being interested in eglot. That package is faulty to some degree in that it does not work exactly like the recommended installation of pylsp. Even if that's a problem for some hypothetical hardcore Debian user who happens to also be an Emacs developer and who uses pylsp but not in Eglot, and for some reason won't install anything from anywhere else in his development machine, we have yet to hear from the hordes of users at the intersection of all those conditions. In your case in particular, I'd say you have control over what you install in your machine and what you install in EMBA. And I've given you the recommended way to fix this, if you really must have pylsp there. Again, can you answer what is preventing you from using `pip install` in your machine or in EMBA scripts? Also, what is moving you so resolutely to install pylsp at all in EMBA? Are you programming Python with some other LSP client on EMBA. Is anyone? Are you just trying to get the best possible coverage from eglot-tests.el? Thanks, but then I'd focus on rust-analyzer first, or the Java jdtls server= . The latter would be really useful as the GitHub CI isn't currently installing it and the test is being skipped there. > >> I recommend that you investigate why the tests fail. And if this sound= s > >> too much, at least the sanity checks shall be improved. (skip-unless > >> (executable-find "pylsp")) doesn't seem to be sufficient then. > > > > I don't have Debian. We can overhaul the sanity checks, but I don't > > immediately see how. Or why. So it's hardly a priority. > > See above. With the instructions I have added to admin/notes/emba, it > should be simple. Thanks, I'll have a look one of these days. Jo=C3=A3o