From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61943: 29.0.60; icomplete--in-region-setup should activate icomplete-fido-mode-map too Date: Tue, 21 Mar 2023 23:40:50 +0000 Message-ID: References: <87o7p9u29j.fsf@melete.silentflame.com> <87h6v1s0p4.fsf@melete.silentflame.com> <87cz5os0v2.fsf@melete.silentflame.com> <87y1npg3o5.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19233"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61943@debbugs.gnu.org, juri@linkov.net To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 22 00:42:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pelcT-0004oK-06 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 Mar 2023 00:42:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pelcM-0005hP-O3; Tue, 21 Mar 2023 19:42:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pelcD-0005h5-87 for bug-gnu-emacs@gnu.org; Tue, 21 Mar 2023 19:42:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pelcA-0005en-1G for bug-gnu-emacs@gnu.org; Tue, 21 Mar 2023 19:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pelc9-0000XN-Mh for bug-gnu-emacs@gnu.org; Tue, 21 Mar 2023 19:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Mar 2023 23:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61943 X-GNU-PR-Package: emacs Original-Received: via spool by 61943-submit@debbugs.gnu.org id=B61943.16794420691985 (code B ref 61943); Tue, 21 Mar 2023 23:42:01 +0000 Original-Received: (at 61943) by debbugs.gnu.org; 21 Mar 2023 23:41:09 +0000 Original-Received: from localhost ([127.0.0.1]:32907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pelbJ-0000Vx-5O for submit@debbugs.gnu.org; Tue, 21 Mar 2023 19:41:09 -0400 Original-Received: from mail-oi1-f174.google.com ([209.85.167.174]:40789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pelbH-0000Vj-9W for 61943@debbugs.gnu.org; Tue, 21 Mar 2023 19:41:07 -0400 Original-Received: by mail-oi1-f174.google.com with SMTP id r36so12446642oiw.7 for <61943@debbugs.gnu.org>; Tue, 21 Mar 2023 16:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679442061; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t2fRvnY7FbtIsElKIaNB1FjyVjb1k9m2enzH3lGLveM=; b=Khq3B9x5DBPOEhelCaJ8lPpWuvpxDUo8lEqWfXcTlF3PIfZ2W9UNA3qlNayhdE0GJu NyiICVL/u9mIICNLccN2tmInQS1Eio3V/Vm0lYT6dxhySxAKqgrFrVixnX6uWkntKBYx kOCnahvcsvslI0NN05+VUJYnOXFJRRSrBVki+09rSHDNMSq/nr880kepJz7CrPrtbxH3 wByg5uM+mLAWqG8YpqI7eMlYU3vqoK9ZMyzNTzgANtz93QSjcKpnYUdIc0uvG0BxY6d2 +29ax0JcihbQnwfsFubPZ3XSnTiIZpO4V+j7JszBIr6piI3CFYwh75egCUI3cP/O2+jt UqPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679442061; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t2fRvnY7FbtIsElKIaNB1FjyVjb1k9m2enzH3lGLveM=; b=P6scO/rMvbRorkTv8Ov3D3bxvpyI0PfJaixHdFqfC8oDgvy2mrMzW1ggWXR98KI1nn ZFN5KxPWIEPA/0Y94mv87HtA7YYspzAm0t2/rWoxFfgSp4xYk5NUiy0JWVB1mXuoH2vF CEHMJZlq/TSqRPZfCFnEC/X/jU4/cNU9Rz1GSmRRLaPgxLuy/PUFpMdxOD2izlbiy1Au zqSUDujXJJ6eCoG26+6VxKpVLpxmcjiaZvzObEN4Y9NukWXDFJG9+44Vi6GVMRo+Wx6j 2uNlGINMLdVGbWDiXKa7KxobbBWd6XS0R0PxfdSjwSHP6lM+JMkieNHjzclFB36wY4RN Byzw== X-Gm-Message-State: AO0yUKXgzLXP7L1ZTo0aTuaTPWKuatK2Sepr431I0LgpCBgyhmJmkUhO nrxud9I9UhRNOY0AMO08uGdD/6hbo13pSGB7WeA= X-Google-Smtp-Source: AK7set96GfBCBEV3TnW7iwsPI/np/+Bx0aQWj/te7ijNNjS9JHGwIIjTQt01z5LP+DQ5xG/aGfaEuSNiigGI8IV4BLY= X-Received: by 2002:a05:6808:1526:b0:384:1cf9:912e with SMTP id u38-20020a056808152600b003841cf9912emr348598oiw.5.1679442061670; Tue, 21 Mar 2023 16:41:01 -0700 (PDT) In-Reply-To: <87y1npg3o5.fsf@melete.silentflame.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258375 Archived-At: On Tue, Mar 21, 2023 at 10:06=E2=80=AFPM Sean Whitton wrote: > > Hello Jo=C3=A3o, > > On Sat 04 Mar 2023 at 01:44PM -07, Sean Whitton wrote: > > > On Sat 04 Mar 2023 at 11:30AM GMT, Jo=C3=A3o T=C3=A1vora wrote: > > > >> Yes, Sean, please report an Emacs -Q recipe for what you are trying > >> to get working. > > > > Alright, how about this: > > > > (setq icomplete-in-buffer t) > > (fido-mode 1) > > M-x eshell > > touch foobarbaz > > C-x C-f fbb =3D> matches the file > > C-g > > type "ls fbb" > > > > TAB =3D> No matches > > C-g > > (setq completion-styles '(flex)) > > TAB =3D> matches the file & expands > > > > but with fido-mode you shouldn't need to set completion-styles like thi= s. > > > > (In Eshell TAB is completion-at-point and C-M-i is something else.) > > May I ask whether you've had a chance to look into this yet? Yes you may, but no, I haven't. Icomplete and Fido and cousins, it's true. But icomplete-in-buffer wasn't around (at least wasn't in any way functional) when Fido was born. So I don't have any plans of integrating this part of icomplete in Fido, because it's not really how I envision Fido being used for non-minibuffer completion. I have other plans for a future fido-in-buffer where the feedback overlay -- in horizontal or vertical form -- shows in the echo area instead. That said, if a simple patch to make icomplete-in-buffer work with fido-mode can be achieved, I have no problem reviewing it. As you suggested, it could be as simple as integrating icomplete--fido-mode-setup into icomplete--in-region-setup. But that is relatively tricky as whatever variables are set when entering this mode but be properly reset when leaving it. Doing this elegantly might not be hard, but it's not trivial either. Jo=C3=A3o