From: "João Távora" <joaotavora@gmail.com>
To: martin rudalics <rudalics@gmx.at>
Cc: Nicolas Richard <theonewiththeevillook@yahoo.fr>, 17007@debbugs.gnu.org
Subject: bug#17007: 24.3.50; describe-key/function evaluates documentation function in the wrong buffer
Date: Sun, 16 Mar 2014 13:27:50 +0000 [thread overview]
Message-ID: <CALDnm50xX9eScKB4qNmOsUH+73yOYMC6k8qwvjB2Qjt6YEvNOw@mail.gmail.com> (raw)
In-Reply-To: <532576A7.6090600@gmx.at>
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
On Sun, Mar 16, 2014 at 10:02 AM, martin rudalics <rudalics@gmx.at> wrote:
> > The 24.3 version of with-help-window used with-output-to-temp-buffer
> > AFAICT.
>
> `with-temp-buffer-window' code some checking? After all, you were the
> one who detected the inconsistency that was the root of all evil here
> and I trust that you could detect any remaining inconsistencies as well.
>
> Thanks, martin
>
Thanks, will do, as soon as I have time to make a new build.
I wonder if one could write unit tests for these scenarios...
Just a thought, not thoroughly tested, and could be brittle:
(ert-deftest help-window-describe-function-in-correct-buffer
()
"Check if `function-documentation' is eval'ed in right
buffer."
(defun help-foo ())
(defun help-foo-doc ()
(format "Does nothing, but your tab does `%s'"
(key-binding "\t")))
(put 'help-foo 'function-documentation '(foo-doc))
(let* ((selected-window-before (selected-window))
(text (describe-function 'help-foo))
(help-windows (get-buffer-window-list "*Help*")))
(unwind-protect
(progn
(should (eq selected-window-before (selected-window)))
(should (= 1 (length help-windows)))
(with-selected-window
(car help-windows)
(should-error (search-forward "forward-button"))))
(delete-other-windows))))
[-- Attachment #2: Type: text/html, Size: 2166 bytes --]
next prev parent reply other threads:[~2014-03-16 13:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 11:22 bug#17007: 24.3.50; describe-key/function evaluates documentation function in the wrong buffer João Távora
2014-03-13 15:57 ` Glenn Morris
2014-03-13 16:29 ` João Távora
2014-03-13 19:18 ` João Távora
2014-03-14 11:32 ` martin rudalics
2014-03-14 12:08 ` João Távora
2014-03-14 14:34 ` martin rudalics
2014-03-14 15:05 ` Nicolas Richard
2014-03-14 17:42 ` martin rudalics
2014-03-16 10:02 ` martin rudalics
2014-03-16 11:45 ` Nicolas Richard
2014-03-16 13:27 ` João Távora [this message]
2014-03-19 10:50 ` Juanma Barranquero
2014-03-16 10:01 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm50xX9eScKB4qNmOsUH+73yOYMC6k8qwvjB2Qjt6YEvNOw@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=17007@debbugs.gnu.org \
--cc=rudalics@gmx.at \
--cc=theonewiththeevillook@yahoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.