* bug#62764: [PATCH] adds clojure tree-sitter mode
@ 2023-04-10 19:33 Patrick Delaney via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 7:09 ` Yuan Fu
0 siblings, 1 reply; 6+ messages in thread
From: Patrick Delaney via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-04-10 19:33 UTC (permalink / raw)
To: 62764; +Cc: Patrick Delaney
---
eglot.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/eglot.el b/eglot.el
index 6c1b9ea..9b4206e 100644
--- a/eglot.el
+++ b/eglot.el
@@ -242,7 +242,7 @@ chosen (interactively or automatically)."
("css-languageserver" "--stdio"))))
(html-mode . ,(eglot-alternatives '(("vscode-html-language-server" "--stdio") ("html-languageserver" "--stdio"))))
((dockerfile-mode dockerfile-ts-mode) . ("docker-langserver" "--stdio"))
- ((clojure-mode clojurescript-mode clojurec-mode)
+ ((clojure-mode clojure-ts-mode clojurescript-mode clojurec-mode)
. ("clojure-lsp"))
((csharp-mode csharp-ts-mode)
. ,(eglot-alternatives
--
2.40.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* bug#62764: [PATCH] adds clojure tree-sitter mode
2023-04-10 19:33 bug#62764: [PATCH] adds clojure tree-sitter mode Patrick Delaney via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-04-12 7:09 ` Yuan Fu
2023-04-12 7:25 ` João Távora
0 siblings, 1 reply; 6+ messages in thread
From: Yuan Fu @ 2023-04-12 7:09 UTC (permalink / raw)
To: pd; +Cc: 62764, João Távora
Patrick Delaney <pd@patrickdelaney.dev> writes:
> ---
> eglot.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eglot.el b/eglot.el
> index 6c1b9ea..9b4206e 100644
> --- a/eglot.el
> +++ b/eglot.el
> @@ -242,7 +242,7 @@ chosen (interactively or automatically)."
> ("css-languageserver" "--stdio"))))
> (html-mode . ,(eglot-alternatives '(("vscode-html-language-server" "--stdio") ("html-languageserver" "--stdio"))))
> ((dockerfile-mode dockerfile-ts-mode) . ("docker-langserver" "--stdio"))
> - ((clojure-mode clojurescript-mode clojurec-mode)
> + ((clojure-mode clojure-ts-mode clojurescript-mode clojurec-mode)
> . ("clojure-lsp"))
> ((csharp-mode csharp-ts-mode)
> . ,(eglot-alternatives
Let me CC João for you :-)
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#62764: [PATCH] adds clojure tree-sitter mode
2023-04-12 7:09 ` Yuan Fu
@ 2023-04-12 7:25 ` João Távora
2023-04-12 7:39 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: João Távora @ 2023-04-12 7:25 UTC (permalink / raw)
To: Yuan Fu; +Cc: pd, 62764
[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]
On Wed, Apr 12, 2023, 08:09 Yuan Fu <casouri@gmail.com> wrote:
>
> Patrick Delaney <pd@patrickdelaney.dev> writes:
>
> > ---
> > eglot.el | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/eglot.el b/eglot.el
> > index 6c1b9ea..9b4206e 100644
> > --- a/eglot.el
> > +++ b/eglot.el
> > @@ -242,7 +242,7 @@ chosen (interactively or automatically)."
> >
> ("css-languageserver" "--stdio"))))
> > (html-mode . ,(eglot-alternatives
> '(("vscode-html-language-server" "--stdio") ("html-languageserver"
> "--stdio"))))
> > ((dockerfile-mode dockerfile-ts-mode) .
> ("docker-langserver" "--stdio"))
> > - ((clojure-mode clojurescript-mode
> clojurec-mode)
> > + ((clojure-mode clojure-ts-mode
> clojurescript-mode clojurec-mode)
> > . ("clojure-lsp"))
> > ((csharp-mode csharp-ts-mode)
> > . ,(eglot-alternatives
>
> Let me CC João for you :-)
>
I normally let these patches through, but i haven't followed clojure
things, i don't know where this mode exists or where to install: emacs 29
or master. Also it would help to have the patch to the right file and with
a proper commit message.
João
>
[-- Attachment #2: Type: text/html, Size: 2390 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#62764: [PATCH] adds clojure tree-sitter mode
2023-04-12 7:25 ` João Távora
@ 2023-04-12 7:39 ` Eli Zaretskii
2023-04-12 17:23 ` Patrick Delaney via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2023-04-12 7:39 UTC (permalink / raw)
To: João Távora; +Cc: pd, casouri, 62764
> Cc: pd@patrickdelaney.dev, 62764@debbugs.gnu.org
> From: João Távora <joaotavora@gmail.com>
> Date: Wed, 12 Apr 2023 08:25:31 +0100
>
> On Wed, Apr 12, 2023, 08:09 Yuan Fu <casouri@gmail.com> wrote:
>
> Patrick Delaney <pd@patrickdelaney.dev> writes:
>
> > ---
> > eglot.el | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/eglot.el b/eglot.el
> > index 6c1b9ea..9b4206e 100644
> > --- a/eglot.el
> > +++ b/eglot.el
> > @@ -242,7 +242,7 @@ chosen (interactively or automatically)."
> > ("css-languageserver" "--stdio"))))
> > (html-mode . ,(eglot-alternatives '(("vscode-html-language-server" "--stdio")
> ("html-languageserver" "--stdio"))))
> > ((dockerfile-mode dockerfile-ts-mode) . ("docker-langserver" "--stdio"))
> > - ((clojure-mode clojurescript-mode clojurec-mode)
> > + ((clojure-mode clojure-ts-mode clojurescript-mode clojurec-mode)
> > . ("clojure-lsp"))
> > ((csharp-mode csharp-ts-mode)
> > . ,(eglot-alternatives
>
> Let me CC João for you :-)
>
> I normally let these patches through, but i haven't followed clojure things, i don't know where this mode
> exists or where to install: emacs 29 or master. Also it would help to have the patch to the right file and
> with a proper commit message.
This mode is already in eglot.el on master, so no change is needed.
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#62764: [PATCH] adds clojure tree-sitter mode
2023-04-12 7:39 ` Eli Zaretskii
@ 2023-04-12 17:23 ` Patrick Delaney via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 17:28 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Patrick Delaney via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-04-12 17:23 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: casouri, 62764, João Távora
Sorry for the noise, this was based off the master branch on
GitHub which I was told isn't the upstream anymore.
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: pd@patrickdelaney.dev, 62764@debbugs.gnu.org
>> From: João Távora <joaotavora@gmail.com>
>> Date: Wed, 12 Apr 2023 08:25:31 +0100
>>
>> On Wed, Apr 12, 2023, 08:09 Yuan Fu <casouri@gmail.com> wrote:
>>
>> Patrick Delaney <pd@patrickdelaney.dev> writes:
>>
>> > ---
>> > eglot.el | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/eglot.el b/eglot.el
>> > index 6c1b9ea..9b4206e 100644
>> > --- a/eglot.el
>> > +++ b/eglot.el
>> > @@ -242,7 +242,7 @@ chosen (interactively or
>> > automatically)."
>> > ("css-languageserver"
>> > "--stdio"))))
>> > (html-mode
>> > . ,(eglot-alternatives
>> > '(("vscode-html-language-server"
>> > "--stdio")
>> ("html-languageserver" "--stdio"))))
>> > ((dockerfile-mode
>> > dockerfile-ts-mode)
>> > . ("docker-langserver"
>> > "--stdio"))
>> > - ((clojure-mode
>> > clojurescript-mode clojurec-mode)
>> > + ((clojure-mode
>> > clojure-ts-mode clojurescript-mode clojurec-mode)
>> > . ("clojure-lsp"))
>> > ((csharp-mode
>> > csharp-ts-mode)
>> > . ,(eglot-alternatives
>>
>> Let me CC João for you :-)
>>
>> I normally let these patches through, but i haven't followed
>> clojure things, i don't know where this mode
>> exists or where to install: emacs 29 or master. Also it would
>> help to have the patch to the right file and
>> with a proper commit message.
>
> This mode is already in eglot.el on master, so no change is
> needed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-12 17:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-10 19:33 bug#62764: [PATCH] adds clojure tree-sitter mode Patrick Delaney via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 7:09 ` Yuan Fu
2023-04-12 7:25 ` João Távora
2023-04-12 7:39 ` Eli Zaretskii
2023-04-12 17:23 ` Patrick Delaney via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-12 17:28 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.