From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "John Wiegley" <jwiegley@gmail.com>,
emacs-devel@gnu.org, "Mark Oteiza" <mvoteiza@udel.edu>,
"Simen Heggestøyl" <simenheg@gmail.com>,
dgutov@yandex.ru, "Steve Purcell" <steve@sanityinc.com>,
sdl.web@gmail.com
Subject: Re: Flymake refactored
Date: Thu, 5 Oct 2017 15:45:38 +0100 [thread overview]
Message-ID: <CALDnm50v6ELytUKLEnFVb86MP7YJ6X4eQ0Ug2-Rr_BQCqua2zQ@mail.gmail.com> (raw)
In-Reply-To: <jwvy3opn3o3.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]
[sorry if you're getting this twice Stefan, i forgot to cc everyone else]
On Thu, Oct 5, 2017 at 2:11 PM, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
>
> >> :sentinel
> >> (lambda (p _ev)
> > way to do this is to check if 'p' is 'eq' to the buffer-local value of
> > clang-flymake--procress.
>
> While I agree that it should check whether `p` is obsolete (just in case
> something went wrong elsewhere), `p` should have been killed when the
> other process was launched,
I believe the code examples presented here already do that:
>> (when (process-live-p gcc--flymake-proc)
>> (kill-process gcc--flymake-proc))
> so this sentinel should only be called with an obsolete `p` in response
to such a kill.
But while a "killed" 'p' is obsolete, the reverse isn't true. When lauching
B, the
process A might have already have exited cleanly. Hence A it is not live
anymore, and can't be killed. But A's sentinel might not have had a chance
to run yet. When it does run, A's sentinel must notice that it is obsolete
by
some means, and checking for eqness seems the easiest (in flymake-proc.el
I set an 'obsolete' property in the proc).
> BTW, it should also check `ev` in case the event is just that someone
> suspended/resumed the background process.
That is true.
We should come up with a canonic way to launch flymake processes
and then either hide that behind an abstraction or document it.
João
[-- Attachment #2: Type: text/html, Size: 3293 bytes --]
next prev parent reply other threads:[~2017-10-05 14:45 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 14:27 Flymake refactored João Távora
2017-09-28 19:52 ` Stefan Monnier
2017-09-29 0:22 ` João Távora
2017-09-29 3:11 ` Stefan Monnier
2017-10-01 16:52 ` João Távora
2017-10-01 20:50 ` Stefan Monnier
2017-10-02 1:01 ` João Távora
2017-10-02 3:12 ` Stefan Monnier
2017-10-03 0:33 ` João Távora
2017-10-03 1:09 ` Stefan Monnier
2017-09-29 12:51 ` Dmitry Gutov
2017-09-29 14:55 ` Ted Zlatanov
2017-09-29 15:03 ` Dmitry Gutov
2017-09-29 16:26 ` Ted Zlatanov
2017-09-29 17:35 ` Dmitry Gutov
2017-09-29 17:56 ` Ted Zlatanov
2017-09-30 15:07 ` Dmitry Gutov
2017-09-30 7:55 ` Marcin Borkowski
2017-09-30 23:43 ` João Távora
2017-10-01 8:53 ` Marcin Borkowski
2017-10-01 11:54 ` Mark Oteiza
2017-10-04 17:37 ` Simen Heggestøyl
2017-10-05 2:08 ` João Távora
2017-10-05 3:52 ` Mark Oteiza
2017-10-05 10:57 ` João Távora
2017-10-05 13:11 ` Stefan Monnier
2017-10-05 14:45 ` João Távora [this message]
2017-10-05 23:01 ` João Távora
2017-10-05 21:22 ` Mark Oteiza
2017-10-05 23:05 ` João Távora
2017-10-06 3:35 ` Stefan Monnier
2017-10-06 7:09 ` Lele Gaifax
2017-10-06 8:14 ` Eli Zaretskii
2017-10-06 8:19 ` Lele Gaifax
2017-10-06 9:48 ` Eli Zaretskii
2017-10-06 9:54 ` Lele Gaifax
2017-10-06 13:04 ` Mark Oteiza
2017-10-06 14:47 ` Lele Gaifax
2017-10-06 15:21 ` Mark Oteiza
2017-10-06 15:26 ` Mark Oteiza
2017-10-06 15:28 ` Lele Gaifax
2017-10-06 16:28 ` João Távora
2017-10-06 19:24 ` Lele Gaifax
2017-10-06 15:13 ` João Távora
2017-10-07 13:28 ` Stefan Monnier
2017-10-07 13:44 ` Eli Zaretskii
2017-10-07 14:40 ` Lele Gaifax
2017-10-07 14:52 ` Eli Zaretskii
2017-10-08 2:06 ` Stefan Monnier
2017-10-08 9:32 ` João Távora
2017-10-08 11:24 ` Lele Gaifax
2017-10-08 14:17 ` Stefan Monnier
2017-10-08 23:33 ` João Távora
2017-10-09 3:01 ` Stefan Monnier
2017-10-09 10:19 ` João Távora
2017-10-09 15:50 ` [SUSPECTED SPAM] " Stefan Monnier
2017-10-09 16:33 ` [PATCH] " Lele Gaifax
2017-10-07 6:31 ` Marcin Borkowski
2017-10-07 13:37 ` Stefan Monnier
2017-10-07 16:48 ` Marcin Borkowski
2017-10-06 12:54 ` John Wiegley
2017-10-06 15:17 ` Mark Oteiza
2017-10-06 16:04 ` João Távora
2017-10-06 21:22 ` Mark Oteiza
2017-10-06 22:03 ` João Távora
2017-10-07 13:31 ` Stefan Monnier
2017-10-07 16:02 ` João Távora
2017-10-07 16:07 ` João Távora
2017-10-07 18:18 ` Mark Oteiza
2017-10-08 9:06 ` João Távora
2017-10-08 12:51 ` Mark Oteiza
2017-10-08 23:21 ` João Távora
2017-10-10 14:27 ` Mark Oteiza
2017-10-10 15:20 ` João Távora
2017-10-10 16:10 ` Mark Oteiza
2017-10-05 11:28 ` Lele Gaifax
2017-10-05 15:12 ` Lele Gaifax
2017-10-10 10:40 ` Lele Gaifax
2017-10-10 12:27 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm50v6ELytUKLEnFVb86MP7YJ6X4eQ0Ug2-Rr_BQCqua2zQ@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=jwiegley@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=mvoteiza@udel.edu \
--cc=sdl.web@gmail.com \
--cc=simenheg@gmail.com \
--cc=steve@sanityinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.