From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#33870: 27.0.50; xref-goto-xref not configurable Date: Fri, 1 Feb 2019 00:17:41 +0000 Message-ID: References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <878t02egph.fsf@mail.linkov.net> <874lak9kr0.fsf@mail.linkov.net> <87zhscklhq.fsf@gmail.com> <87bm4qel4t.fsf@mail.linkov.net> <67c9abb5-f546-361f-04ca-da96ceaca4e2@yandex.ru> <87bm4le0tm.fsf@mail.linkov.net> <87imys6x5s.fsf@mail.linkov.net> <87d0osjtna.fsf@mail.linkov.net> <8ffaaddb-1d19-b9e9-83f1-83da89445eb8@yandex.ru> <87munmosx4.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="159535"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33870@debbugs.gnu.org, Dmitry Gutov To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 01 01:18:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gpMXA-000fNK-2h for geb-bug-gnu-emacs@m.gmane.org; Fri, 01 Feb 2019 01:18:16 +0100 Original-Received: from localhost ([127.0.0.1]:34845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpMX9-0000PY-2b for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Jan 2019 19:18:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gpMWx-0000Os-AU for bug-gnu-emacs@gnu.org; Thu, 31 Jan 2019 19:18:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gpMWw-0002jh-Fo for bug-gnu-emacs@gnu.org; Thu, 31 Jan 2019 19:18:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54239) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gpMWw-0002jd-CQ for bug-gnu-emacs@gnu.org; Thu, 31 Jan 2019 19:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gpMWv-0006VH-Vc for bug-gnu-emacs@gnu.org; Thu, 31 Jan 2019 19:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Feb 2019 00:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33870 X-GNU-PR-Package: emacs Original-Received: via spool by 33870-submit@debbugs.gnu.org id=B33870.154898028024992 (code B ref 33870); Fri, 01 Feb 2019 00:18:01 +0000 Original-Received: (at 33870) by debbugs.gnu.org; 1 Feb 2019 00:18:00 +0000 Original-Received: from localhost ([127.0.0.1]:53520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpMWu-0006V1-1e for submit@debbugs.gnu.org; Thu, 31 Jan 2019 19:18:00 -0500 Original-Received: from mail-qt1-f193.google.com ([209.85.160.193]:42976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpMWs-0006Uq-Sw for 33870@debbugs.gnu.org; Thu, 31 Jan 2019 19:17:59 -0500 Original-Received: by mail-qt1-f193.google.com with SMTP id d19so5602028qtq.9 for <33870@debbugs.gnu.org>; Thu, 31 Jan 2019 16:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BwQtCJuX5wtmkbwGtQVWQYQfD0HRN2LXLNOCx9tmfvw=; b=JT7qapwuFEMOOdcITjev7SOzHdI8TQ6irZupTuISAkXqP7jtmJKO30nb/2Z8T0wSEj /cvjOuui7tir60daHC2vdxXax2YAi/J05Q7S7GZDgg2UC1gL/MsAqU5rVR3fWLeYbwrH 0BS+P/hQxylCz+eQYgO3I1oSxEIqgfCW5ZLa397YMa2xQql0kH44QMQR+fVBGPNJJEf8 9hdyOUkW4TmRsL4uEwlqmnxw10CUF1G5LgIhSKexibK46NbZ7NXXnyRmTR1814ZsBFqZ 3ltyIVSMjs6GLgQp7+CEp/fUFYskQLZDvCUTkP14ZEGGLNLqqRPCL25+Xse77MA3I+o5 XKLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BwQtCJuX5wtmkbwGtQVWQYQfD0HRN2LXLNOCx9tmfvw=; b=L1sfMA0rljwnsInkyoOf9dc+5U2W7MGgofv4N0eUzosG6ICASvofqEa37mLIrwHUZF J+TpqN9Ru41Dvp+p9CDSX4FgndyYCXr0ue8+/GdFHgywvlpD83sx/mgiEPIdO9ZsooMJ MIBR7DQalsAdcfkgdZU354JIxvMn7rTZRP5pXoiopMw5sJ6PQhgkP3/iMQMAtRxzGAkt 21p8zDty/6WfHXqjzOKkQUn7xkwN3qOkEt/mMCb+ESy0mztNWaZt4ywIf6xuICySe2hJ 1FJWzTs4QVIxgRZ+jD/tOq9ZqoJ+Rqa+XyZp4Ow1r2OOpzIAa4Lle5LWie5gpudN+XKj kizA== X-Gm-Message-State: AJcUukfJOWZnjJfp4hPPb4T3Hf9O6aLlu90cBUbJ5ZNsuj+AjlQJKk+z Ac+hwYV11bIIseB08WHseyeHPlnr15QX5EAIA0E= X-Google-Smtp-Source: ALg8bN4Z8ij/w9MEbqz+AoKIELXRBHAL9Rm1LstjiOlRhuVRoiKhdBSpoSPrBjYSpRZ1+NcaUXfG9BCNGg8tSfWkLto= X-Received: by 2002:ac8:3e91:: with SMTP id y17mr37673084qtf.390.1548980273323; Thu, 31 Jan 2019 16:17:53 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154946 Archived-At: On Thu, Jan 31, 2019 at 10:14 PM Jo=C3=A3o T=C3=A1vora wrote: > > On Sun, Jan 27, 2019 at 8:42 PM Juri Linkov wrote: > > > > >> If only that patch were able to keep the current behavior by default= . > > > Yep. If Juri provides a simpler patch that does this I'm all for it. > > Ok, here's 100% backward-compatible patch: > > Thanks, Juri! > > I know I'm late on this, but I've been very busy. Please give me > some more days to try this out. OK, so I did find time to test this briefly and I found some bugs. However, they are reasonably hard to reproduce consistently. Here's the only bug I can reproduce consistently: emacs -Q C-x 2 C-x 4 . xref-backend-definitions RET C-n TAB Expected the definition to appear in the bottom window, but it goes to the top window instead (the window I used xref-find-definitions-other-window). This is wrong and the current xref.el implementation does not suffer from this bug. However, in all fairness, the current xref.el implementation suffers from other bugs that I had never uncovered: emacs -Q C-x 2 C-x o C-x 4 . xref-backend-definitions RET n This will open a new frame (!) completely unexpectedly, whereas in your version, it works quite correctly. It works fine in both versions if the C-x o is not used. I did not debug any of the problems. So which bugs are "worse"? :-) Assuming you can reproduce it and fix the bug, I would have no more objections, and the patch does indeed simplify the code. Jo=C3=A3o PS: I stress the "assuming you can reproduce it": I could be making a mistake here: I tested with and without your patch on a recent Emacs.