From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58839: [Patch] Re: bug#58839: 29.0.50; project-kill-buffer fails when Eglot is running Date: Fri, 28 Oct 2022 19:30:59 +0100 Message-ID: References: <87sfj8umwb.fsf@posteo.net> <87edur3lil.fsf@posteo.net> <87a65f3j40.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003ee50d05ec1c76a6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32275"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Manuel Uberti , 58839@debbugs.gnu.org, Dmitry Gutov To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 28 20:32:30 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooU9e-0008F5-3M for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Oct 2022 20:32:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooU9K-0002c0-IB; Fri, 28 Oct 2022 14:32:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooU9C-0002b8-E3 for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 14:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooU9C-000488-48 for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 14:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ooU9B-0000lE-Oy for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 14:32:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Oct 2022 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58839 X-GNU-PR-Package: emacs Original-Received: via spool by 58839-submit@debbugs.gnu.org id=B58839.16669818792870 (code B ref 58839); Fri, 28 Oct 2022 18:32:01 +0000 Original-Received: (at 58839) by debbugs.gnu.org; 28 Oct 2022 18:31:19 +0000 Original-Received: from localhost ([127.0.0.1]:34274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooU8U-0000kD-Tu for submit@debbugs.gnu.org; Fri, 28 Oct 2022 14:31:19 -0400 Original-Received: from mail-oa1-f53.google.com ([209.85.160.53]:46048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooU8S-0000k0-7y for 58839@debbugs.gnu.org; Fri, 28 Oct 2022 14:31:18 -0400 Original-Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-13be3ef361dso7178140fac.12 for <58839@debbugs.gnu.org>; Fri, 28 Oct 2022 11:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dsdCkw3+Y9upUNKOyKq4YiYwt11xbrecoFyaugno7fg=; b=TS1hxPnHEaPsBD+uWTEbCv+EVYcbzbUUYIXjva+elxuX03ELMXZPOJ/k0qAsk8FIm/ tQx67BDo9qEZf8OerQTRZMcYrBRe+Vd9n3xkVjWIrEECy+LzquHmc4BVPZbZUXWMKMi9 vzjzHnh15Rj/HPQRqu1xWnhvjSLkm+AidYB0DFbQQXFcfzi58j3R5kWx9DUfbODpu5fL V1hQ1vaZ6JB/GYRHqRPsoyMPf2hhYxguQqf3WkskWeuFtzNoMKu1GDc/IM9B9ciOF96e xN6fqzLArTepFs0SJAGR5f7qcSZ6AY+Z8OPQV4UVnQ+ANTOMAOCcSRuE57/SwG2KOG34 RrjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dsdCkw3+Y9upUNKOyKq4YiYwt11xbrecoFyaugno7fg=; b=6J8IYdy6t9h5puWL3s5Y53KXaFZr9Waq/Zk3/2TtwQGUtRCdCTrdlWVW7NHmjp3nOG qs1+VZ6wDTsNnt/F9BzzCO5YKydCsgDf4NBKryavxkUpFcJS/vmU/lGvpmlRHmBtRKlq I/QljsRjyrxMkQpvCd6XDcy4D+I0jgHxAQgLjNGtr0VsfMfYMz9zE5f9SO6JHgYcYzcE 7d8iWythc0uD2b4tJq0e7qidF8uH+T4dQyBCwdcBSLpZHbx125JWbwDEt2q96k5Ii+a/ BXNojsMEd1VpvgalXUkgl154mz6NOKo6/B5vWzOk4u2lwymAYr/TdlC89wnBvijvpVj3 ReOQ== X-Gm-Message-State: ACrzQf1Bb9mlRu18k/uqp3slOPJb1cIYt1n6wq8PHiQwpGD2KOZhcIJ2 HEOOrCaPLdhCEqevoR0jIGFIQ+d5XXTvtcSzik4= X-Google-Smtp-Source: AMsMyM77PZzRRms58T/8T0GoU1C/QWSN2cYjtbCV9RbbRpJ8GWK/M80SH4AEWiY4CCsx6Q/Q82/PNG44LhWOL+AZxRA= X-Received: by 2002:a05:6870:2155:b0:13c:8db1:2446 with SMTP id g21-20020a056870215500b0013c8db12446mr1524113oae.171.1666981870623; Fri, 28 Oct 2022 11:31:10 -0700 (PDT) In-Reply-To: <87a65f3j40.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246446 Archived-At: --0000000000003ee50d05ec1c76a6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2022, 19:20 Philip Kaludercic wrote: > Dmitry Gutov writes: > > > On 28.10.2022 20:28, Philip Kaludercic wrote: > >> I still don't agree that this is the right interpretation of the issue > >> or solution, but wouldn't it be better to add this to > >> `project-kill-buffer-conditions'? > > > > I don't mind a new variable specifically, but > > kill-buffer-query-functions seems to serve this purpose just fine. > > > > And no extra "coupling between two packages" will be added. > > How would you imagine it being used in this case? May I suggest that we jump over the imagination directly to the reality? The patch provided lives in the latter realm. Jo=C3=A3o > --0000000000003ee50d05ec1c76a6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Oct 28, 2022, 19:20 Philip Kaludercic <philipk@posteo.net> wrote:
Dmitry Gutov <dgutov@yandex.ru> writes:

> On 28.10.2022 20:28, Philip Kaludercic wrote:
>> I still don't agree that this is the right interpretation of t= he issue
>> or solution, but wouldn't it be better to add this to
>> `project-kill-buffer-conditions'?
>
> I don't mind a new variable specifically, but
> kill-buffer-query-functions seems to serve this purpose just fine.
>
> And no extra "coupling between two packages" will be added.<= br>
How would you imagine it being used in this case?=C2=A0
<= /div>

May I = suggest that we jump over the imagination directly to the reality?=C2=A0

The patch provided lives i= n the latter realm.

Jo= =C3=A3o


--0000000000003ee50d05ec1c76a6--