From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Date: Fri, 18 Dec 2020 15:26:26 +0000 Message-ID: References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> <05dcfc56-ae5b-7943-4139-80c8b996e968@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9211"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Glenn Morris , 29193@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 18 16:40:28 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqHrn-0002IG-O0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 16:40:27 +0100 Original-Received: from localhost ([::1]:59098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqHrm-0000xQ-OE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 10:40:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqHep-00030s-Tg for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:27:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56338) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqHeo-0001pq-4M for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqHeo-0004YO-0J for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Dec 2020 15:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29193 X-GNU-PR-Package: emacs Original-Received: via spool by 29193-submit@debbugs.gnu.org id=B29193.160830520517481 (code B ref 29193); Fri, 18 Dec 2020 15:27:01 +0000 Original-Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 15:26:45 +0000 Original-Received: from localhost ([127.0.0.1]:39651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHeX-0004Xs-4v for submit@debbugs.gnu.org; Fri, 18 Dec 2020 10:26:45 -0500 Original-Received: from mail-il1-f170.google.com ([209.85.166.170]:35630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHeV-0004Xf-CA for 29193@debbugs.gnu.org; Fri, 18 Dec 2020 10:26:43 -0500 Original-Received: by mail-il1-f170.google.com with SMTP id t9so2483052ilf.2 for <29193@debbugs.gnu.org>; Fri, 18 Dec 2020 07:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=telQXT8uWTTl+vj0rG8UZuLnXGwq0NLsJ7cKUwLChm0=; b=V53/7odS4ljusNrmtmMMVfzlTqk5Y2gyXPMVtHD5bH8Y/d/+dzAVwKvO4I04TFY5IO bjKUWTdKZuhL7S1kTID4Ax3rhwPjhgdTJ2G4sZGdHNx9JS24/RC6BpAgKnj/9I1QBNIi Id7DAX1go/z6xIhBLk4lo5Gc3uUGWs1UJoW6hpA+LsDa6GVLkG+ZAp7KVX2T1RjrVUtQ BqK8yMrYdfeVqU8/oycUHjS3xBfYY0vM6OFmdH1VvTOVlDM2uH9rXXtvz4eon3UFn/z+ bWrCix6nNq011IEXNSIyAmH838jnEhywTIRzdG67QO8Ia6UEsOo6vR4Th5R8HfMawXOE 5sDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=telQXT8uWTTl+vj0rG8UZuLnXGwq0NLsJ7cKUwLChm0=; b=tnfy9fwn8bp2jms25EjmEt/+dUEWOcCtxKbOJi/uys+cJIUIqr6IG5D/HNhOlPeJ73 1h/5JMxXJIktAHSwpw35iP2SHJyEGRo5oE0uYGRODZLPV5Yl9SMbsOuKPEQLOBlbNerP uHOQL24ceSNHhNvJt+DMlUUJnapYCvmGeiRQTruuMaQpOca8ztNl4DhZkfXETfYFiT1u PhbE6Teb+eB+TaTl2fgeatQfFr6ui0/qk4Im0/rwpYZuF83vWTFRRmHKxY7nnjHPvhoK KrtXESBGIbj7i1oM5YRshGE7JV/gizypVfU3aFVv3LuwxZ9b4ZUYk3iG6PJ5L7JG2HP4 PPLw== X-Gm-Message-State: AOAM530BDsqO8aZ5o4Lplk5FHMLsnXBNtsG1WGk0rWcYoHyS2XqeTnMn kHQYvbWrifWxBgdCOGMkHQz1YPPbP9JgX5WPLHM= X-Google-Smtp-Source: ABdhPJy7C5Rx0uNNoPnQeQ+WIaM3FCuRzjXFT7wkgDbNUPPoaPUKf5xA+95+yUJdaaARi5FVa6M6HTt6P2IYZ3lWBcM= X-Received: by 2002:a92:c682:: with SMTP id o2mr4353434ilg.97.1608305197632; Fri, 18 Dec 2020 07:26:37 -0800 (PST) In-Reply-To: <05dcfc56-ae5b-7943-4139-80c8b996e968@yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196329 Archived-At: On Fri, Dec 18, 2020 at 3:22 PM Dmitry Gutov wrote: > > On 18.12.2020 13:42, Jo=C3=A3o T=C3=A1vora wrote: > > > I think this is rather a thingatpt.el issue, which makes no mention of > > match-data destruction. Regardless, it's decent enough to do that in > > flymake-diag-region so I pushed save-match-data a bit higher. > > By default we assume that any function can destroy match-data (and only > a certain set doesn't). By that reasoning the problem should be solved in whoever called flymake-diag-region and wrongly assumed it would keep match data. Doesn't a seem very friendly API tho (and no idea who it was, anyway).