From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Thu, 5 Mar 2020 08:01:40 +0000 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000018bf1105a016f3d2" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="27933"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 09:02:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9lSV-0007A8-2O for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 09:02:19 +0100 Original-Received: from localhost ([::1]:44594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9lST-00047D-MZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 03:02:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42600) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9lSF-00046n-IM for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 03:02:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9lSE-0003Y3-AF for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 03:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36153) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9lSE-0003XR-5e for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 03:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9lSE-0001X4-2V for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 03:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 08:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15833953195882 (code B ref 38992); Thu, 05 Mar 2020 08:02:01 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 08:01:59 +0000 Original-Received: from localhost ([127.0.0.1]:42126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9lSA-0001Wn-GJ for submit@debbugs.gnu.org; Thu, 05 Mar 2020 03:01:58 -0500 Original-Received: from mail-il1-f179.google.com ([209.85.166.179]:33597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9lS9-0001WZ-Er for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 03:01:57 -0500 Original-Received: by mail-il1-f179.google.com with SMTP id r4so4261395iln.0 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 00:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9fgShIBi+Mt+QXYFRQLL+kt+YhcXyhIMkeQL4AYoR8A=; b=dQ9xy8hV5PTtbOMCUs5KH2xEoC9oxUyiQ3yzba6XxYEztVR6xlh81LEVnPAkhd6tj/ XM++rVq75sjnWZLm7p9666/XBeEvwMAKobJHLK7j44cY5ZEuGj2Ab5JBdDsomj238goF Yh5+ZvBItR2psPZhMQeH26kZxhXu1tNCstOfsUpeECT4Kp6wJ1k2prqJElD5brgi37t5 RzTHwsAxRxhiAgCup6YRmi/VG1y7gpsKi6d/iYfNW75XccgWc4hBnWTwB3fIHMU4xQzW GPmV9JRqfIH10jTqleLlYRnlTAsskpOAtKxFjjjBilp5Q0qXWtA3L6wpGJy7tr33+2S5 OyWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9fgShIBi+Mt+QXYFRQLL+kt+YhcXyhIMkeQL4AYoR8A=; b=nv6PX4djJJpJoR7+4YXD20MB0vhEt1QXgeEEcXx7ryA08pCAgVliuLNGW2jNUy8HVs Z6SAs6HtGEJaaDcQj85qf8zj+Y4BosDddoVIYLFb1Zl0ZIf1hzJiqLNWjh8D/lUUtszS YxS3Z74v6DmbBiN5AiISkXg7K/E8encfZqmOJa7gyc1SD05fMGXtLm132OaU0hE0nLCe db1pkxJTDK9LVBP4BLNTEsu16MgvJ6kcITiv0FIEDVGFVcvEQ0zVadjZ8e0HqUkvMz4n T3PbDnWdbgQ9RrqjelTxUURYsv6LIEHaeCENt/ecbP9HQgg31i61Yy7W4kYiGRS6yTUC P8yg== X-Gm-Message-State: ANhLgQ0suIqA2UR/buwwK85r4cMtPYaEsN0xZ5eWiH966WzOTCablIDC e68EMg51oHCDWohTzBTeEl+8IdF6Vor6AvJvG5Y= X-Google-Smtp-Source: ADFU+vuQMB4I1EQbc5w+E+kUR1RcerlJczj7AbH2X5vlwWsFn31BpVve5tUwrRERjhLfYGz5OZxw3ZzAyTr4VtfK8jM= X-Received: by 2002:a92:884e:: with SMTP id h75mr6857829ild.199.1583395311761; Thu, 05 Mar 2020 00:01:51 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176885 Archived-At: --00000000000018bf1105a016f3d2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 5, 2020 at 12:01 AM Dmitry Gutov wrote: > > On 05.03.2020 0:44, Jo=C3=A3o T=C3=A1vora wrote: > > fido-mode doesn't change icomplete-mode. It shouldn't, at least. > > It just uses it as a library. And surely if it's a bug in fido-mode, > > surely it needs fixing _there_ and not elsewhere. But it seems > > not be the case (at least with your latest proposal), so you have > > me confused. > > Since the problem isn't triggered by icomplete-mode, but is triggered by > fido-mode, it seems the latter binds some commands that are not a great > fit for it. Sure fido-mode binds commands that it needs to bind for it to be useful, the choice for M-j was the closest thing available at the time. If you've made a better one since, that's great. > ido-mode users, however, like to use RET for arbitrary inputs as well. Let's first _not_ change the current fido-mode UI ok? At least for now. Later (even before Emacs 27) could be fine. > The previous patches are attached to the older message. Not too hard to > find on the debbugs bug page. I'm just looking for the patch to minibuffer.el that I remember you saying you were preparing. (I'm sorry, but I don't have time right now to find it in this very poor Gmail UI). I've pulled from your branch in Git and yours patches look fine, but really I don't understand the minibuffer one anymore at this kind of distance. But it it's the one we talked about when I did understand it, I'm all for it. > If I were to classify, the first one fixes a "UI deficiency", but the > second one fixes a bug. Don't know which is which, but classifiers will classify :-) > I've pushed the updated (more limited) patches to the 'fido-mode-fix' > branch. Yes, thanks! Jo=C3=A3o --00000000000018bf1105a016f3d2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 5, 2020 at 12:01 AM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
>= ; On 05.03.2020 0:44, Jo=C3=A3o T=C3=A1vora wrote:
> > fido-mode d= oesn't change icomplete-mode. It shouldn't, at least.
> > = It just uses it as a library.=C2=A0 And surely if it's a bug in fido-mo= de,
> > surely it needs fixing _there_ =C2=A0and not elsewhere.=C2= =A0 But it seems
> > not be the case (at least with your latest pr= oposal), so you have
> > me confused.
>
> Since the pr= oblem isn't triggered by icomplete-mode, but is triggered by
> fi= do-mode, it seems the latter binds some commands that are not a great
> fit for it.

Sure fido-mode binds commands that = it needs to bind for it
to be useful, the choice for M-j was = the closest thing available at
the time. If you've made a bet= ter one since, that's great.

>=C2=A0 ido-mod= e users, however, like to use RET for arbitrary inputs as well.

Let's first _not_ change the current fido-mode UI ok? At least<= /div>
for now.=C2=A0 Later (even before Emacs 27) could be fine.
<= div>
> The previous patches are attached to the older mess= age. Not too hard to
> find on the debbugs bug page.

I'm just looking for the patch to minibuffer.el that I remembe= r you
saying you were preparing. (I'm sorry, but I don't= have time right now to
find it in this very poor Gmail UI).=C2= =A0 I've pulled from your branch in Git
and yours patches loo= k fine, but really I don't understand the minibuffer
one anym= ore at this kind of distance.=C2=A0 But it it's the one we talked about=
when I did understand it, I'm all for it.

> = If I were to classify, the first one fixes a "UI deficiency", but= the
> second one fixes a bug.

Don'= t know which is which, but classifiers will classify :-)

> = I've pushed the updated (more limited) patches to the 'fido-mode-fi= x'
> branch.

Yes, thanks!
=

Jo=C3=A3o
--00000000000018bf1105a016f3d2--