From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62417: ; Regression: 59ecf25fc860 is the first bad commit Date: Mon, 27 Mar 2023 16:42:05 +0000 Message-ID: References: <87sfducmrc.fsf@gmail.com> <87o7oicgy4.fsf@gmail.com> <87wn365e3t.fsf@posteo.net> <87pm8yaq24.fsf_-_@gmail.com> <83fs9tc7o9.fsf@gnu.org> <83cz4xc6hg.fsf@gnu.org> <83zg80c40u.fsf@gnu.org> <87a5zzuutl.fsf@gmail.com> <83h6u79bjl.fsf@gnu.org> <875yamv1ox.fsf@gmail.com> <838rfi9udc.fsf@gnu.org> <83zg7y8blb.fsf@gnu.org> <83v8im887i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30020"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, 62417@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 27 18:41:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgpuQ-0007Ws-CZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Mar 2023 18:41:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgpuC-0001cF-F9; Mon, 27 Mar 2023 12:41:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgpu5-0001Y4-AF for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 12:41:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgpu3-0005EE-EV for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 12:41:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgpu2-0004KU-EW for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 12:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 16:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62417 X-GNU-PR-Package: emacs Original-Received: via spool by 62417-submit@debbugs.gnu.org id=B62417.167993522116577 (code B ref 62417); Mon, 27 Mar 2023 16:41:02 +0000 Original-Received: (at 62417) by debbugs.gnu.org; 27 Mar 2023 16:40:21 +0000 Original-Received: from localhost ([127.0.0.1]:48311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgptN-0004JG-7I for submit@debbugs.gnu.org; Mon, 27 Mar 2023 12:40:21 -0400 Original-Received: from mail-ot1-f53.google.com ([209.85.210.53]:34361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgptL-0004Iy-23 for 62417@debbugs.gnu.org; Mon, 27 Mar 2023 12:40:19 -0400 Original-Received: by mail-ot1-f53.google.com with SMTP id 61-20020a9d02c3000000b0069fe8de3139so4875294otl.1 for <62417@debbugs.gnu.org>; Mon, 27 Mar 2023 09:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679935213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FUkIMnwofgmXtnnjygr6R4tdm+fafme4XBTR+KjLuwQ=; b=HfLR63vGlSk1g9Gi/zzCo56XqDRRJv63NPX6QMyPyY57pQD4XAbuUBUWprNai45jhk 2NdOAowIIT3DzJaaoY33UvP1InjHt/PFJ+f1xTuehcE611Vj30FDV+FdtfdkTIhT5qN2 xL+KvAJqQveZYhTKh0W5FKE3JNnN6aJTJuQCvVJU/lKNaD0FI5DouA+c3OxrEx9VjqSG L4hDj+DMF7D5kjlIL1jepXmucK9XABqrZXeJdkevdWBPAS88kpgCCKYTyJa5Y4Zy1SPA wyyJsdWBwlEg5niG9as1G0ffjxmJUQ6dPkxyuLt+Wa3zvaOSCQ8LzrY9WEYtUlTzw5MO /6tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679935213; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FUkIMnwofgmXtnnjygr6R4tdm+fafme4XBTR+KjLuwQ=; b=09o9J6+me4F0/1A03NvFjYKR2t8r9tzkf0GZpvrcL1lPkFRPb8uDf5zKC17DaT/6A3 BrBHqIt9nYOn2X6M97VaOSWsWEPIFe9ZQGRLyfa8txGo9E1YdZJc8JCXeofxDOalQpH/ fBXGNPviAAhclHOTC31N4HXYnll56ikM7Milr6u88qaG/r/skTMzy5K3utRwWkfhPj2K lbk6j3cj1jIEQzD4WaGVcXEE9u4Ukft+faSHsWJiH8CqmutnqpMsUw9i15QGofqUlWiV z2NGXG1QNti//lU/GouLtYhO9uWPRieh/QyGoTxrnnBLSoy4RfgThQ5c9LSVhT5qFFsM 8Sug== X-Gm-Message-State: AO0yUKUStm2G2bBcWCoLz6BZgbxFTAmch6bXV672I4Ifx8jGWdCQtEXC 1aivDOcf0ukM4vear1znRsMKd13tlEILW1m9ZTg= X-Google-Smtp-Source: AK7set/HMAcj0ykoijxbU8eaZXMZ02nTPunDKXEjvr2w/HUjQTilO4oZBwmR5H+jLaXSNjgPjWiFYa+boDhyMKxxUi0= X-Received: by 2002:a9d:7ac4:0:b0:697:bd4c:1574 with SMTP id m4-20020a9d7ac4000000b00697bd4c1574mr4237613otn.4.1679935213442; Mon, 27 Mar 2023 09:40:13 -0700 (PDT) In-Reply-To: <83v8im887i.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258759 Archived-At: On Mon, Mar 27, 2023 at 5:33=E2=80=AFPM Eli Zaretskii wrote: > > > Cc: philipk@posteo.net, 62417@debbugs.gnu.org > > Date: Mon, 27 Mar 2023 18:20:48 +0300 > > From: Eli Zaretskii > > > > > From: Jo=C3=A3o T=C3=A1vora > > > Date: Mon, 27 Mar 2023 14:08:17 +0000 > > > Cc: philipk@posteo.net, 62417@debbugs.gnu.org > > > > > > > since buffer-match-p accepts > > > > both buffers and their names. Please explain. > > > > > > In the patch I showed, which you and Philip approved, the docstring o= f > > > the variable display-buffer-alist was clarified to state that it is a= buffer > > > name string, and _not_ a buffer object, that is passed to buffer-matc= h-p. > > > This is absolutely necessary, and we've already been through this. > > > > I don't understand why this is necessary, and I didn't intend to limit > > buffer-match-p to accepting only buffer names. Please explain why is > > it necessary. > > > > What I did say was that _if_ buffer-match-p will be able to accept > > _both_ buffer names and objects _and_ will pass to the function > > exactly the argument it was passed, i.e. either a buffer object or a > > name of a buffer, _then_ the backward-incompatibility will be solved. > > > > The responsibility of making sure buffer-match-p accepts a name when > > the function expects only names is _on_the_caller_. And the caller is > > NOT display-buffer, it's the Lisp code which calls display-buffer or > > which prepares the alist that will be passed to display-buffer. > > To make a long story short: here's how the call to > display-buffer-assq-regexp looked like in Emacs 28: > > (let* ((user-action > (display-buffer-assq-regexp > (buffer-name buffer) display-buffer-alist action)) > > And here's how it looks like in Emacs 29: > > (let* ((user-action > (display-buffer-assq-regexp > buffer display-buffer-alist action)) > > Your change modified display-buffer-assq-regexp to pass to > buffer-match-p the name of the buffer if display-buffer-assq-regexp > was called with a buffer object. This is not TRT, since, among other > issues, it changes the API of display-buffer-assq-regexp, which is a > public function. Is it? Not documented in the manual. Looked a lot like bog-standard generic data-accessing implementation detail to me, and I can't see any advantage of using it directly. But don't let that stop you from doing this change, which, if it works (I've given a super simple recipe to check), is 120% percent fine by me. Jo=C3=A3o