From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Algorithm in electric-pair--unbalanced-strings-p unsuitable for CC Mode Date: Wed, 3 Jul 2019 14:35:12 +0100 Message-ID: References: <20190702131632.GA30597@ACM> <20190702160410.GB30597@ACM> <20190702182811.GC30597@ACM> <20190703105804.GA11238@ACM> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000edf7ab058cc6ee5f" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="212431"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Alan Mackenzie , emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 03 15:44:01 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hifYG-000spI-QS for ged-emacs-devel@m.gmane.org; Wed, 03 Jul 2019 15:44:00 +0200 Original-Received: from localhost ([::1]:36090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hifQW-0005ia-32 for ged-emacs-devel@m.gmane.org; Wed, 03 Jul 2019 09:36:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42767) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hifQ1-00050V-Ib for emacs-devel@gnu.org; Wed, 03 Jul 2019 09:35:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hifQ0-0000ls-6D for emacs-devel@gnu.org; Wed, 03 Jul 2019 09:35:29 -0400 Original-Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]:40383) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hifPz-0000gu-WA for emacs-devel@gnu.org; Wed, 03 Jul 2019 09:35:28 -0400 Original-Received: by mail-io1-xd2e.google.com with SMTP id n5so4780540ioc.7 for ; Wed, 03 Jul 2019 06:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+k5gOg6DwuVbzA1FoTokfYkSgZzOkh/SeolwxR2CMhc=; b=BH3NVdu5aYTIdo0cZv8cSKwo2qfGJvXJiokW3Cqd37ydV0iCsv6Ajgf9f/xgObikH9 RTTrXOy83fp5ZrPmXMulSW36TysOSRKzL063Gz66GjU/7232PTnrJ6SV+rsXiG0M4vWm cPqV7CF23sof9cQYFkH10YqNhM8P1YT0+Vv172njZ/k+GIfhRnlhnU+R3X1iZbN8J0JS LuVK2F2niU8IV54K7r4J31/dq5qc+SfgmRLSFD7OK1v3yY+oofQywrmx4ib+taHTwSDn 2QmfTIuP9SCqjrYdbZCOpFfRXhiTjMDFUUQo9GhE6H9fMAnFwlXWRHhTmmwnX+xbi/Wv tN8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+k5gOg6DwuVbzA1FoTokfYkSgZzOkh/SeolwxR2CMhc=; b=PndXhk0u+ZDr6eBBOo8isASl8on77FeNFOrExl25wX5gSUGCBpRqFq55CF6oHLo11j /H8hUcAE3RLnWCW0nzuGDEwiZIShagrZTvoRARCHcPVOAnEKeSw1/b96ueiihUMXRC4R pIY+aPcd5IpT3iLJy6YM5Bc+jfUZrOcXg6Xdw+jN1PsduGEIREHU7VJH+4ULFdWHHcmw a8fp/dSJllj+n85U7itkgUw+e87n8LQOvIwmnsd5JRCsF+r8H/bvE0ZKGNWO053Y9Xzs adElEJjXq3IokijYNjK4QyAdQ6HJb9Y9WfQNxA2sobnyxnKRD8QeDb1TKqoJjnvOGTHs mYjg== X-Gm-Message-State: APjAAAVFNrK07dL15P39njiEY4X1ewpToM6IiHCXnrAOMP99qE3aSW4L VMX5OtqvoMmKJ1zXw/E3RYM8BBL2LDQLLyBnpL4= X-Google-Smtp-Source: APXvYqx19xtKdSHBPku5zkqExrKnYfZEupAPSn+Zs9SrQXpJu3GJvab5RbBDd8+y36eHx2dDJrJZIejlkiZa5whk26w= X-Received: by 2002:a5e:8518:: with SMTP id i24mr12192192ioj.149.1562160923538; Wed, 03 Jul 2019 06:35:23 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d2e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238325 Archived-At: --000000000000edf7ab058cc6ee5f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 3, 2019 at 2:08 PM Dmitry Gutov wrote: > On 03.07.2019 13:58, Alan Mackenzie wrote: > >> But only in Emacs 27/cc-mode, probably starting from fe06f64b (that's > >> a git commit hash). > > I'm fully aware it's a git commit hash. Funnily enough, I don't > > memorise such hashes, so if you wish to draw my attention to some > > commit, please have the decency to give me its date, and the summary > > line of its commit message, instead of expecting me to do your work to > > make your point. > > The rest of the discussion aside, IMO it's a very strange reply. Though > I might be biased, given that a lot of my software-related discussions > are on platforms that linkify commit hashes. > > Even so, is calling 'git show fe06f64b' too hard to do? > > I would print its output on this occasion here, but in this case Git > says it's 'ambiguous'. So maybe Joao should elaborate. > I'm sorry it's fe06f643b2808b198bb58bda04a8c863e55a2a56, the 3 got lost in translation. BTW I believe this is the commit that broke things, but it might have been around this time. commit fe06f643b2808b198bb58bda04a8c863e55a2a56 Author: Alan Mackenzie Date: Fri Jun 8 16:42:18 2018 +0000 CC Mode: Fontify unbalanced quotes in unconstrained multiline strings, etc. ("Unconstrained" meaning that every string is multiline, without needing such special marking as used by Pike Mode.) * lisp/progmodes/cc-mode.el (c-pps-to-string-delim): Don't process the char before BOB. (c-multiline-string-check-final-quote): New function. (c-bc-changed-stringiness): New variable. (c-before-change-check-unbalanced-strings): Add handling for unconstrained multiline strings. (c-after-change-re-mark-unbalanced-strings): Add handling for unconstrained multiline strings. Handle escaped double quotes more accurately. --=20 Jo=C3=A3o T=C3=A1vora --000000000000edf7ab058cc6ee5f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Wed, Jul 3, 2019 at 2:08 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
On 03.07.2019 13:58, Alan Mackenzie wro= te:
>> But only in Emacs 27/cc-mode, probably starting from fe06f64b (tha= t's
>> a git commit hash).
> I'm fully aware it's a git commit hash.=C2=A0 Funnily enough, = I don't
> memorise such hashes, so if you wish to draw my attention to some
> commit, please have the decency to give me its date, and the summary > line of its commit message, instead of expecting me to do your work to=
> make your point.

The rest of the discussion aside, IMO it's a very strange reply. Though=
I might be biased, given that a lot of my software-related discussions
are on platforms that linkify commit hashes.

Even so, is calling 'git show fe06f64b' too hard to do?

I would print its output on this occasion here, but in this case Git
says it's 'ambiguous'. So maybe Joao should elaborate.

I'm sorry it's fe06f643b2808b198bb58bda= 04a8c863e55a2a56, the
3 got lost in translation.
<= br>
BTW I believe this is the commit that broke things, but it mi= ght have been
around this time.

commit f= e06f643b2808b198bb58bda04a8c863e55a2a56
Author: Alan Mackenzie <acm@muc.de>
Date: =C2=A0 Fri Jun 8 16:42= :18 2018 +0000

=C2=A0 =C2=A0 CC Mode: Fontify unbalanced quotes in u= nconstrained multiline strings, etc.
=C2=A0 =C2=A0
=C2=A0 =C2=A0 (&q= uot;Unconstrained" meaning that every string is multiline, without nee= ding such
=C2=A0 =C2=A0 special marking as used by Pike Mode.)
=C2=A0= =C2=A0
=C2=A0 =C2=A0 * lisp/progmodes/cc-mode.el (c-pps-to-string-deli= m): Don't process the char
=C2=A0 =C2=A0 before BOB.
=C2=A0 =C2= =A0 (c-multiline-string-check-final-quote): New function.
=C2=A0 =C2=A0 = (c-bc-changed-stringiness): New variable.
=C2=A0 =C2=A0 (c-before-change= -check-unbalanced-strings): Add handling for unconstrained
=C2=A0 =C2=A0= multiline strings.
=C2=A0 =C2=A0 (c-after-change-re-mark-unbalanced-str= ings): Add handling for unconstrained
=C2=A0 =C2=A0 multiline strings.= =C2=A0 Handle escaped double quotes more accurately.





--
Jo=C3=A3o T=C3=A1vora
--000000000000edf7ab058cc6ee5f--