From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#71504: 30.0.50; FR: Fix suggestions ("quick fix") for Flymake diagnostics Date: Wed, 24 Jul 2024 18:44:28 +0100 Message-ID: References: <865xtu7seh.fsf@gnu.org> <868qyf5587.fsf@gnu.org> <868qyd32ih.fsf@gnu.org> <861q452s5f.fsf@gnu.org> <86frsgmpe1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="597"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Eshel Yaron , 71504@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 24 19:46:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWg48-000AYy-1o for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jul 2024 19:46:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWg3u-0007pN-04; Wed, 24 Jul 2024 13:46:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWg3o-0007p1-SF for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 13:45:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWg3o-0002at-GS for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 13:45:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWg3u-0006RJ-Bg for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 13:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2024 17:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71504 X-GNU-PR-Package: emacs Original-Received: via spool by 71504-submit@debbugs.gnu.org id=B71504.172184314824733 (code B ref 71504); Wed, 24 Jul 2024 17:46:02 +0000 Original-Received: (at 71504) by debbugs.gnu.org; 24 Jul 2024 17:45:48 +0000 Original-Received: from localhost ([127.0.0.1]:34439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWg3g-0006Qr-Ci for submit@debbugs.gnu.org; Wed, 24 Jul 2024 13:45:48 -0400 Original-Received: from mail-ot1-f47.google.com ([209.85.210.47]:48616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWg3d-0006Qi-In for 71504@debbugs.gnu.org; Wed, 24 Jul 2024 13:45:46 -0400 Original-Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-703631c4930so3639987a34.1 for <71504@debbugs.gnu.org>; Wed, 24 Jul 2024 10:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721843078; x=1722447878; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gPMUm1uUYQHCCfx2cjwPG7cXXjT7s9CUKzrH/SIZXQY=; b=YcOksusKwF6u/tY+r0CCs5MkFuiT1mw9pDuQDb8Vyh+eyjwt6ydRYcClXVkDk6sTg2 gt4Sxkl6pddRX14m0JaJpcPOFeQWoFTn+xT3DpYQ6TEq0n5d9HebRri6YvX8SQ/FbcFC JJ/NiUgAJMpmub9NcJ5nOX8rBVcvybv+sH8hpYEz/8MUPhRv/0lX/9R1uqvxmawpe+Ae w52ydUfeOukSnRvMKFftn0c0942duHd5U6Jn/3haGdyD1p1MRZxcjg5SbTxCQX9vT5Qv 1TfKFqgMjTrnm5PnuE/Qxo+6GqAkJkI3da1xV9MAmG7Olvyjk9EoBK25K77Nc86wwNQe Xnig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721843078; x=1722447878; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gPMUm1uUYQHCCfx2cjwPG7cXXjT7s9CUKzrH/SIZXQY=; b=As7r3ryyRGERmGHJJX90EzA2ZRSR9BzbzzE40nIOolfOzFBZaV3H9vI3ca6xaUQTx7 qzGNU6lpE79Id7WKMIgO51s47Sk1FK2st2zW4PXn2VLhaR3s7Nn3aQHHtbcaXYtVaARx 6cT6X4z4AyyI00TognOTapDoXFS/3iDmcjiNQuVogaKtLvQvU3ky6+qEZdUpfwgnVe8X F+L0mpTZ8Ys+0Ye6RcKqJPock5xXapBkyfbyaGSRXPdjcydOgPbLJqEbU/CXx+Z5bWBr m14Mb2yAh5wJcTRZhl5iRmkCgT15I79TuOeMrAemSUNazuZG8HFfWR+vWD7lmORwSYCw oWsw== X-Forwarded-Encrypted: i=1; AJvYcCWNNlqm0qS3BsFJb21Kw4CDZ4jf1CX3qMl6uXakPW0eQ+YHbyHlp2XsYNazAssvdmG4QrR3HTNgBqPb9Nwzxm9DrEmOC/Y= X-Gm-Message-State: AOJu0Yzz3rWN1f+9Nq+27XqiTChnreJ/vcFd+OBWNC67rmPlZz+/Ijlm 3kFgUhbgJBxtdnNEs+7eG7VoqmBVh4ZdksymT9CMbZke1jQvLU4F/nDlWENUFzlmKUYaLJnK+H3 UDrP1xYpoEVjR65ooX8EXXoNWpI8= X-Google-Smtp-Source: AGHT+IFK4KzsuK08zllPu0fQQiscPj4Ej6XHTzwIzCXoyK+wbhzK81dfKTJ/RQyxtP4gB95Z/AgYVCK4CK5OveOX0a8= X-Received: by 2002:a05:6870:212:b0:261:236c:2bc1 with SMTP id 586e51a60fabf-264a0d6cc7bmr332277fac.12.1721843078531; Wed, 24 Jul 2024 10:44:38 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289248 Archived-At: On Wed, Jul 24, 2024 at 5:40=E2=80=AFPM Spencer Baugh wrote: > I don't want to be obstructionist, but it seems to me that if we land > this in flymake, eventually it will just *have* to be supported in > Eglot. Not aware that Eglot is under such obligation. It generally wants to use Emacs facilities that do useful work, but only if those things are simpler than existing battle-tested things. This is not one of those. The patch Eshel was proposing adds a re-representation of code actions to Flymake, something completely outside its responsibilities (as I designed and maintained for a number of years at least). Flymake's current API is fine for Eglot's code-action purposes. A refactor.el API would be even better. > I don't want to abuse that as a way to work around what Joao > prefers. I suggested an alternative idea to put in the refactor.el library. No idea why that's not being considered : =C2=AF\_(=E3=83=84)_/=C2=AF https://lists.gnu.org/archive/html/emacs-devel/2024-05/msg01163.html Then for sure Eglot would migrate, as I'm always looking for less code to maintain, not more.