From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot Date: Mon, 12 Dec 2022 11:56:47 +0000 Message-ID: References: <167080394233.4339.5863353994038854528@vcs2.savannah.gnu.org> <20221212001223.E9A9DC004BE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005013c905efa033be" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10339"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 12 12:58:22 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4hRu-0002ZV-HN for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Dec 2022 12:58:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4hQc-0003PB-Nk; Mon, 12 Dec 2022 06:57:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4hQa-0003Ot-UJ for emacs-devel@gnu.org; Mon, 12 Dec 2022 06:57:00 -0500 Original-Received: from mail-oa1-x31.google.com ([2001:4860:4864:20::31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4hQZ-0006dx-Gm for emacs-devel@gnu.org; Mon, 12 Dec 2022 06:57:00 -0500 Original-Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1433ef3b61fso8008515fac.10 for ; Mon, 12 Dec 2022 03:56:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qUSZvl5ZDiViU58bE4k2prDaY5jbML/JRdlun5ZBzOw=; b=FLQKWdE1s1B6zKYs+spBHbdRS4qt1uWLY2OPDCVAGl1OmGO6wwNhSWVO1Iis1A6bYB j/5hkQRFYNwHPYfGPf8E2qEx+IyL2p/eG6ptvQCxgC1RZ0ct0oSHubNhCQ6J37d3S4u9 qm8WroldiPTs0W5zoGzXrNr9qfogclzxHrxtvv1479UFd8+QfviTRv3T5MEFt6A7/n1O QKmrAOTpAjqLxUQk4IVINBEPbH/9o7EizDXUGgIr0rPFYKnm0tFJGM/avlbsZXP69LH0 Eix4wCD3rieEt+7UqVmSURib2ViLjEaSbePf3o9E5hUlURlAgHsUyk7h5/rCrAPg+on1 +UMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qUSZvl5ZDiViU58bE4k2prDaY5jbML/JRdlun5ZBzOw=; b=S8ba/b4z9vRc6EqUqJEIIdK6ljDqjE4iTtfXhxH+a/Q4uNmyIeM7kYwrIKNHjz/HKN J6ZktgmQUepnQj49T237Uy7Shi6h90Y0pZUqXqBdwY5gppTeN9Ff0KVh+TgFpBaDA4EG A9i1ZtAJ0k1Oy6ltewDldJ3IQhjWe8cobtoNY8uLlukKFVMhTR1H4zCDI/sy51ro2zCY OjAI4uYHU63+OppRv8l5MPP8oqOgUpFDfRJE0n4pjmMGU/gju04LBrSysVQcb6eHYYlX ZxZ0CVsbt2hepUXLb/hmzQIt8B1Z3GavP8vU7veurzGF9m782b77FMNLw7J8c7LopTvk OKvw== X-Gm-Message-State: ANoB5pkMZ8UJ/qx/r5JVSWTtJCa+YeQ3zYwaLPnsi/YvSqdIQo+aGiIt IG31A8XWJ6uHHYGUmTnl9vSH8vHIxSrWhVNidEs= X-Google-Smtp-Source: AA0mqf5gwVLpGvU62LnRMXd5s9DfFJjJtB4UEprIniMEkiA55e1ScR6lq3KLMIRfvMMPip6FBPjgWx7bsIhy3D3M/2s= X-Received: by 2002:a05:6871:410e:b0:143:7889:c525 with SMTP id la14-20020a056871410e00b001437889c525mr31974655oab.171.1670846218243; Mon, 12 Dec 2022 03:56:58 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2001:4860:4864:20::31; envelope-from=joaotavora@gmail.com; helo=mail-oa1-x31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301218 Archived-At: --0000000000005013c905efa033be Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stefan, I think the extra predicates you suggest are fine, feel free to push the changes. I haven't actually pushed the (skip-unless ... "cargo") commit because of the ongoing repo issues. If you can push, I invite you to push that, too. Maybe also adjust the autopep8 test expectation to match your result. Or maybe write the reformat test using something stabler, like "clangd" if you have it. As for the :expensive, what do you think makes a test expensive. The longest-running tests in my machine take less than 3 seconds. But I'm not running the jtdls one (and I seem to remember that takes a bit more time). So here, too, fell free to add :expensive tags to those tests. Jo=C3=A3o --0000000000005013c905efa033be Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stefan,

I think the extra= predicates you suggest are fine,
feel free to push the changes.= =C2=A0 I haven't actually=C2=A0
pushed the (skip-unless ... &= quot;cargo") commit because
of the ongoing repo issues.=C2= =A0 If you can push, I invite
you to push that, too.
Maybe also adjust the autopep8 test expectation=C2=A0
to match your result.=C2=A0 Or maybe write the reformat
tes= t using something stabler, like "clangd" if you have it.

As for the :expensive, what do you think makes a test
expensive.=C2=A0 The longest-running tests in my machine
ta= ke less than 3 seconds.=C2=A0 But I'm not running the=C2=A0
j= tdls one (and I seem to remember that takes a bit=C2=A0
more time= ).=C2=A0 So here, too, fell free to add :expensive
tags to those = tests.

Jo=C3=A3o
--0000000000005013c905efa033be--