From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#33740: [PATCH] Customizable flymake mode-line indicator Date: Tue, 17 Sep 2019 15:07:59 +0100 Message-ID: References: <87bm4wjhgy.fsf@gmail.com> <87h85bq3u7.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002661b30592c04063" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="16765"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33740@debbugs.gnu.org, Andrii Kolomoiets To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 17 16:09:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAEAN-0004C8-AP for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Sep 2019 16:09:15 +0200 Original-Received: from localhost ([::1]:46556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAEAM-0004hm-44 for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Sep 2019 10:09:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50018) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAEAB-0004fX-Eu for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 10:09:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAEAA-00067i-Bf for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 10:09:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iAEAA-00067J-8J for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 10:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iAEAA-0004Dv-04 for bug-gnu-emacs@gnu.org; Tue, 17 Sep 2019 10:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Sep 2019 14:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33740 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33740-submit@debbugs.gnu.org id=B33740.156872929816184 (code B ref 33740); Tue, 17 Sep 2019 14:09:01 +0000 Original-Received: (at 33740) by debbugs.gnu.org; 17 Sep 2019 14:08:18 +0000 Original-Received: from localhost ([127.0.0.1]:53111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAE9S-0004Cy-D1 for submit@debbugs.gnu.org; Tue, 17 Sep 2019 10:08:18 -0400 Original-Received: from mail-io1-f53.google.com ([209.85.166.53]:39280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iAE9Q-0004Cl-Sw for 33740@debbugs.gnu.org; Tue, 17 Sep 2019 10:08:17 -0400 Original-Received: by mail-io1-f53.google.com with SMTP id a1so7907098ioc.6 for <33740@debbugs.gnu.org>; Tue, 17 Sep 2019 07:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LbKYPO/D2DS0HSCOBZQXXKdUdPds5kFoJP96ytmsDDc=; b=l7jBYoibYigPOpzwL5B/qBWUe4PDy3sNsEUz0kvyAB2dGgZuOHAW5E4UzF/GJyrOD1 0TqMC07c5mQwlTzDRGJzHY/hW2g3tBOnM2rtSr4tODPDw3ivIudI6wqQZzYdyvLzLec3 64sS2EBrT05p5oZDRbVO0ZoWjeNFTMpPOg+piINxMMxLIm1hGDZZ6VNBrSjXf01tNngS uoW/IZ65noAMcm9Kwx+gnuUUA1UA2eEQhq6zQps2ksuf6IRpAEkDbrhvtygIMVqSi5Y5 Dx2A2ZepuZbnBF1rCgMCSPKxf/9fCUEpuYkWWAP0X2x8v3CTXoEXirlbdaq0Kfr/JVRv CzJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LbKYPO/D2DS0HSCOBZQXXKdUdPds5kFoJP96ytmsDDc=; b=KMjpe3SOZj+PPMQUlaOABdQC5WLj9ntAtVLNod4rW/5JXzefpPxNjdTo6EQ506/es8 YryXwFMu4/CXiu3lKRAh+YPdDq/YjvulcHaZo/Id6XpvCaduAzzIoojnBgxOQXv9tjU6 GO3iN09xgkBQI05JkcoE2cotEbNoH0d3eeGmJjV7/irvds5tcTqMQPhSV3NOaI6Ep+F5 wGDn28F7nq69N3854BoF6rDVseCz8MfDDsQaK/EKG129LOgwUKVJIk5zqqfWs8kB1MqR o+UmN6hOsh/nExkCK6eIHf9DXURl92FC+qJ1Ox/2A6JTlk844GClRmM5U+VHOvGEbg4F 14wQ== X-Gm-Message-State: APjAAAVYQKo3fy4LZyj0rRsiFwzzHyugOP04tMlscNUSqM6sRMqei+It 4Io0Reo8BjXFOI4y65TOwwAp4dJQ5fx4spIZ3+g= X-Google-Smtp-Source: APXvYqycIglERRkP0E19FHG+SEa9RZBCsHVYSTgAk7TsaH7IPay3nDJTJccxGqfyWgun9lNO929Zquj4c/cbQP9s4bA= X-Received: by 2002:a6b:b643:: with SMTP id g64mr2018416iof.149.1568729291181; Tue, 17 Sep 2019 07:08:11 -0700 (PDT) In-Reply-To: <87h85bq3u7.fsf@gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166646 Archived-At: --0000000000002661b30592c04063 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Sep 16, 2019 at 11:22 PM Lars Ingebrigtsen wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > Looks good, though I would prefer if the defcustom was a format-string > > where %s would be substituted by the error counts. That way you could > > even get rid of the braces or use something else. > > Below is a proof-of-this-concept-not-working when done via the normal > format-spec machinery. :-) > Thanks, Lars. I'm away from my emacs dev machine so I can't read the diff very carefully, but if you want to risk it, go ahead and push, because I like the defcustom spec and I see you've kept the default. A short entry in NEWS and the Flymake manual is probably worth it (but you can skip the latter). There are arbitrary errors levels in this flymake (not just error warning and note). But those are the main ones and anyway we can always add more format machinery later. I see a lot of changed lines, but most of them are probably whitespace. Is there some diff format which elides those? Jo=C3=A3o --0000000000002661b30592c04063 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Sep 16, 2019 at 11:22 PM Lars Ing= ebrigtsen <larsi@gnu= s.org> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writ= es:

> Looks good, though I would prefer if the defcustom was a format-string=
> where %s would be substituted by the error counts.=C2=A0 That way you = could
> even get rid of the braces or use something else.

Below is a proof-of-this-concept-not-working when done via the normal
format-spec machinery.=C2=A0 :-)

Thanks= , Lars.=C2=A0 I'm away from my emacs dev machine so I can't read
the diff very carefully, but if you want to risk it, go ahead and p= ush, because I
like the defcustom spec and I see you've kept= the default. A short entry
in NEWS and the Flymake manual is pro= bably worth it (but you can skip
the latter).
=
There are arbitrary errors levels in this flymake (not just = error warning
and note). But those are the main ones and any= way we can always
add more format machinery later.

I see a lot of changed lines, but most of them are probably= whitespace.
Is there some diff format which elides those?
<= div>
Jo=C3=A3o
--0000000000002661b30592c04063--