all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: 32243@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#32243: 26.1; eldoc takes priority over flymake-diagnostics
Date: Sun, 19 Aug 2018 19:48:22 +0100	[thread overview]
Message-ID: <CALDnm50Pzo7HROUt+nN=x34-7F+jwRQZjp40pnctYnyH7QWF3g@mail.gmail.com> (raw)
In-Reply-To: <m28t64s8b6.fsf@jamesretina.local.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 929 bytes --]

A naive fix for this could be

diff --git a/lisp/emacs-lisp/eldoc.el b/lisp/emacs-lisp/eldoc.el
index 49ba71fb1b..5fafd066db 100644
--- a/lisp/emacs-lisp/eldoc.el
+++ b/lisp/emacs-lisp/eldoc.el
@@ -272,7 +272,9 @@ eldoc-minibuffer-message
                 (when (stringp format-string)
                   (apply #'format-message format-string args)))
           (force-mode-line-update)))
-    (apply 'message format-string args)))
+    (unless (and (current-message)
+             (not (string= (current-message) "Quit")))
+      (apply 'message format-string args))))

 (defun eldoc-message (&optional string)
   "Display STRING as an ElDoc message if it's non-nil.

which imitates what help-at-pt-maybe-display-does.

It seems to work more or less well in my testing, but not always. Obviously
I haven't studied the full impact of this.

Dmitry, do you have any thoughts on this?

-- 
João Távora

[-- Attachment #2: Type: text/html, Size: 1274 bytes --]

  reply	other threads:[~2018-08-19 18:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-21 19:22 bug#32243: 26.1; eldoc takes priority over flymake-diagnostics James Nguyen
2018-08-19 18:48 ` João Távora [this message]
2020-08-22 15:03   ` Lars Ingebrigtsen
2020-08-22 16:05     ` João Távora
2020-08-22 16:20       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALDnm50Pzo7HROUt+nN=x34-7F+jwRQZjp40pnctYnyH7QWF3g@mail.gmail.com' \
    --to=joaotavora@gmail.com \
    --cc=32243@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.