From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62065: 30.0.50; No prompt to confirm unsafe local variables when eglot-ensure used in major mode hook Date: Mon, 20 Mar 2023 01:21:12 +0000 Message-ID: References: <831qlvy7ab.fsf@gnu.org> <875yb71qxk.fsf@gmail.com> <875yb7xrfd.fsf@gmail.com> <87ttyppxkt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4985"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62065@debbugs.gnu.org, Eli Zaretskii To: Matt Wittmann Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 20 02:22:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pe4E2-00017B-1V for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Mar 2023 02:22:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pe4Dt-0006PU-4F; Sun, 19 Mar 2023 21:22:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pe4Dr-0006P7-5s for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 21:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pe4Dq-00077A-Tq for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 21:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pe4Dq-00025X-Hl for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 21:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Mar 2023 01:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62065 X-GNU-PR-Package: emacs Original-Received: via spool by 62065-submit@debbugs.gnu.org id=B62065.16792752917988 (code B ref 62065); Mon, 20 Mar 2023 01:22:02 +0000 Original-Received: (at 62065) by debbugs.gnu.org; 20 Mar 2023 01:21:31 +0000 Original-Received: from localhost ([127.0.0.1]:53327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pe4DL-00024l-Ja for submit@debbugs.gnu.org; Sun, 19 Mar 2023 21:21:31 -0400 Original-Received: from mail-oi1-f174.google.com ([209.85.167.174]:33621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pe4DJ-00024Y-67 for 62065@debbugs.gnu.org; Sun, 19 Mar 2023 21:21:29 -0400 Original-Received: by mail-oi1-f174.google.com with SMTP id be16so7743873oib.0 for <62065@debbugs.gnu.org>; Sun, 19 Mar 2023 18:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679275283; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2WWvbH4fQkmk4qfNYdw3wdg7dxSU8662G53bgAvCm3o=; b=drT9qh9wCXLPTFfv8hrjPWg/s7vpPEusiUh2SZHPWx0phrkVcca20K46Xy9Fk4AObt oo3J6Fod/6Lf1FT+0x9OD2Ea5ENgV/c3eMwOxPqT4VUK0bhFJGJPrDBwdeZvjK6Ofy8c nFmjRF9HSCgsefJCBm+Bvuo8ytE2mM8p49uk5PE+OenPOXqweKIo6Pb4ypnN5pGGKu04 zvG3gAarNKVDT1EkJvczGKt2WYnq+H5SFShEqYw/+B7B1VRtwCx8E1z20rGM+Y3jyCgN iJuS+SGvyVBsDz5NHHJnKxUJxQ7tw48w6XfCzXQmCuWTcKzkMf0tVNv1pPy2xWVLrX5P jg+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679275283; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2WWvbH4fQkmk4qfNYdw3wdg7dxSU8662G53bgAvCm3o=; b=6OvtDL6dg80KAdrIJ6hgv8mSox9O36tjDgJXMa597YTyU5E2TbY+YtMsZYG9yoyq4H 4CmJzwnVnJbTVvXs8JsziCmbb2FVnW6JU/mOsRBnrJwpcJLevA/dOZvpkiya9i/omB3U KsGEeqVmyKdMNU+ghNpGrmbBxzSZdEhP6qGfE4kNGDjNPo85O6WsjtfyQwhD9NYPAuTN c5LXu4wndmbjMCMh/LuhrSDWvbrCn9PejEsI0j2y9jqc232ZR3hxh5wpCImmikTC38+n d0Bq97LsqxX4qfEbQ3e45QbFJnYvHfxJWT/Ia537oIwByx6wPgFc48Uqx5S9QwK7kEi8 G7Rw== X-Gm-Message-State: AO0yUKXnJ908pqzbVaDHEn7h8anczMTArLcHmSqJUVo4YQ7uhOwGjPnn Eu5f9y33lX3kXcC+9wu1QSniXjEfJGeVTnIk3Og= X-Google-Smtp-Source: AK7set9pLZDOP4uw8CnOdbgL/0iETZ8YU8T/zznx+tCt10mW6mHrJTx27HU6H3BPDhhoLL82gP7ImCDgzcJj4SFKqRU= X-Received: by 2002:a05:6808:b2f:b0:384:1e6a:bf10 with SMTP id t15-20020a0568080b2f00b003841e6abf10mr4157433oij.5.1679275283413; Sun, 19 Mar 2023 18:21:23 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258267 Archived-At: On Mon, Mar 20, 2023 at 1:07=E2=80=AFAM Matt Wittmann wr= ote: > > Confirmed that the original issue seems to be resolved > in master. I do see the behavior you mentioned where I > am asked to confirm a second time immediately after the > first unless I permanently mark the values as safe, but > otherwise it's working well for me. Thank you Jo=C3=A3o! It's good to hear that. But for the reasons I explained before, I think this bug should stay open. I see two possible ways to proceed here. 1. If the user answers "no" to apply the unsafe variables Emacs could still apply the save ones. It doesn't currently. 2. There could be a way for extension like Eglot to pull in only specific variables from the dir-local db. Jo=C3=A3o