From: "João Távora" <joaotavora@gmail.com>
To: Danny Freeman <danny@dfreeman.email>
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Eglot, project.el, and python virtual environments
Date: Fri, 18 Nov 2022 18:31:20 +0000 [thread overview]
Message-ID: <CALDnm50EYqJ4tXtNd4iH3=utvXgSRPCSWznUNdpquDT8m5D5_A@mail.gmail.com> (raw)
In-Reply-To: <878rkale3l.fsf@dfreeman.email>
[-- Attachment #1: Type: text/plain, Size: 4396 bytes --]
Fwiw, Danny's tip is what I used at a recent day job gig for defining
subprojects in a 400k files repo.
João
On Wed, Nov 16, 2022, 22:39 Danny Freeman <danny@dfreeman.email> wrote:
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
> > Hi,
> >
> > Here's another issue that's technically a emacs.help question, but might
> > result in some code/documentation updates, so I'm sending it here.
> >
> > My main day-job code base is an AWS CloudFormation monstrosity involving
> > several Python Lambdas, among other things. Basic project structure
> > looks like:
> >
> > project_root
> > ├── .git
> > ├── src
> > │ └── python
> > │ ├── VeryImportantLambda
> > │ │ └── .venv
> > │ ├── MoreImportance
> > │ │ └── .venv
> > │ ├── RunInCaseOfEmergency
> > │ │ └── .venv
> >
> > I'm using the python-lsp-server python package in each Python
> > subdirectory, and the key is that each of those directories is a virtual
> > environment that needs to stay isolated from the others. Each has
> > different packages installed, and in some cases even the Python versions
> > are different (though I'm trying to get rid of that).
> >
> > When I was using lsp-mode this wasn't difficult, because lsp-mode and
> > project.el are essentially orthogonal: if I visited a python file in a
> > given lambda directory, I could use `pyvenv-activate' to activate that
> > environment, and then the `lsp' invocation would confine itself to
> > python files within the environment. Project.el just provided
> > project-wide navigation.
> >
> > Now I'm trying to move to Eglot, and there is tighter integration
> > between Eglot and project.el. Turning on Eglot in one lambda starts the
> > server for all Python libraries in the whole project, not just the
> > current environment. I looked into constructing my own version of the
> > call to `eglot', but it is tightly tied to a project, all the way down.
> >
> > Is anyone else handling this situation? Any suggestions how to make it
> > work?
> >
> > Thanks,
> > Eric
>
>
> I have NOT been in this situation, but it sounds like you want to keep
> using project.el as is, but override eglot's usage of project.el to
> identify root directory to start a lsp server in.
>
> I think the place to start looking would be the function
> `eglot--current-project`.
>
> It uses a var called `eglot-lsp-context` which is `t` when eglot is
> searching for a project.
>
> Knowing this, there is another var called `project-find-functions` that
> project.el uses when searching for project roots, which can be used for
> finding custom project roots. I have one that looks for a file named
> ".project.el". If that file exists then that directory is identified as
> a project. It's really useful when you have a project not in source
> control.
>
> See:
> ```
> (defun project-find-project.el (dir)
> "Returns a `manual-project' instance if the project of the current
> DIR has a .project.el file in its root directory."
> (let ((root (locate-dominating-file dir ".project.el")))
> (when root
> (cons 'transient root))))
>
> (add-hook 'project-find-functions #'project-find-project.el)
> ```
>
> Now, I am not a python programmer, but lets pretend that python
> virtualenviroment depends on a file located in the directory you want to
> activate one of these virtual environments, say `.virtualenv`.
>
> You can write a project-find-functions implementation that looks for
> these virutalenv files ONLY when eglot-lsp-context is active.
>
> ```
> (defun project-find-virtualenv-for-eglot (dir)
> (when eglot-lsp-context
> (let ((root (locate-dominating-file dir ".virtualenv")))
> (when root
> (cons 'transient root)))))
>
> (add-hook 'project-find-functions #'project-find-virtualenv-for-eglot)
> ```
>
> I did not test this, but I think it should send you down the right path.
> Eglot should see your aws lambda folders as the project root, and
> project.el should see the parent.
>
> If python virtual environments do not have any kind of file marker in
> the filesystem, you could use a dummy file in those directories like
> `.eglot-project` or something.
>
> Hope this helps,
> --
> Danny Freeman
>
>
[-- Attachment #2: Type: text/html, Size: 5272 bytes --]
next prev parent reply other threads:[~2022-11-18 18:31 UTC|newest]
Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 18:37 Eglot, project.el, and python virtual environments Eric Abrahamsen
2022-11-16 22:24 ` Danny Freeman
2022-11-16 22:53 ` Eric Abrahamsen
2022-11-17 13:41 ` Danny Freeman
2022-11-17 18:06 ` Eric Abrahamsen
2022-11-17 18:48 ` Yuan Fu
2022-11-17 22:21 ` Tim Cross
2022-11-18 2:38 ` Phil Sainty
2022-11-18 7:43 ` Eli Zaretskii
2022-11-18 13:55 ` Danny Freeman
2022-11-18 15:22 ` Eli Zaretskii
2022-11-18 15:53 ` Danny Freeman
2022-11-18 19:36 ` Eric Abrahamsen
2022-11-18 15:06 ` Stefan Monnier
2022-11-18 15:17 ` Eli Zaretskii
2022-11-18 15:28 ` Stefan Monnier
2022-11-19 1:12 ` Dmitry Gutov
2022-11-19 7:42 ` Eli Zaretskii
2022-11-19 13:06 ` Dmitry Gutov
2022-11-19 13:14 ` Eli Zaretskii
2022-11-18 18:31 ` João Távora [this message]
2022-11-19 1:13 ` Dmitry Gutov
2022-11-19 1:56 ` João Távora
2022-11-19 15:23 ` Dmitry Gutov
2022-11-19 19:17 ` Danny Freeman
2022-11-19 19:49 ` Dmitry Gutov
2022-11-19 21:22 ` Danny Freeman
2022-11-20 1:51 ` João Távora
2022-11-20 15:36 ` Dmitry Gutov
2022-11-20 20:35 ` João Távora
2022-11-20 22:05 ` Dmitry Gutov
2022-11-21 13:45 ` João Távora
2022-11-22 15:48 ` Dmitry Gutov
2022-11-22 21:12 ` Stefan Monnier
2022-11-22 21:34 ` João Távora
2022-11-22 22:00 ` Dmitry Gutov
2022-11-22 23:23 ` João Távora
2022-11-23 0:03 ` Dmitry Gutov
2022-11-23 13:57 ` Subprojects in project.el (Was: Eglot, project.el, and python virtual environments) João Távora
2022-11-23 20:33 ` João Távora
2022-11-24 2:49 ` Dmitry Gutov
2022-11-24 8:42 ` João Távora
2022-11-24 22:17 ` Dmitry Gutov
2022-11-25 19:56 ` Subprojects in project.el João Távora
2022-11-25 22:33 ` Dmitry Gutov
2022-11-26 0:00 ` João Távora
2022-11-26 1:57 ` Dmitry Gutov
2022-11-26 9:23 ` João Távora
2022-11-26 13:34 ` Dmitry Gutov
2022-11-26 19:36 ` João Távora
2022-11-26 2:01 ` Dmitry Gutov
2022-11-26 9:24 ` João Távora
2022-11-24 2:51 ` Subprojects in project.el (Was: Eglot, project.el, and python virtual environments) Dmitry Gutov
2022-11-24 6:23 ` Eli Zaretskii
2022-11-24 9:01 ` João Távora
2022-11-24 22:11 ` Dmitry Gutov
2022-11-25 7:30 ` Eli Zaretskii
2022-11-25 17:24 ` Dmitry Gutov
2022-11-25 19:45 ` Eli Zaretskii
2022-11-25 21:57 ` Dmitry Gutov
2022-11-25 23:55 ` Subprojects in project.el João Távora
2022-11-28 0:41 ` Dmitry Gutov
2022-11-26 7:26 ` Subprojects in project.el (Was: Eglot, project.el, and python virtual environments) Eli Zaretskii
2022-12-02 1:32 ` Dmitry Gutov
2022-12-02 14:16 ` Eli Zaretskii
2022-12-02 15:08 ` Dmitry Gutov
2022-12-02 15:37 ` Dmitry Gutov
2022-12-02 15:44 ` Subprojects in project.el Stefan Monnier
2022-12-02 23:26 ` João Távora
2022-12-06 14:36 ` Subprojects in project.el (Was: Eglot, project.el, and python virtual environments) João Távora
2022-11-24 3:01 ` Dmitry Gutov
2022-11-24 8:50 ` João Távora
2022-11-24 22:46 ` Tim Cross
2022-11-24 23:38 ` Dmitry Gutov
2022-11-25 7:07 ` Bozhidar Batsov
2022-11-25 14:58 ` Subprojects in project.el Stefan Monnier
2022-11-25 22:29 ` Dmitry Gutov
2022-11-26 2:59 ` Stefan Monnier
2022-11-26 12:30 ` Dmitry Gutov
2022-11-26 17:32 ` Stefan Monnier
2022-11-27 0:25 ` Dmitry Gutov
2022-11-25 20:32 ` João Távora
2022-11-28 4:10 ` Subprojects in project.el (Was: Eglot, project.el, and python virtual environments) Tim Cross
2022-11-28 17:21 ` Dmitry Gutov
2022-11-29 9:56 ` Subprojects in project.el João Távora
2022-11-29 18:40 ` Dmitry Gutov
2022-11-29 22:21 ` João Távora
2022-11-30 0:39 ` Dmitry Gutov
2022-11-30 0:54 ` João Távora
2022-11-30 0:57 ` Dmitry Gutov
2022-11-30 1:18 ` João Távora
2022-12-02 22:47 ` Richard Stallman
2022-12-02 23:46 ` Dmitry Gutov
2022-12-03 7:09 ` Eli Zaretskii
2022-11-24 22:58 ` Subprojects in project.el (Was: Eglot, project.el, and python virtual environments) Dmitry Gutov
2022-11-25 2:38 ` Subprojects in project.el Stefan Monnier
2022-11-25 20:23 ` João Távora
2022-11-25 22:23 ` Dmitry Gutov
2022-11-25 7:42 ` Juri Linkov
2022-11-25 20:27 ` Dmitry Gutov
2022-11-25 23:47 ` João Távora
2022-11-25 23:58 ` Dmitry Gutov
2022-11-26 0:46 ` João Távora
2022-11-26 2:07 ` Dmitry Gutov
2022-11-25 20:16 ` João Távora
2022-11-25 22:44 ` Dmitry Gutov
2022-11-26 0:37 ` João Távora
2022-11-26 2:05 ` Dmitry Gutov
2022-11-26 9:42 ` João Távora
2022-11-26 12:38 ` Dmitry Gutov
2022-11-29 10:03 ` João Távora
2022-11-29 10:17 ` João Távora
2022-11-29 19:07 ` Dmitry Gutov
2022-11-29 22:52 ` João Távora
2022-11-30 1:10 ` Dmitry Gutov
2022-11-27 19:25 ` Juri Linkov
2022-11-27 21:43 ` Dmitry Gutov
2022-11-22 23:53 ` "Backend completion style" as a first-class library. Re: Eglot, project.el, and python virtual environments João Távora
2022-11-23 1:45 ` Stefan Monnier
2022-11-25 13:16 ` João Távora
2022-11-22 21:40 ` João Távora
2022-11-22 22:13 ` Dmitry Gutov
2022-11-22 23:33 ` João Távora
2022-11-21 20:58 ` Augusto Stoffel
2022-11-23 3:37 ` Dmitry Gutov
2022-11-20 16:37 ` João Távora
2022-11-21 7:54 ` Eric Abrahamsen
2022-11-21 13:36 ` João Távora
2022-11-21 15:41 ` Alfred M. Szmidt
2022-11-21 16:49 ` Eli Zaretskii
2022-11-21 16:49 ` Eric Abrahamsen
2022-11-21 20:54 ` Augusto Stoffel
2022-11-19 23:25 ` João Távora
2022-11-19 23:40 ` Dmitry Gutov
2022-11-16 23:18 ` Philip Kaludercic
2022-11-17 1:14 ` Eric Abrahamsen
2022-11-17 6:47 ` North Year
2022-11-17 18:09 ` Eric Abrahamsen
2022-11-19 22:36 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm50EYqJ4tXtNd4iH3=utvXgSRPCSWznUNdpquDT8m5D5_A@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=danny@dfreeman.email \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.