From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Eglot to core [Was: rmsbolt.el [Was: Colorful line numbers]] Date: Tue, 26 Jul 2022 09:21:21 +0100 Message-ID: References: <87leslpow2.fsf@gmail.com> <87zgh1nyo6.fsf@gmail.com> <831qudl1k3.fsf@gnu.org> <87v8rpntiv.fsf@gmail.com> <83sfmtjjy8.fsf@gnu.org> <87fsitnpxd.fsf@gmail.com> <83k085jgxr.fsf@gnu.org> <87tu77vq1a.fsf@eve> <874jz6mj6b.fsf@gmail.com> <87r12aypas.fsf@yahoo.com> <87h735zp5o.fsf@yahoo.com> <87r129h0nn.fsf@betli.tmit.bme.hu> <87ilnlxtqz.fsf@gmail.com> <87mtcxgrto.fsf@betli.tmit.bme.hu> <875yjlxkqn.fsf@gmail.com> <87ilnkgumc.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005bb8bd05e4b0f80c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14479"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Felician Nemeth Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 26 10:22:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGFpq-0003f4-Nc for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 10:22:34 +0200 Original-Received: from localhost ([::1]:54520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGFpp-00088v-8v for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Jul 2022 04:22:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGFnf-0006dZ-Iy for emacs-devel@gnu.org; Tue, 26 Jul 2022 04:20:23 -0400 Original-Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]:40680) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGFnd-0004p8-Vs for emacs-devel@gnu.org; Tue, 26 Jul 2022 04:20:19 -0400 Original-Received: by mail-oi1-x230.google.com with SMTP id w204so16270552oie.7 for ; Tue, 26 Jul 2022 01:20:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pSGFwcfaEPQmX+E+SHk6ZKlRRTG/iYBpRTtcq90rWzo=; b=h1tIIPCJ9c6II2kMvqlfOdr1e8eWcCLC1v2LBphA+hrNFnK5ryAQIJVzdyzuavHlDC uj++f1xw0iR64NrnYfxT2gHagEyCdFJtiXIIoK2OzD3c4OF9vNf0xgpl39j95CVQsBph FKq14Oe4sLDhojDG2IhWriKtFciYjIRAQ5oKgvHxxQ2uNjsAaWQ1N1NLZmG/wYfoT4CC p1JpLMEVX496qdw4wGOHXc/TqWJBAbTGiKrn0J/HYjcw4zT3YctK0ndXO+1te6CfZrxH HCXQ8h+ntrlC0SiG40uI6peVyT/70XKRnWrtu8IpR6C/tEMBLM+wtlMukc/6JJeJLNch h0Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pSGFwcfaEPQmX+E+SHk6ZKlRRTG/iYBpRTtcq90rWzo=; b=HOBzLOTdSUNV3rHaDPY1qMRcTtgxGG7EGxJv8dlVCfok9oZ3EIz4YmZ9hB9fT1AyQA UfQhozH8DAqCfEHR5GHTe7I8LCb869oyw7m6JpVyICOH6S/o3H17ZH2YWnqkWQsmywuk bc6fhbMqct/lHe3LKpYvgrctqDg42uwnR5c1aON6UQIsr5ARNCubiddColEAtI5DMjIn J3fXtixlC4zpBmxiPfHR3jympEVCXVFi3b+gOkax5Juc592dzW+MagQ0VjN710tLGjtg L3BXq0vC40djLa8H0Z6O9FXYDplxV72iKWO0XoH4RaA2V6k6NnTWgCSAwkhNLoS4k6nT xOEw== X-Gm-Message-State: AJIora/+h3LKbKDiL2qTE7nYP4yegMtJXPtr6C8bC4VzBbHDr/vWJy8O BsUJZ7wiytUXNIJdrxfD6VJmHs7lsGyTEsgu9PQ= X-Google-Smtp-Source: AGRyM1uyKw4Fau+9R6WYA0iek/UfLkhUZQ9wurDmGp94BU0zlRnpEwjajQfqh1XOwU7LjHrWYuCuu9U7x6Sp3xny/tg= X-Received: by 2002:aca:210e:0:b0:33a:3557:b224 with SMTP id 14-20020aca210e000000b0033a3557b224mr14809636oiz.209.1658823615689; Tue, 26 Jul 2022 01:20:15 -0700 (PDT) In-Reply-To: <87ilnkgumc.fsf@betli.tmit.bme.hu> Received-SPF: pass client-ip=2607:f8b0:4864:20::230; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x230.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292669 Archived-At: --0000000000005bb8bd05e4b0f80c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 26, 2022 at 9:12 AM Felician Nemeth wrote: > > Yes, I think this is a great idea to allow the user to configure > > server-specific things easily and automatically save it > > .dir-locals.el. > > > > The question is how. Not sure if variables is the way to go. > > Rust-analyzer can emit the definition of its configuration variables as > a JSON schema. There are toml and yaml servers that hopefully > understand this schema description. > > So one possibility for Eglot is to help the user to edit a > project/rust.toml or a global ~/.emacs.d/eglot/rust.toml file and > arrange to call eglot-signal-didChangeConfiguration when the user saves > the file. > I don't disagree with this, though it seems different from your first idea. When is the .dir-locals.el written in your example, or were you imagining a use with `dir-locals-set-class`? Regardless, if this works, why shouldn't it be rust-mode.el's job to do exactly this? Editing "toml" files is outside the scope of LSP. Jo=C3=A3o --0000000000005bb8bd05e4b0f80c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jul 26, 2022 at 9:12 AM Felician Nemeth <felician.nemeth@gmail.com> wr= ote:
> Yes, I think this is a great idea to allow the user to conf= igure
> server-specific things easily and automatically save it
> .dir-locals.el.
>
> The question is how.=C2=A0 Not sure if variables is the way to go.
Rust-analyzer can emit the definition of its configuration variables as
a JSON schema.=C2=A0 There are toml and yaml servers that hopefully
understand this schema description.

So one possibility for Eglot is to help the user to edit a
project/rust.toml or a global ~/.emacs.d/eglot/rust.toml file and
arrange to call eglot-signal-didChangeConfiguration when the user saves
the file.

I don't disagree with this, though it = seems different from your first idea.
When is the .dir-locals.el = written in your example, or were you imagining
a use with `dir-lo= cals-set-class`?
Regardless,=C2=A0 if this works, why shouldn= 't it be rust-mode.el's job to do exactly
this?=C2= =A0 Editing "toml" files is outside the scope of LSP.=C2=A0
<= /div>

Jo=C3=A3o
--0000000000005bb8bd05e4b0f80c--