From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Accept plists when serializing and parsing JSON Date: Tue, 29 May 2018 23:03:49 +0100 Message-ID: References: <87sh6awls5.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000039d028056d5fca4a" X-Trace: blaine.gmane.org 1527632986 32545 195.159.176.226 (29 May 2018 22:29:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 29 May 2018 22:29:46 +0000 (UTC) Cc: emacs-devel To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 30 00:29:42 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNn7b-0008Kz-HU for ged-emacs-devel@m.gmane.org; Wed, 30 May 2018 00:29:39 +0200 Original-Received: from localhost ([::1]:35315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNn9i-0005qI-MZ for ged-emacs-devel@m.gmane.org; Tue, 29 May 2018 18:31:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNn91-0005pz-6L for emacs-devel@gnu.org; Tue, 29 May 2018 18:31:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNn90-00043G-Cx for emacs-devel@gnu.org; Tue, 29 May 2018 18:31:07 -0400 Original-Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:40399) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fNn90-00042w-87 for emacs-devel@gnu.org; Tue, 29 May 2018 18:31:06 -0400 Original-Received: by mail-qt0-x243.google.com with SMTP id h2-v6so20831752qtp.7 for ; Tue, 29 May 2018 15:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4/n+0olIjH8CmSFc7FOIYSqRZcMNb6gWAeg3bVn+pXQ=; b=eTP0yyB0IGIrIXUGMQXaaBjYkV9bWrQRpsG+mgN18sCPttmeDatJS6ErUciDH69xvN LSmwgW5Rb9StD4/uvyGDubYdj1/33iT6FolHSZi4VnuZzwuThMzf0WCLWWmk4bRWV4wu 4yGYafAGF7JAzzibf8tPw8+AoYAJoEMNan46CISl2lJbG4/STzpanzkw4UtualyR/CBV 0865I8bYS6MBvfFw5+KhaEZMvaSdx3+OpugdIkkUV6JPDgOJ/WP9cN7O7TIvTMwIZkQA ZNZblyZ0SYVYsBc3UTrGWx4ZJAXXT/cnalgKi/skB+3OdwU5w5tptVbClHRjhzlmpDjE J19w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4/n+0olIjH8CmSFc7FOIYSqRZcMNb6gWAeg3bVn+pXQ=; b=KoDcSkiXtHLUUcGXCTXS1j5x5zECIbVynVDldkDyj4vzVNdiwgEarwgzGyDZyfWtNx 4N1AAdXJX8Dlfb19tU9Gskya/GC9L8HDA0gpIk1d4mxAA6TIgOJM+5jfnfujByzZ9J60 2eGxLOmOdyTSC+AMWBnl2I/glPyCQSttemmr0ma1XyROqKMjzFKaxJw2p+adkbUxXZ9Y t8H+Te0r9/Yeaatjh7x4YsGzovm4ND8hbt2gbx2L8qOq3Z1h1d3nzg0Idw7zrT0h19ve bgaJOdu5N0WG+x7BUx5SdL+JgS5dwcGP4ThZSgY/qJxaY7POtWP8s5Zq6pRY24ZNrpXt GO8A== X-Gm-Message-State: APt69E3VjczQ0M9HKbjU2VbQpKlzYRpaqWOoBmvBkvFnYPgYV/6Ri7cW WBUQXXCf9sQOnVqB5sr9KJ1Bo12Z0EZtRN8+BdDKhg== X-Google-Smtp-Source: ADUXVKJwaaWfageVmUqqP9snA52ByGd6DaXG9wRVRG2796yiEuVlmkgbV5B6J521ufbyB9CK1PyyHpN5DCe8iIG2JyA= X-Received: by 2002:ac8:7159:: with SMTP id h25-v6mr288827qtp.206.1527633065657; Tue, 29 May 2018 15:31:05 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225810 Archived-At: --00000000000039d028056d5fca4a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, May 29, 2018, 22:21 Philipp Stephani wrote: > > > Jo=C3=A3o T=C3=A1vora schrieb am Di., 29. Mai 2018= um > 16:59 Uhr: > >> >> I used a global to control json-serialize's interpretation of lists, but >> it could be an argument as well. > > > Please don't add global state to json.c. It's a low-level library that > shouldn't rely on global state (and global state should generally be > avoided in libraries). Not having global state was one of my explicit > design goals for json.c > Well, it's not really "global state" in the sense I believe you're talking about, because no part of the library is maintaining any state in global variables -- it's read-only from json.c. That said, if that's your only objection, consider that duck removed :) Jo=C3=A3o --00000000000039d028056d5fca4a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, = May 29, 2018, 22:21 Philipp Stephani <p.stephani2@gmail.com> wrote:


Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> schrieb am Di.,= 29. Mai 2018 um 16:59=C2=A0Uhr:
I used a global to control json-serialize's interpretation of lists, bu= t
it could be an argument as well.

Please don= 't add global state to json.c. It's a low-level library that should= n't rely on global state (and global state should generally be avoided = in libraries). Not having global state was one of my explicit design goals = for json.c=C2=A0

Well, it's not really "global state&= quot; in the sense I believe you're talking about, because no part of t= he library is maintaining any state in global variables -- it's read-on= ly from json.c.=C2=A0

Th= at said, if that's your only objection, consider that duck removed :)

Jo=C3=A3o


--00000000000039d028056d5fca4a--