bug#57386: 29.0.50; support make-symbolic-link without admin priviledge on Windows

["Kiên Nguyễn Quang" <kien.n.quang@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1140 bytes --]

>
>
>  (is anyone who has Windows 10 still likely to
> use those old releases, given the automatic updates in Windows 10 that
> cannot be turned off? and if they do, do they indeed get
> ERROR_INVALID_PARAMETER?)
>
There is LTS branch of Windows that gets updated regularly and doesn't have
to update to a newer release build.
Those users (mostly enterprise users/devs) will get the
ERROR_INVALID_PARAMETER, I've tested that.

> When you call an API with a parameter that is invalid, you are risking
> an exception, depending on the API and the build (debug or not).  This
> has various unpleasant consequences; in the worst case, the Emacs
> process could be terminated.  As documented, the problem is limited to
> CRT functions, but our general policy is to avoid that even when using
> the Win32 APIs.  And version check is a simple enough way of avoiding
> that, so I see no reason not to do it here.

Okay, that makes sense. Although I think that's the problem of CRT APIs
only, as API should never throw exceptions, which is a foreign concept to
ABI and requires an exact library match to handle correctly

The new patch is attached.

[-- Attachment #1.2: Type: text/html, Size: 1563 bytes --]

[-- Attachment #2: 0002-Make-native-comp-debug-0-for-Windows.patch --]
[-- Type: application/octet-stream, Size: 879 bytes --]

From 8ab79a8b30cb55c7a41fe48bc7a6002bb62be44d Mon Sep 17 00:00:00 2001
From: Kien Nguyen <kien.n.quang@gmail.com>
Date: Sat, 15 May 2021 10:57:25 +0900
Subject: [PATCH] Make native-comp-debug 0 for Windows

* lisp/emacs-lisp/comp.el (native-comp-debug): dont make debug native-comp for Windows

---
 lisp/emacs-lisp/comp.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 3e7f17ef1c..85d0cea212 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -55,7 +55,7 @@ native-comp-speed
   :safe #'integerp
   :version "28.1")
 
-(defcustom native-comp-debug (if (eq 'windows-nt system-type) 1 0)
+(defcustom native-comp-debug 0
   "Debug level for native compilation, a number between 0 and 3.
 This is intended for debugging the compiler itself.
   0 no debug output.
-- 
2.31.1.windows.1