Two ob-lua versions

Two ob-lua versions

[Thibault Marin]

Hi maintainers,

I noticed that a recent change added an ob-lua.el file to contrib/lisp/.
Since there is already an ob-lua.el in lisp/, I was wondering if the new
version was adding functionality not supported by the one in lisp/ (it
does not seem to be the case on casual inspection) and if so, whether
they could/should be merged.

Thanks,

thibault

Re: Two ob-lua versions

[Nicolas Goaziou]

Hello,

Thibault Marin <thibault.marin@gmx.com> writes:

> I noticed that a recent change added an ob-lua.el file to contrib/lisp/.
> Since there is already an ob-lua.el in lisp/, I was wondering if the new
> version was adding functionality not supported by the one in lisp/ (it
> does not seem to be the case on casual inspection) and if so, whether
> they could/should be merged.

I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
can have some insight about it.

stardiviner, would you mind explaining why you need to create an
"ob-lua.el" library in "contrib/" ?

Regards,

-- 
Nicolas Goaziou

Re: Two ob-lua versions

[Satoru KURASHIKI]

hi,

On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> Thibault Marin <thibault.marin@gmx.com> writes:
>
>> I noticed that a recent change added an ob-lua.el file to contrib/lisp/.
>> Since there is already an ob-lua.el in lisp/, I was wondering if the new
>> version was adding functionality not supported by the one in lisp/ (it
>> does not seem to be the case on casual inspection) and if so, whether
>> they could/should be merged.
>
> I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
> can have some insight about it.

Anyway this breaks installation with package.el in org-plus-contrib case.
because of conflicting "ob-lua.el" filename.

> stardiviner, would you mind explaining why you need to create an
> "ob-lua.el" library in "contrib/" ?

It has to be fixed, so please revert that merge, until stardiviner will notice
this thread and retry PR...

regards,
-- 
KURASHIKI Satoru

Re: Two ob-lua versions

[numbchild]

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

Hi, sorry for this. I have not noticed that. I will create an PR to remove
my `ob-lua.el` as soon as fast.

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Wed, Feb 14, 2018 at 9:28 AM, Satoru KURASHIKI <lurdan@gmail.com> wrote:

> hi,
>
> On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
> wrote:
> > Hello,
> >
> > Thibault Marin <thibault.marin@gmx.com> writes:
> >
> >> I noticed that a recent change added an ob-lua.el file to contrib/lisp/.
> >> Since there is already an ob-lua.el in lisp/, I was wondering if the new
> >> version was adding functionality not supported by the one in lisp/ (it
> >> does not seem to be the case on casual inspection) and if so, whether
> >> they could/should be merged.
> >
> > I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
> > can have some insight about it.
>
> Anyway this breaks installation with package.el in org-plus-contrib case.
> because of conflicting "ob-lua.el" filename.
>
> > stardiviner, would you mind explaining why you need to create an
> > "ob-lua.el" library in "contrib/" ?
>
> It has to be fixed, so please revert that merge, until stardiviner will
> notice
> this thread and retry PR...
>
> regards,
> --
> KURASHIKI Satoru
>
>

[-- Attachment #2: Type: text/html, Size: 2464 bytes --]

Re: Two ob-lua versions

[numbchild]

[-- Attachment #1: Type: text/plain, Size: 1952 bytes --]

I created a PR now https://code.orgmode.org/bzg/org-mode/pulls/4 . Really
sorry for this. @Nicolas , can you merge it now?

[stardiviner]           <Hack this world!>      GPG key ID: 47C32433
IRC(freeenode): stardiviner                     Twitter:  @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/

On Wed, Feb 14, 2018 at 6:18 PM, numbchild@gmail.com <numbchild@gmail.com>
wrote:

> Hi, sorry for this. I have not noticed that. I will create an PR to remove
> my `ob-lua.el` as soon as fast.
>
> [stardiviner]           <Hack this world!>      GPG key ID: 47C32433
> IRC(freeenode): stardiviner                     Twitter:  @numbchild
> Key fingerprint = 9BAA 92BC CDDD B9EF 3B36  CB99 B8C4 B8E5 47C3 2433
> Blog: http://stardiviner.github.io/
>
> On Wed, Feb 14, 2018 at 9:28 AM, Satoru KURASHIKI <lurdan@gmail.com>
> wrote:
>
>> hi,
>>
>> On Sun, Feb 11, 2018 at 6:22 PM, Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> wrote:
>> > Hello,
>> >
>> > Thibault Marin <thibault.marin@gmx.com> writes:
>> >
>> >> I noticed that a recent change added an ob-lua.el file to
>> contrib/lisp/.
>> >> Since there is already an ob-lua.el in lisp/, I was wondering if the
>> new
>> >> version was adding functionality not supported by the one in lisp/ (it
>> >> does not seem to be the case on casual inspection) and if so, whether
>> >> they could/should be merged.
>> >
>> > I just realized that, too. It seems wrong. I'm Cc'ing stardiviner so we
>> > can have some insight about it.
>>
>> Anyway this breaks installation with package.el in org-plus-contrib case.
>> because of conflicting "ob-lua.el" filename.
>>
>> > stardiviner, would you mind explaining why you need to create an
>> > "ob-lua.el" library in "contrib/" ?
>>
>> It has to be fixed, so please revert that merge, until stardiviner will
>> notice
>> this thread and retry PR...
>>
>> regards,
>> --
>> KURASHIKI Satoru
>>
>>
>

[-- Attachment #2: Type: text/html, Size: 3701 bytes --]