From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: On controlling rectangle-preview Date: Thu, 21 Jul 2016 10:54:22 -0400 Message-ID: References: <87wpkhgq5i.fsf@udel.edu> <20160720022539.GA25914@holos.localdomain> <20160720230047.GA18198@holos.localdomain> <837fcfysiv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c06d362521d750538267e19 X-Trace: ger.gmane.org 1469114189 29558 80.91.229.3 (21 Jul 2016 15:16:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 15:16:29 +0000 (UTC) Cc: John Wiegley , Stefan Monnier , Emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 21 17:16:13 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQFhr-0004jl-LC for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 17:16:11 +0200 Original-Received: from localhost ([::1]:41445 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQFhq-00066H-SP for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 11:16:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQFMn-00055v-LX for emacs-devel@gnu.org; Thu, 21 Jul 2016 10:54:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQFMl-0000Vw-MZ for emacs-devel@gnu.org; Thu, 21 Jul 2016 10:54:24 -0400 Original-Received: from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]:35283) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQFMl-0000Vk-En for emacs-devel@gnu.org; Thu, 21 Jul 2016 10:54:23 -0400 Original-Received: by mail-io0-x232.google.com with SMTP id m101so78219680ioi.2 for ; Thu, 21 Jul 2016 07:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=4wRd5BwH2yPO925I3MZHifu7XoDiTawV1c+RXJ5bev8=; b=aTJpPek8/8tdLTM9EeAiY7qe3lq2do46LHq+zG4LdH/6bAPzeUhhazW2AFtTGaTMSJ BqljiNf1+VQbWwfVd+Yg80f7vEqp2fyhxI2eXFjAInyjgUnoEgdK9gLtx4TW7sz1g1nH LJjwDenzWQsyaCVBmq/5um+Nicxzvk+ewEgDeEz2mI9GYEK2mPH/YYwE8yBh78hS54l6 8+m1/vQ+/1ZnqxI6b3omT4HwynaF2xl2GHVt8TxVsc7UJwWJAzF2Ms290ljJ2DEt/aDg Yb4Q2SXjVwfb83lUGaRkhxExf4YGT0qeYRwWdMn37UNhiGM+lnYbsIA4MaJqBNcOAVuC yaLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=4wRd5BwH2yPO925I3MZHifu7XoDiTawV1c+RXJ5bev8=; b=R1eF/ddItjVPR81qr577zsdgPhehts+TZfimM09RxFpiketwS/ikp6kNy7t35R+DZM 33eYwhz7NoS5unKRlcny3rdFoZDHaFO2SA6nhdhmYFAbsyLBpTSW4kSNMd49HkMwsJ8a eDduGJxLvKK0u27dxPDcGgoixw9eU2kfOkxZA2KgmW8x2eMqNHEFfqBs3fAQKhLNNQB3 kFVSCH2VEPlaWYKgBLSdFNaY3BnXT2jqQ0ib/xBhZ06q0xsx57amGNx6/wtV/5lqCd7S XIRDn+Ty9oKop5SgdBx16w6YuVLZHvuavxL5KND8B9OwS8gwKqS7oAQSq543WCsuiQ9M +QKA== X-Gm-Message-State: ALyK8tJ6L4XYhwu61rwdJ8Whk6PRATqI1kqwfRSdc3yXgCbm5n0Qg77qdnb5MhdOJ47vl1qpbtLK5ArEcBp8IZJj X-Received: by 10.107.184.70 with SMTP id i67mr47111919iof.26.1469112862763; Thu, 21 Jul 2016 07:54:22 -0700 (PDT) Original-Received: by 10.107.46.25 with HTTP; Thu, 21 Jul 2016 07:54:22 -0700 (PDT) Original-Received: by 10.107.46.25 with HTTP; Thu, 21 Jul 2016 07:54:22 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4001:c06::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205968 Archived-At: --94eb2c06d362521d750538267e19 Content-Type: text/plain; charset=UTF-8 On Jul 21, 2016 10:28 AM, "Eli Zaretskii" wrote: > > > From: John Wiegley > > Cc: Stefan Monnier , emacs-devel@gnu.org, Eli Zaretskii > > Date: Thu, 21 Jul 2016 00:03:25 -0700 > > > > > This ends up bring very simple--permission to push to emacs-25? > > > > If Eli agrees, it looks safe enough to me for the release. > > Sorry, I'm confused by the last message in the discussion of the > patch. This started by introducing a new defcustom that controls the > preview, but ended with a patch adding no defcustom and instead > deleting 3 lines? What did I miss (specifically between > http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00845.html, > which approves the original patch, and The new defcustom in the original patch would only prevent the preview if its value was nil and the minibuffer was empty. If we agree on nil by default instead, and if the new variable is not worth adding, then... > http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00911.html, > which presents a totally different one)? ... this is the patch that achieves that. Of course, I could have misinterpreted Stefan's comments here http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00835.html Sorry if that is the case. > And why is it needed in emacs-25? Is there some urgent or > particularly nasty problem involved that we'd like to fix ASAP? It affects a feature that will be new in the release, as opposed to affecting a feature that existed in previous releases. --94eb2c06d362521d750538267e19 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Jul 21, 2016 10:28 AM, "Eli Zaretskii" <eliz@gnu.org> wrote:
>
> > From: John Wiegley <jwie= gley@gmail.com>
> > Cc: Stefan Monnier <monnier@iro.umontreal.ca>,=C2=A0 emacs-devel@gnu.org,=C2=A0 Eli Zaretskii <eliz@gnu.org>
> > Date: Thu, 21 Jul 2016 00:03:25 -0700
> >
> > > This ends up bring very simple--permission to push to emacs-= 25?
> >
> > If Eli agrees, it looks safe enough to me for the release.
>
> Sorry, I'm confused by the last message in the discussion of the > patch.=C2=A0 This started by introducing a new defcustom that controls= the
> preview, but ended with a patch adding no defcustom and instead
> deleting 3 lines?=C2=A0 What did I miss (specifically between
> http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00845.ht= ml,
> which approves the original patch, and

The new defcustom in the original patch would only prevent t= he preview if its value was nil and the minibuffer was empty.=C2=A0 If we a= gree on nil by default instead, and if the new variable is not worth adding= , then...

> http://lists.gnu.org/archive/html/emacs-devel/2016= -07/msg00911.html,
> which presents a totally different one)?

... this is the patch that achieves that. Of course, I could= have misinterpreted Stefan's comments here
http://lists.gnu.org/archive/html/emacs-devel/2016-07/msg00835.html
Sorry if that is the case.

> And why is it needed in emacs-25?=C2=A0 Is there some u= rgent or
> particularly nasty problem involved that we'd like to fix ASAP?

It affects a feature that will be new in the release, as opp= osed to affecting a feature that existed in previous releases.

--94eb2c06d362521d750538267e19--