From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ola Nilsson Newsgroups: gmane.emacs.bugs Subject: bug#36317: [PATCH v2] Allow underscore in defun-prompt-regex names for sh-script Date: Wed, 26 Jun 2019 22:58:06 +0200 Message-ID: References: <20190620230122.22553-1-ola.nilsson@gmail.com> <20190623210025.8366-1-ola.nilsson@gmail.com> <85y31p69y7.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="7612"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36317@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 22:59:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgF0m-0001rn-V9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 22:59:25 +0200 Original-Received: from localhost ([::1]:44876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgF0l-00080A-2G for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 16:59:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46442) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hgF0S-000802-Aw for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 16:59:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hgF0Q-0003FE-Kr for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 16:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51791) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hgF0Q-0003Er-7E for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 16:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hgF0Q-0002E7-30 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 16:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ola Nilsson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 20:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36317 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36317-submit@debbugs.gnu.org id=B36317.15615827078501 (code B ref 36317); Wed, 26 Jun 2019 20:59:02 +0000 Original-Received: (at 36317) by debbugs.gnu.org; 26 Jun 2019 20:58:27 +0000 Original-Received: from localhost ([127.0.0.1]:37102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgEzq-0002D0-4r for submit@debbugs.gnu.org; Wed, 26 Jun 2019 16:58:27 -0400 Original-Received: from mail-pf1-f180.google.com ([209.85.210.180]:34826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgEzo-0002Cm-9k for 36317@debbugs.gnu.org; Wed, 26 Jun 2019 16:58:25 -0400 Original-Received: by mail-pf1-f180.google.com with SMTP id d126so55110pfd.2 for <36317@debbugs.gnu.org>; Wed, 26 Jun 2019 13:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Tr6zVwWOz+u4qxqptUVSsRyX+C57D1yNufbHPac4JFM=; b=IscGqZfdtib0eBmr60jftZWNDCYMK5fkHVeMzbc8P4Sa2itNNOoBgbui9P/obYhyLB XPnV+8ItWxP6ojjBiARBw5M7M7kpY1ZlGpl6CVC0/pQPvF/XF6Rg9AKZcnG4rvp0vgg1 G4VWs9fqxlt/7o8UuNXP5xhoSXxoWbFBYnL79JQB6hVrJkdNf1KtPYt1hRd/0eAYtYgv t6PdYcCCNbtKFR3U+AN5r7P0sK3mUs25e0+mZHZHH0xyaYkqNdeqjZEplqARAAzD1/xQ Kps/Mw1c7s3uOxsCPwcE+oAoR9Ue7sxfxI5dERre26ebhbO/4FmHk2QjOfBgzzi5ssI+ A/wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tr6zVwWOz+u4qxqptUVSsRyX+C57D1yNufbHPac4JFM=; b=Jx0jdTAWSniMvmvbWidtgPb0NP2oQ9gXY8FaR+Ex6GzoLsHbFHcvVVMRVfsW0kLX7L nVLS4QYtQfI58lTsHRFK9EIlzdrrbYCdh0/R8gftdKGdyRTnP9Nozdrs70sjEmHPglCg /jwlFXKry8FFbKekEqiyvT8RTK/tkn5mt+so74UDMW3JaYtDbXw3XmLncH3ozKmIzdZT bf1WBgHYVtLyoSdaqLwQOqhUmNc3tJhH+H0IAmbK1Sbz86Frt644fcn0zwYDrpljeTsS eu2WCu1wdAVvsgLRNQxlDfVYAtpq+1zeul4HYfr7tq15n1LFPKqIFFpfOrOfU4HibBo4 mvEw== X-Gm-Message-State: APjAAAVHheMRB0kncpP3knQ3299sHA3XEs72PYEPMrpOB2+gQFZMOM3R fHAHvPHCb9f9sM5+hO/apvynYLHj8aGrsYXPAzE= X-Google-Smtp-Source: APXvYqxAPKQVrjV4vce9DSP9E4kyxidQlUc3Wbp6iwmlLCHVU5hfhJ2bSFEZoLTu7SzrNdhEgtRh/WDYnVA6k0TNi0s= X-Received: by 2002:a17:90a:ac13:: with SMTP id o19mr1264641pjq.143.1561582698168; Wed, 26 Jun 2019 13:58:18 -0700 (PDT) In-Reply-To: <85y31p69y7.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161541 Archived-At: On Tue, Jun 25, 2019 at 4:01 PM Noam Postavsky wrote: > > Ola Nilsson writes: > > > * lisp/progmodes/sh-script.el (defun-prompt-regexp): > > Allow underscore in function names. > > Do you think we should allow dashes as too (as suggested in Bug#21477)? Bug#21477 will not be fixed by changing defun-prompt-regexp. sh-script.el does not have a centralized way of dealing with function names. * imenu (the problem in Bug#21477) does not use defun-prompt-regexp, but rather its own regexp found in sh-imenu-generic-expression. Funnily enough those function names _do_ follow the posix standard (letters, digits, underscore, must not start with a digit). * sh-current-defun-name also has its own regexps, matching those of sh-imenu-generic-expression. * sh-font-lock-keyword-var uses "\\sw+" which is a lot less strict with what characters can be included. * sh-completion-at-point-function uses "[[:alnum:]_]" to skip to beginning and end of a function name. I assume there are some other cases that I missed. As far as I can tell from a quick search of shell manuals and net questions most shells stick to the posix spec. Bash is the exception and seems to be very forgiving at least as long as you use the 'function name() {...}' format. So I guess it boils down to how allowing we want to be. -- Ola Nilsson